The first fix attempt contained a nasty typo which somehow didn't get
caught in review. It also didn't work as intended because the sRGB
conversion was happening but then throwing away all but the red channel
because it dind't know it was RGB. Really, it's my fault for trying to
fix a bug without
V2: make use of visit_tree()
Fixes new piglit test:
tests/spec/glsl-1.20/execution/qualifiers/vs-out-conversion-int-to-float-vec4-index.shader_test
---
src/compiler/glsl/ast_function.cpp | 54 ++
1 file changed, 54 insertions(+)
diff --git a/src/compiler/glsl/ast_func
Reviewed-by: Timothy Arceri
On 21/07/18 01:08, Alejandro Piñeiro wrote:
---
src/mesa/drivers/dri/i965/brw_context.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/brw_context.c
index 968fc1d43d6..136f1325c6e 100644
-
Reviewed-by: Timothy Arceri
On 21/07/18 01:08, Alejandro Piñeiro wrote:
From: Neil Roberts
---
src/mesa/drivers/dri/i965/brw_link.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp
b/src/mesa/drivers/dri/i965/brw_link.cpp
index e7a940e15c2..0723
On 21/07/18 01:08, Alejandro Piñeiro wrote:
From: Neil Roberts
v2: ignore names on purpose, for consistency with other places where
we are doing the same (Alejandro)
---
src/compiler/Makefile.sources | 1 +
src/compiler/glsl/gl_nir_link_xfb.c | 289 ++
It seems like this would be much more compact as a
ir_hierarchical_visitor that only implements
visit_leave(ir_dereference_array *). Is there a reason that doesn't
work that I'm not seeing?
On 07/15/2018 01:04 AM, Timothy Arceri wrote:
> Fixes new piglit test:
> tests/spec/glsl-1.20/execution/qua
On 21/07/18 13:09, Timothy Arceri wrote:
Reviewed-by: Timothy Arceri
Actually I take that back. This introduces a dependency on GL in NIR,
maybe better to put this one in gl_nir_linker.h? If you agree that
change would be:
Reviewed-by: Timothy Arceri
On 21/07/18 01:08, Alejandro Piñeir
Reviewed-by: Timothy Arceri
On 21/07/18 01:08, Alejandro Piñeiro wrote:
From: Neil Roberts
---
src/compiler/nir_types.cpp | 6 ++
src/compiler/nir_types.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp
index 6f1182b742c
Reviewed-by: Timothy Arceri
On 21/07/18 01:08, Alejandro Piñeiro wrote:
For now we are just adding nir lowerings that are needed/mandatory to
get things working. After everything is settled, we would start to add
good-to-have lowerings.
This patch adds the following calls:
* nir_split_var_
1-3:
Reviewed-by: Timothy Arceri
On 21/07/18 01:08, Alejandro Piñeiro wrote:
From: Neil Roberts
These set the new explicit XFB members on nir_variable.
This is needed to support ARB_gl_spirv, as Vulkan doesn't support
transform feedback.
---
src/compiler/spirv/vtn_variables.c | 12 +++
Hi Martin,
On Sat, Jul 21, 2018 at 1:01 AM Martin Fuzzey
wrote:
>
> Hi,
>
> I am testing mesa / etnaviv / gbm_gralloc under Android 8.1 on i.MX6
>
> I discovered the screen capture function was not working (it was
> producing empty buffers).
>
> The reason for this seems to be that eglCreateImage
On Fri, Jul 20, 2018 at 1:21 PM, Caio Marcelo de Oliveira Filho
wrote:
> Delegating constructors is a C++11 feature, so this was breaking when
> compiling with C++98. Change the copy_propagation_state() calls that
> used the convenience constructor to use a static member function
> instead.
>
> Si
Hi Ian,
Are you able to take a look at this one? Looks like you have been
involved in this area in the past.
Thanks,
Tim
On 15/07/18 18:04, Timothy Arceri wrote:
Fixes new piglit test:
tests/spec/glsl-1.20/execution/qualifiers/vs-out-conversion-int-to-float-vec4-index.shader_test
---
src
On Fri, Jul 20, 2018 at 02:48:58PM -0700, Dylan Baker wrote:
> Hi Nanley,
>
> This applies cleanly to the 18.1 branch, but there is something else missing
> as
> it adds roughly 2200 regressions, see here:
> http://otc-mesa-ci.jf.intel.com/view/dev/job/dcbaker_18.1/66/testReport/
>
> For the mom
Thanks for the changes, this series is :
Reviewed-by: Lionel Landwerlin
On 20/07/18 22:50, Yunchao He wrote:
From: Ilia Mirkin
Allow the capability to be exposed, and convert the new execution mode
into fs state.
Signed-off-by: Ilia Mirkin
---
src/compiler/shader_info.h| 1 +
sr
The CI system says no regressions
On Fri, Jul 20, 2018 at 3:48 PM Yunchao He wrote:
> From: Ilia Mirkin
>
> Note that the use of ICMS_INNER_CONSERVATIVE disagrees with the GL driver.
> Perhaps it's more performant than ICMS_NORMAL and is otherwise permitted?
> Not sure, so I left it as-is.
>
>
On 20/07/18 14:53, Dave Airlie wrote> On 20 July 2018 at 13:12, Marek
Olšák wrote:
From: Marek Olšák
To make dEQP-GLES31.functional.ssbo.layout.random.all_shared_buffer.23
finish sooner on the older CPUs. (otherwise it gets killed and we fail
the test)
I think this is possibly a bad idea, si
https://bugs.freedesktop.org/show_bug.cgi?id=106156
Mark Janes changed:
What|Removed |Added
Depends on||106865
Referenced Bugs:
https://bugs.fre
Thanks for your review, Lionel.
It is done, with help from Jason. Please take a look at the latest 2 patches if
you have time.
BRs,
Yunchao
-Original Message-
From: Landwerlin, Lionel G
Sent: Friday, July 20, 2018 2:00 PM
To: He, Yunchao ; mesa-dev@lists.freedesktop.org
Subject: Re: [
From: Ilia Mirkin
Note that the use of ICMS_INNER_CONSERVATIVE disagrees with the GL driver.
Perhaps it's more performant than ICMS_NORMAL and is otherwise permitted?
Not sure, so I left it as-is.
Signed-off-by: Ilia Mirkin
---
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_pi
From: Ilia Mirkin
Allow the capability to be exposed, and convert the new execution mode
into fs state.
Signed-off-by: Ilia Mirkin
---
src/compiler/shader_info.h| 1 +
src/compiler/spirv/spirv_to_nir.c | 9 +
2 files changed, 10 insertions(+)
diff --git a/src/compiler/shader_i
In commit cf54bd5e8, dri_sw_winsys.c began using to support
the new functions putImageShm, getImageShm in DRI_SWRastLoader. But
Android began supporting System V shared memory only in Oreo. Nougat has
no shm headers.
Fix the build by ifdef'ing out the shm code on Nougat.
Fixes: cf54bd5e8 "drisw:
We support mipmapped and arrayed linear images so we need to support
vkGetImageSubresourceLayout on them. Fortunately, it's just a trivial
call into ISL.
---
src/intel/vulkan/anv_image.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/src/intel/vulkan/
Hi Nanley,
This applies cleanly to the 18.1 branch, but there is something else missing as
it adds roughly 2200 regressions, see here:
http://otc-mesa-ci.jf.intel.com/view/dev/job/dcbaker_18.1/66/testReport/
For the moment I've reverted it out of the staging/18.1 branch. If we need to
get it back
CC stable?
Reviewed-by: Bas Nieuwenhuizen
On Fri, Jul 20, 2018 at 6:48 PM, Samuel Pitoiset
wrote:
> modules[i] can be NULL for merged shaders but we have to
> free the NIR code. radv_can_dump_shader_stats() already handles
> if modules[i] is NULL, no need to check it twice.
>
> Signed-off-by:
Reviewed-by: Bas Nieuwenhuizen
Thanks!
On Fri, Jul 20, 2018 at 6:47 PM, Samuel Pitoiset
wrote:
> Users shouldn't use this debugging option except when we
> ask them to do!
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 4
> 1 file changed, 4 insertions(+)
>
> d
https://bugs.freedesktop.org/show_bug.cgi?id=107315
--- Comment #2 from Danilo Spinella ---
Terminal application kitty (https://github.com/kovidgoyal/kitty) crash on
Segmentation Fault.
The distro is Exherbo Linux with musl as libc.
Including glxinfo output and backtrace from gdb.
Tested with bo
https://bugs.freedesktop.org/show_bug.cgi?id=107315
--- Comment #1 from Danilo Spinella ---
Created attachment 140744
--> https://bugs.freedesktop.org/attachment.cgi?id=140744&action=edit
backtrace
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assigne
https://bugs.freedesktop.org/show_bug.cgi?id=107315
Bug ID: 107315
Summary: Segmentation Fault when calling glXSetupForCommand
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
On Tue, Jul 17, 2018 at 3:06 AM, Michel Dänzer wrote:
> On 2018-07-16 08:07 PM, Marek Olšák wrote:
>> On Mon, Jul 16, 2018 at 12:06 PM, Michel Dänzer wrote:
>>>
>>> It might be even better to compare the total number of frames rendered
>>> in a fixed amount of time, with multiple runs for each te
Hi there,
Since your version doesn't add very much to Ilia's series, it would be
nice to retain the initial authorship as well as the 2 patches (separate
generic infrastructure from driver enabling).
Jason also had a comment about the coverage variable that could be moved
into the next hunk.
https://bugs.freedesktop.org/show_bug.cgi?id=107305
--- Comment #2 from Caio Marcelo de Oliveira Filho ---
https://patchwork.freedesktop.org/patch/240128/
--
You are receiving this mail because:
You are the QA Contact for the bug.___
mesa-dev mailing
The original patch was from Ilia Mirkin. See the link at
https://patchwork.freedesktop.org/series/30443/. This one
rebased that patch, and it can pass the deqp cts right now.
---
src/compiler/shader_info.h | 1 +
src/compiler/spirv/spirv_to_nir.c | 9 +
src/intel/vulkan/anv_exte
https://bugs.freedesktop.org/show_bug.cgi?id=107295
--- Comment #8 from Roland Scheidegger ---
(In reply to Paul from comment #7)
> It's good to know you managed to pinpoint the issue, even if it's tricky to
> solve. Is there a particular reason to choose emit over pipeline? Does it
> perform bet
https://bugs.freedesktop.org/show_bug.cgi?id=107312
Bas Nieuwenhuizen changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Chema Casanova writes:
> El 20/07/18 a las 00:34, Francisco Jerez escribió:
>> Chema Casanova writes:
>>
>>> El 14/07/18 a las 00:14, Francisco Jerez escribió:
Jose Maria Casanova Crespo writes:
> For a register source/destination of an instruction the function returns
> the
Delegating constructors is a C++11 feature, so this was breaking when
compiling with C++98. Change the copy_propagation_state() calls that
used the convenience constructor to use a static member function
instead.
Since copy_propagation_state is expected to be heap allocated, this
change is a good
https://bugs.freedesktop.org/show_bug.cgi?id=107305
Caio Marcelo de Oliveira Filho changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |caio.olive...@intel.com
https://bugs.freedesktop.org/show_bug.cgi?id=107305
--- Comment #1 from Dylan Baker ---
This is sorta my fault, meson builds all c++ code with C++11 as the std, so
this works fine in meson.
At this point I think that just converting the glsl compiler to C++11 would be
fine, all of the major comp
https://bugs.freedesktop.org/show_bug.cgi?id=107313
--- Comment #2 from Jussi Pakkanen ---
To change compiler flags that originally come from CFLAGS et al on an existing
build dir, you should use `meson configure -Dc_args=...'.
We don't persist environment variables. That only leads to madness.
https://bugs.freedesktop.org/show_bug.cgi?id=107313
--- Comment #1 from Dylan Baker ---
The whole quote is:
Meson supports the standard CC and CXX environment variables for changing the
default compiler, and CFLAGS, CXXFLAGS, and LDFLAGS for setting options to the
compiler and linker. The defaul
On Friday, July 20, 2018 3:24:58 AM PDT Lionel Landwerlin wrote:
> The problem with passing the configuration of the dump lib through a
> file descriptor is that it can be read only once. But under gdb you
> might want to rerun your program multiple times.
>
> This change hands the configuration t
https://bugs.freedesktop.org/show_bug.cgi?id=107312
network...@rkmail.ru changed:
What|Removed |Added
CC||b...@basnieuwenhuizen.nl
--
You
https://bugs.freedesktop.org/show_bug.cgi?id=107313
Bug ID: 107313
Summary: Meson instructions on web site are non-optimal
Product: Mesa
Version: unspecified
Hardware: Other
OS: All
Status: NEW
Severity: n
https://bugs.freedesktop.org/show_bug.cgi?id=107312
Bug ID: 107312
Summary: Mesa-git RPM build fails after commit
8cacf38f527d42e41441ef8c25d95d4b2f4e8602
Product: Mesa
Version: git
Hardware: Other
OS: All
Timothy Arceri writes:
>> On 19.07.18 11:47, Timothy Arceri wrote:
>>> On 19/07/18 08:31, Eric Anholt wrote:
Danylo Piliaiev writes:
> After optimization passes and many trasfromations most of memory
"transformations"
> NIR holds is a garbage which was being free
Harish Krupo writes:
> Eric Anholt writes:
>
>> Harish Krupo writes:
>>
>>> Eric Anholt writes:
>>>
Harish Krupo writes:
> Hi Eric,
>
> Eric Anholt writes:
>
>> Harish Krupo writes:
>>
>>> The intension of the KHR_partial_update was not to send the dama
Thanks. I've pushed this and made some changes to it. See below for
the changes I made.
On Wed, Jul 18, 2018 at 5:48 PM, Sonny Jiang wrote:
> Signed-off-by: Sonny Jiang
> ---
> src/gallium/drivers/radeonsi/si_build_pm4.h | 24
> src/gallium/drivers/radeonsi/si_gfx_c
Reviewed-by: Jason Ekstrand
On Fri, Jul 20, 2018 at 11:01 AM Bas Nieuwenhuizen
wrote:
> There always is a continue block, so let us just do unreachable.
>
> Fixes: 8cacf38f527 "nir: Do not use continue block after removing it."
> CC: 18.1
> CC: Mark Janes
> ---
> src/compiler/nir/nir_opt_if.
On Thursday, 2018-07-19 21:39:05 +0200, Bas Nieuwenhuizen wrote:
> On Thu, Jul 19, 2018 at 6:48 PM, Eric Engestrom
> wrote:
> > On Wednesday, 2018-07-18 14:01:49 +0200, Bas Nieuwenhuizen wrote:
> >> radv always needs it, so just check the header instead. Also
> >> do not declare the function if th
On Fri, Jul 20, 2018 at 8:37 AM Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> On 20/07/18 11:44, Alex Smith wrote:
>
> According to the spec, these should apply to all read/write access
> types (so would be equivalent to specifying all other access types
> individually). Currently, t
There always is a continue block, so let us just do unreachable.
Fixes: 8cacf38f527 "nir: Do not use continue block after removing it."
CC: 18.1
CC: Mark Janes
---
src/compiler/nir/nir_opt_if.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/compiler/nir/nir_opt_if.c b/src/compiler/ni
https://bugs.freedesktop.org/show_bug.cgi?id=107295
--- Comment #7 from Paul ---
It's good to know you managed to pinpoint the issue, even if it's tricky to
solve. Is there a particular reason to choose emit over pipeline? Does it
perform better, for example?
I'm also wondering if this issue is
El 20/07/18 a las 00:34, Francisco Jerez escribió:
> Chema Casanova writes:
>
>> El 14/07/18 a las 00:14, Francisco Jerez escribió:
>>> Jose Maria Casanova Crespo writes:
>>>
For a register source/destination of an instruction the function returns
the read/write byte pattern of a 32-by
https://bugs.freedesktop.org/show_bug.cgi?id=107295
--- Comment #6 from Roland Scheidegger ---
Actually there might be some trouble with this. The vertex_id we use internally
(in the vertex header) are 16 bit too.
Although I believe they are not actually relevant when using the pt_emit paths
so m
https://bugs.freedesktop.org/show_bug.cgi?id=106893
--- Comment #11 from John ---
Alright, thank you for the explanation!
I'll add a safety note to my environment file about that so that I remember in
a few years :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You
modules[i] can be NULL for merged shaders but we have to
free the NIR code. radv_can_dump_shader_stats() already handles
if modules[i] is NULL, no need to check it twice.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Users shouldn't use this debugging option except when we
ask them to do!
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 80ddb65480..7dc6508333 100644
--- a/s
https://bugs.freedesktop.org/show_bug.cgi?id=106893
--- Comment #10 from Samuel Pitoiset ---
It is costly. You shouldn't set it. Basically, you don't have to set any RADV_
environment variables except when developers ask you to do. :-)
--
You are receiving this mail because:
You are the assigne
On Fri, Jul 20, 2018 at 8:09 AM Alejandro Piñeiro
wrote:
> From: Neil Roberts
>
> It looks like it was previously taking the SPIR-V instruction number
> directly instead of looking up the constant value.
> ---
> src/compiler/spirv/spirv_to_nir.c | 9 +++--
> 1 file changed, 7 insertions(+),
Should this be part of nir_gather_info?
On Fri, Jul 20, 2018 at 8:09 AM Alejandro Piñeiro
wrote:
> From: Neil Roberts
>
> Whenever a non-zero stream is written to it now sets uses_streams to
> true. This reflects the code in validate_geometry_shader_emissions for
> GLSL.
> ---
> src/compiler/s
I think it would be better to squash 5 and 6. With that,
Reviewed-by: Jason Ekstrand
On Fri, Jul 20, 2018 at 8:08 AM Alejandro Piñeiro
wrote:
> From SPIR-V 1.0 spec, section 3.20, "Decoration":
>
>"Stream
> Apply to an object or a member of a structure type. Indicates the
> stream
This should already be handled by nir_gather_info. Is there some reason
why we need to do it here as well?
On July 20, 2018 08:09:26 Alejandro Piñeiro wrote:
From: Neil Roberts
Whenever SpvOpEndPrimitive or SpvOpEndStreamPrimitive is encountered
it now sets uses_end_primitive to true. This
On Thu, Jul 12, 2018 at 6:55 AM, Gert Wollny wrote:
> When requesting a texture of the internal format GL_RGB32F Gallium will
> try to allocate a renderable texture and returns RGBA32F or RGBX32F, but
> when one requests GL_RGB32I or GL_RGB32UI the according 3-component
> texture will be returned.
On Thu, Jul 12, 2018 at 3:56 AM Gert Wollny wrote:
>
> When requesting a texture of the internal format GL_RGB32F Gallium will
> try to allocate a renderable texture and returns RGBA32F or RGBX32F, but
> when one requests GL_RGB32I or GL_RGB32UI the according 3-component
> texture will be returned
On Fri, Jul 20, 2018 at 11:24:58AM +0100, Lionel Landwerlin wrote:
> The problem with passing the configuration of the dump lib through a
> file descriptor is that it can be read only once. But under gdb you
> might want to rerun your program multiple times.
> This change hands the configuration t
On Fri, Jul 20, 2018 at 05:19:57PM +0100, Lionel Landwerlin wrote:
> When running gdb, make sure to pass the LD_PRELOAD variable only to
> the executed program, not the debugger. Otherwise the debugger will
> run the preloaded constructor/destructor too and bad things will
> happen.
>
> Suggested-
When running gdb, make sure to pass the LD_PRELOAD variable only to
the executed program, not the debugger. Otherwise the debugger will
run the preloaded constructor/destructor too and bad things will
happen.
Suggested-by: Rafael Antognolli
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/i
Reviewed-by: Gurchetan Singh
On Tue, Jul 3, 2018 at 4:32 AM Gert Wollny wrote:
>
> Signed-off-by: Gert Wollny
> ---
> Note that I used (1 << 3) instead of (1 << 2) because Dave's experimental
> patch
> already uses the latter for computer shader caps.
> The host side patch starting to implement
Ian Romanick writes:
> [ Unknown signature status ]
> On 07/18/2018 03:03 PM, Eric Anholt wrote:
>> Ian Romanick writes:
>>
>>> On 07/16/2018 02:46 PM, Eric Anholt wrote:
This fixes dEQP case:
dEQP-GLES2.functional.shaders.scoping.valid.local_variable_hides_function_parameter_fra
https://bugs.freedesktop.org/show_bug.cgi?id=106893
--- Comment #9 from John ---
Oh, I thought it'd be somewhat safe to leave it on for a while, when I was
having issues with radv, and then I forgot to unset it till recently.
Apart from this issue, is it costly to run?
--
You are receiving thi
https://bugs.freedesktop.org/show_bug.cgi?id=107295
--- Comment #5 from Roland Scheidegger ---
Ah actually I found the issue.
We cannot handle having more than a ushort number of vertices in
alloc_vertices() (possibly elsewhere too).
There's logic to split things into smaller chunks (the vsplit s
Hi,
I am testing mesa / etnaviv / gbm_gralloc under Android 8.1 on i.MX6
I discovered the screen capture function was not working (it was
producing empty buffers).
The reason for this seems to be that eglCreateImageKHR() with
EGL_NATIVE_BUFFER_ANDROID does not import the modifier information
https://bugs.freedesktop.org/show_bug.cgi?id=106958
--- Comment #11 from Samuel Pitoiset ---
Yeah, that patch can't fix the problem because DXVK doesn't use multiviews.
The apitrace doesn't replay correctly on my vega, it crashes at some point and
I can't see the rendering problem.
Can you try
https://bugs.freedesktop.org/show_bug.cgi?id=106958
--- Comment #10 from Giovanni ongaro ---
it did not fix the issue but i managed to get an apitrace can the apitrace be
useful?
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
https://bugs.freedesktop.org/show_bug.cgi?id=106893
--- Comment #8 from Samuel Pitoiset ---
Interesting, after checking memory usage with RADV_TRACE_FILE set and RoTR,
there is apparently a memory leak...
Note that RADV_TRACE_FILE should only be set for debugging purposes.
--
You are receiving
On 20/07/18 11:44, Alex Smith wrote:
According to the spec, these should apply to all read/write access
types (so would be equivalent to specifying all other access types
individually). Currently, they were doing nothing.
Signed-off-by: Alex Smith
Cc: mesa-sta...@lists.freedesktop.org
---
src
https://bugs.freedesktop.org/show_bug.cgi?id=107295
--- Comment #4 from Roland Scheidegger ---
(In reply to Paul from comment #2)
> I managed to build a debug version of Mesa3D 10.4.7 (version 18 is a
> pre-built binary without debugging information), and this is what I got for
> a callstack:
Tha
From: Neil Roberts
This just sets has_transform_feedback_varyings on the shader.
---
src/compiler/spirv/spirv_to_nir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
b/src/compiler/spirv/spirv_to_nir.c
index bbef3fcf4df..f9abd48261e 100644
From: Neil Roberts
These set the new explicit XFB members on nir_variable.
This is needed to support ARB_gl_spirv, as Vulkan doesn't support
transform feedback.
---
src/compiler/spirv/vtn_variables.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/compiler/s
From: Neil Roberts
---
src/compiler/nir_types.cpp | 6 ++
src/compiler/nir_types.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp
index 6f1182b742c..2085138c407 100644
--- a/src/compiler/nir_types.cpp
+++ b/src/compiler/nir_ty
From: Neil Roberts
These are copied from the from the corresponding values in
ir_variable. The intention is to eventually use them in a pure-NIR
linker.
---
src/compiler/glsl/glsl_to_nir.cpp | 4
src/compiler/nir/nir.h| 27 ++-
2 files changed, 30 insert
For now we are just adding nir lowerings that are needed/mandatory to
get things working. After everything is settled, we would start to add
good-to-have lowerings.
This patch adds the following calls:
* nir_split_var_copits and nir_split_per_member_structs: as vulkan
drivers are doing now.
---
src/compiler/shader_info.h| 2 ++
src/compiler/spirv/spirv_to_nir.c | 10 --
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h
index 3b95d5962c0..958e6bb98bf 100644
--- a/src/compiler/shader_info.h
+++ b/src
From: Neil Roberts
This just sets the stream on the nir_variable.
---
src/compiler/spirv/vtn_variables.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/compiler/spirv/vtn_variables.c
b/src/compiler/spirv/vtn_variables.c
index 6ff2e83515a..8dab86abd74 100644
--- a/sr
From: Neil Roberts
---
src/mesa/main/glspirv.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
index 8ad6c373914..ba4a8253671 100644
--- a/src/mesa/main/glspirv.c
+++ b/src/mesa/main/glspirv.c
@@ -173,6 +173,13 @@ _mesa_spirv_link_shad
For slightly more instruction cost, but simpler logic, you could also
retrieve the number of samples from the TIC. There's a query for that.
Not necessarily a good idea though, just a thought.
On Fri, Jul 20, 2018 at 10:56 AM, Rhys Perry wrote:
> NVC0_CB_AUX_BINDLESS_INFO isn't written to on Maxw
From: Neil Roberts
It looks like it was previously taking the SPIR-V instruction number
directly instead of looking up the constant value.
---
src/compiler/spirv/spirv_to_nir.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
b/src/c
From: Neil Roberts
v2: ignore names on purpose, for consistency with other places where
we are doing the same (Alejandro)
---
src/compiler/Makefile.sources | 1 +
src/compiler/glsl/gl_nir_link_xfb.c | 289
src/compiler/glsl/gl_nir_linker.h | 3
From: Neil Roberts
---
src/mesa/drivers/dri/i965/brw_link.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp
b/src/mesa/drivers/dri/i965/brw_link.cpp
index e7a940e15c2..0723255dec6 100644
--- a/src/mesa/drivers/dri/i965/brw_link.cpp
+++ b/src/mesa/dri
---
src/mesa/drivers/dri/i965/brw_context.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/brw_context.c
index 968fc1d43d6..136f1325c6e 100644
--- a/src/mesa/drivers/dri/i965/brw_context.c
+++ b/src/mesa/drivers/dri/i965/b
From: Neil Roberts
Whenever a non-zero stream is written to it now sets uses_streams to
true. This reflects the code in validate_geometry_shader_emissions for
GLSL.
---
src/compiler/spirv/spirv_to_nir.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/compiler/spirv/spirv_to_nir.c
b/
Hi,
this is the fourth series for the ongoing support for
ARB_gl_spirv. The main focus of this series is providing support for
transform feedback and geometry streams. Those two features are not
supported on Vulkan, so most of the patches are spirv/nir. Fortunately
the changes there are small, and
From: Neil Roberts
Whenever SpvOpEndPrimitive or SpvOpEndStreamPrimitive is encountered
it now sets uses_end_primitive to true. This reflects the code in
validate_geometry_shader_emissions for GLSL.
---
src/compiler/spirv/spirv_to_nir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/com
From SPIR-V 1.0 spec, section 3.20, "Decoration":
"Stream
Apply to an object or a member of a structure type. Indicates the
stream number to put an output on."
Note the "or", so that means that it is allowed for both a full struct
or a membef or a struct (although the wording is not re
NVC0_CB_AUX_BINDLESS_INFO isn't written to on Maxwell+ and it's too small
anyway.
This adds a new array, NVC0_CB_AUX_SU_MS_INFO, which aliases it and
provides the needed information.
Signed-off-by: Rhys Perry
---
.../drivers/nouveau/codegen/nv50_ir_driver.h | 1 +
.../nouveau/codegen/nv5
Reviewed-by: Bas Nieuwenhuizen
On Fri, Jul 20, 2018 at 3:07 PM, Samuel Pitoiset
wrote:
> That shouldn't be needed because the DB state is invalid.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_meta_resolve_fs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff
That shouldn't be needed because the DB state is invalid.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_meta_resolve_fs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_meta_resolve_fs.c
b/src/amd/vulkan/radv_meta_resolve_fs.c
index b652f12ac4
https://bugs.freedesktop.org/show_bug.cgi?id=107146
--- Comment #2 from Philip Meulengracht ---
Created attachment 140731
--> https://bugs.freedesktop.org/attachment.cgi?id=140731&action=edit
proposed patch
See my attachment for a proposed patch - I encounted this error too and removed
the ref
There still seem to be a few quirks (see below)
Best,
Gert
Am Freitag, den 20.07.2018, 06:36 +1000 schrieb Dave Airlie:
> From: Dave Airlie
>
> This adds the guest side support for
> ARB_shader_storage_buffer_object.
>
> Co-authors: Gurchetan Singh
>
> v2: move to using separate maximums
1 - 100 of 121 matches
Mail list logo
