The CI system says no regressions
On Fri, Jul 20, 2018 at 3:48 PM Yunchao He <yunchao...@intel.com> wrote:
> From: Ilia Mirkin <imir...@alum.mit.edu>
>
> Note that the use of ICMS_INNER_CONSERVATIVE disagrees with the GL driver.
> Perhaps it's more performant than ICMS_NORMAL and is otherwise permitted?
> Not sure, so I left it as-is.
>
> Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu>
> ---
> src/intel/vulkan/anv_extensions.py | 1 +
> src/intel/vulkan/anv_pipeline.c | 1 +
> src/intel/vulkan/genX_pipeline.c | 10 ++++++++--
> 3 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_extensions.py
> b/src/intel/vulkan/anv_extensions.py
> index adc1d75898..ea837744b4 100644
> --- a/src/intel/vulkan/anv_extensions.py
> +++ b/src/intel/vulkan/anv_extensions.py
> @@ -124,6 +124,7 @@ EXTENSIONS = [
> Extension('VK_EXT_shader_viewport_index_layer', 1, True),
> Extension('VK_EXT_shader_stencil_export', 1,
> 'device->info.gen >= 9'),
> Extension('VK_EXT_vertex_attribute_divisor', 2, True),
> + Extension('VK_EXT_post_depth_coverage', 1,
> 'device->info.gen >= 9'),
> ]
>
> class VkVersion:
> diff --git a/src/intel/vulkan/anv_pipeline.c
> b/src/intel/vulkan/anv_pipeline.c
> index 95a686f783..e91c146aad 100644
> --- a/src/intel/vulkan/anv_pipeline.c
> +++ b/src/intel/vulkan/anv_pipeline.c
> @@ -155,6 +155,7 @@ anv_shader_compile_to_nir(struct anv_pipeline
> *pipeline,
> .subgroup_vote = true,
> .stencil_export = device->instance->physicalDevice.info.gen >= 9,
> .storage_8bit = device->instance->physicalDevice.info.gen >= 8,
> + .post_depth_coverage = device->instance->physicalDevice.info.gen
> >= 9,
> },
> };
>
> diff --git a/src/intel/vulkan/genX_pipeline.c
> b/src/intel/vulkan/genX_pipeline.c
> index 0821d71c9f..6f6793e122 100644
> --- a/src/intel/vulkan/genX_pipeline.c
> +++ b/src/intel/vulkan/genX_pipeline.c
> @@ -1617,8 +1617,14 @@ emit_3dstate_ps_extra(struct anv_pipeline *pipeline,
> #if GEN_GEN >= 9
> ps.PixelShaderComputesStencil = wm_prog_data->computed_stencil;
> ps.PixelShaderPullsBary = wm_prog_data->pulls_bary;
> - ps.InputCoverageMaskState = wm_prog_data->uses_sample_mask ?
> - ICMS_INNER_CONSERVATIVE : ICMS_NONE;
> +
> + ps.InputCoverageMaskState = ICMS_NONE;
> + if (wm_prog_data->uses_sample_mask) {
> + if (wm_prog_data->post_depth_coverage)
> + ps.InputCoverageMaskState = ICMS_DEPTH_COVERAGE;
> + else
> + ps.InputCoverageMaskState = ICMS_INNER_CONSERVATIVE;
> + }
> #else
> ps.PixelShaderUsesInputCoverageMask =
> wm_prog_data->uses_sample_mask;
> #endif
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
