[Mesa-dev] [PATCH v4 (part2) 52/56] mesa: Add getters for the GL_ARB_shader_storage_buffer_object max constants

2015-07-22 Thread Samuel Iglesias Gonsalvez
v2: - Add tessellation shader constants support Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/main/get.c | 1 + src/mesa/main/get_hash_params.py | 14 ++ 2 files changed, 15 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 56cc3f2..a75

[Mesa-dev] [PATCH v4 (part2) 04/56] i965: set ARB_shader_storage_buffer_object related constant values

2015-07-22 Thread Samuel Iglesias Gonsalvez
v2: - Add tessellation shader constants assignment Signed-off-by: Samuel Iglesias Gonsalvez --- src/mesa/drivers/dri/i965/brw_context.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index b08a5

Re: [Mesa-dev] [PATCH] i965: Use updated kernel interface for accurate TIMESTAMP reads

2015-07-22 Thread Chris Forbes
This fixes my HSW getting dropped back to 3.2 most of the time, and seems like the reasonable thing to do. Tested-and-acked-by: Chris Forbes On Tue, Jul 21, 2015 at 11:58 PM, Chris Wilson wrote: > I was mistaken, I thought we already had fixed this in the kernel a > couple of years ago. We had

Re: [Mesa-dev] [PATCH v2 06/14] meta: Don't do fragment color clamping in _mesa_meta_pbo_GetTexSubImage

2015-07-22 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2015-07-22 at 11:54 -0700, Anuj Phogat wrote: > _mesa_meta_pbo_GetTexSubImage() uses _mesa_meta_BlitFrameBuffer(), > which will do fragment clamping if enabled. But fragment clamping > doesn't affect ReadPixels and GetTexImage. > > Without this patch, pigl

Re: [Mesa-dev] [PATCH 18/20] mesa: fill out the ARB_shader_subroutine APIs

2015-07-22 Thread Dave Airlie
On 23 July 2015 at 15:01, Kenneth Graunke wrote: > On Tuesday, July 21, 2015 03:19:25 PM Dave Airlie wrote: >> From: Dave Airlie >> >> This fleshes out the APIs, using the program resource >> APIs where they should match. >> >> It also sets the default values to valid subroutines. >> >> Signed-of

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 Samuel Iglesias changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 18/20] mesa: fill out the ARB_shader_subroutine APIs

2015-07-22 Thread Kenneth Graunke
On Tuesday, July 21, 2015 03:19:25 PM Dave Airlie wrote: > From: Dave Airlie > > This fleshes out the APIs, using the program resource > APIs where they should match. > > It also sets the default values to valid subroutines. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/shaderapi.c | 4

[Mesa-dev] [PATCH] glsl: Fix a bug where LHS swizzles of swizzles were too small.

2015-07-22 Thread Kenneth Graunke
A simple shader such as vec4 color; color.xy.x = 1.0; would cause ir_assignment::set_lhs() to generate bogus IR: (swiz xy (swiz x (constant float (1.0 We were setting the number of components of each new RHS swizzle based on the highest channel used in the LHS swizzle. So, .xy.y w

[Mesa-dev] [PATCH 1/2] doxygen: Correct grammatical typo in math/m_vector.h

2015-07-22 Thread rhyskidd
From: Rhys Kidd Signed-off-by: Rhys Kidd --- src/mesa/math/m_vector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/math/m_vector.h b/src/mesa/math/m_vector.h index 8551ee7..3b7f583 100644 --- a/src/mesa/math/m_vector.h +++ b/src/mesa/math/m_vector.h @@ -51,7 +51,

[Mesa-dev] [PATCH 2/2] doxygen: Link GLvector4f struct members properly, avoiding invalid XML/HTML warning

2015-07-22 Thread rhyskidd
From: Rhys Kidd Signed-off-by: Rhys Kidd --- src/mesa/math/m_vector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/math/m_vector.h b/src/mesa/math/m_vector.h index 3b7f583..5bd76b8 100644 --- a/src/mesa/math/m_vector.h +++ b/src/mesa/math/m_vector.h @@ -61,7 +61,

[Mesa-dev] [PATCH] glsl: Allow token pasting in ESSL

2015-07-22 Thread Ryan Houdek
All vendors I've tested allow token pasting in their ESSL shaders. At least one application expects this to be supported even though it is against spec. This would be the Dolphin GameCube/Wii emulator that requires this. The vendors I've tested that is known to support this is: ARM Mali Qualcomm Ad

Re: [Mesa-dev] [PATCH 16/78] i965/nir/vec4: Implement store_output intrinsic

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 4:37 AM, Eduardo Lima Mitev wrote: > On 07/13/2015 01:57 PM, Jason Ekstrand wrote: >> On Wed, Jul 8, 2015 at 11:54 PM, Eduardo Lima Mitev wrote: >>> On 06/30/2015 06:51 PM, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote: > T

Re: [Mesa-dev] [PATCH] glsl/tests: fix varying_test since tess changes.

2015-07-22 Thread Michel Dänzer
On 23.07.2015 10:14, Dave Airlie wrote: > From: Dave Airlie > > This fixes make check since the tess changes. > > Signed-off-by: Dave Airlie Tested-by: Michel Dänzer Please push this to fix make check. -- Earthling Michel Dänzer | http://www.amd.com Libre soft

Re: [Mesa-dev] [PATCH] docs/GL3.txt: ARB_shader_precision

2015-07-22 Thread Ilia Mirkin
In actuality it'll only be exposed on nvc0 atm... On Wed, Jul 22, 2015 at 9:20 PM, Dave Airlie wrote: > From: Dave Airlie > > This extension is about setting expectation on GL4.1 implementations > rather than actually enforcing things. So once you support GLSL 410 > then you support this in theo

[Mesa-dev] [PATCH] docs/GL3.txt: ARB_shader_precision

2015-07-22 Thread Dave Airlie
From: Dave Airlie This extension is about setting expectation on GL4.1 implementations rather than actually enforcing things. So once you support GLSL 410 then you support this in theory. Signed-off-by: Dave Airlie --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[Mesa-dev] [PATCH 1/2] i965: fix warning since tess merge.

2015-07-22 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 6c97933..33469d4 100644 --- a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH] i965: fix warning since tess merge.

2015-07-22 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 6c97933..33469d4 100644 --- a/src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH] glsl/tests: fix varying_test since tess changes.

2015-07-22 Thread Dave Airlie
From: Dave Airlie This fixes make check since the tess changes. Signed-off-by: Dave Airlie --- src/glsl/tests/varyings_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/tests/varyings_test.cpp b/src/glsl/tests/varyings_test.cpp index 4573529..62f8c6b 100644

[Mesa-dev] [PATCH 2/2] dispatch_sanity.cpp: remove commented out tess entries

2015-07-22 Thread Dave Airlie
From: Dave Airlie These entries were put in the GL4.0 section, so removed the commented out ones. Signed-off-by: Dave Airlie --- src/mesa/main/tests/dispatch_sanity.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-22 Thread Jose Fonseca
On 23/07/15 01:00, Brian Paul wrote: On 07/22/2015 05:31 PM, Jose Fonseca wrote: On 22/07/15 23:32, Brian Paul wrote: Hi Marek, This is regarding your commit "st/mesa: use pipe_sampler_view_release for releasing sampler views" from last October. Basically, we have: void st_texture_release_al

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-22 Thread Brian Paul
On 07/22/2015 05:31 PM, Jose Fonseca wrote: On 22/07/15 23:32, Brian Paul wrote: Hi Marek, This is regarding your commit "st/mesa: use pipe_sampler_view_release for releasing sampler views" from last October. Basically, we have: void st_texture_release_all_sampler_views(struct st_context *st,

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-22 Thread Jose Fonseca
On 22/07/15 23:32, Brian Paul wrote: Hi Marek, This is regarding your commit "st/mesa: use pipe_sampler_view_release for releasing sampler views" from last October. Basically, we have: void st_texture_release_all_sampler_views(struct st_context *st, struct

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 Antoine Labour changed: What|Removed |Added CC||pi...@chromium.org --- Comment #39 from

[Mesa-dev] [Bug 90311] Fail to build libglx with clang at linking stage

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90311 Julien Isorce changed: What|Removed |Added CC||emil.l.veli...@gmail.com --- Comment #3

[Mesa-dev] [RFC 19/16] nir: add atomic lowering support for AoA

2015-07-22 Thread Timothy Arceri
--- src/glsl/nir/nir_lower_atomics.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/glsl/nir/nir_lower_atomics.c b/src/glsl/nir/nir_lower_atomics.c index ce3615a..e5ec008 100644 --- a/src/glsl/nir/nir_lower_atomics.c +++ b/src/glsl/nir/nir_lower_atomi

[Mesa-dev] [RFC 18/16] nir: wrapper for glsl_type arrays_of_arrays_size()

2015-07-22 Thread Timothy Arceri
--- src/glsl/nir/nir_types.cpp | 6 ++ src/glsl/nir/nir_types.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp index 62176f5..06f5b0a 100644 --- a/src/glsl/nir/nir_types.cpp +++ b/src/glsl/nir/nir_types.cpp @@ -106,6 +106,12 @@

[Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

2015-07-22 Thread Brian Paul
Hi Marek, This is regarding your commit "st/mesa: use pipe_sampler_view_release for releasing sampler views" from last October. Basically, we have: void st_texture_release_all_sampler_views(struct st_context *st, struct st_texture_object *stObj) { GLuin

[Mesa-dev] [RFC 17/16] glsl: add AoA support for atmoic counters

2015-07-22 Thread Timothy Arceri
--- src/glsl/link_atomics.cpp | 73 +++ 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/src/glsl/link_atomics.cpp b/src/glsl/link_atomics.cpp index 100d03c..21f9af7 100644 --- a/src/glsl/link_atomics.cpp +++ b/src/glsl/link_atomics.cpp @@

[Mesa-dev] [RFC] AoA atomic counter follow-up fixes

2015-07-22 Thread Timothy Arceri
Hi Guys, These patches fix up AoA support for atomic counters following my change in approach to uniforms in V2 of my AoA GLES series. However I wanted to get some feedback mainly on the first patch as the end result is the whole AoA is marked as active which doesnt happen on Nvidia drivers. I g

Re: [Mesa-dev] [PATCH v2 7/7] nv50: enable GL_AMD_performance_monitor

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: This exposes a group of global performance counters that enables GL_AMD_performance_monitor. All piglit tests are okay. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 35 ++ src/gallium/dri

Re: [Mesa-dev] [PATCH v2 6/7] nv50: expose global performance counters to the HUD

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 41 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 1 + src/gallium/drivers/nouveau/nv50/nv50_screen.h | 3 ++ 3 files changed, 45 ins

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

2015-07-22 Thread Jose Fonseca
On 22/07/15 21:01, Jose Fonseca wrote: On 22/07/15 17:13, Jose Fonseca wrote: On 21/07/15 15:57, Emil Velikov wrote: On 18 July 2015 at 08:13, Jose Fonseca wrote: On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov writes: On 14/07/15 19:45, Eric Anholt wrote: These are really useful hi

Re: [Mesa-dev] [PATCH v2 5/7] nv50: add support for compute/graphics global performance counters

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: This commit adds support for both compute and graphics global performance counters which have been reverse engineered with CUPTI (Linux) and PerfKit (Windows). Currently, only one query type can be monitored at the same time because the Gallium's HUD doe

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 10:05 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Wed, Jul 22, 2015 at 12:31 AM, Francisco Jerez >> wrote: >>> Jason Ekstrand writes: >>> A few comments below. Mostly just asking for explanation. 1-3 are Reviewed-by: Jason Ekstr

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v4)

2015-07-22 Thread Jason Ekstrand
*whew*, I've made it through the entire series... On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez wrote: > Another resend of the i965 compiler-related changes for > ARB_shader_image_load_store, reworked to make use of the SIMD lowering > infrastructure introduced in a previous series [1]. For a

Re: [Mesa-dev] [PATCH 20/20] i965: Expose ARB_shader_image_load_store.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez wrote: > Reviewed-by: Paul Berry I'm sure that Paul still thinks this patch does what the commit message says. However, does the r-b really still apply to the rest of it? > --- > src/mesa/drivers/dri/i965/intel_extensions.c | 1 + > 1 file chan

Re: [Mesa-dev] [PATCH 18/20] i965/fs: Translate image load, store and atomic NIR intrinsics.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 149 > +++ > 1 file changed, 149 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > index 31

Re: [Mesa-dev] [PATCH 17/20] i965/fs: Handle image uniforms in NIR programs.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez wrote: > v2: Move the image_params array back to brw_stage_prog_data. > --- > src/mesa/drivers/dri/i965/brw_fs.h | 1 + > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 50 > +++- > 2 files changed, 43 insertions(+),

Re: [Mesa-dev] [PATCH 07/20] glsl/types: add new subroutine type (v3.1)

2015-07-22 Thread Kenneth Graunke
On Tuesday, July 21, 2015 03:19:14 PM Dave Airlie wrote: > From: Dave Airlie > > This type will be used to store the name of subroutine types > > as in subroutine void myfunc(void); > will store myfunc into a subroutine type. > > This is required to the parser can identify a subroutine > type i

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-22 Thread Jason Ekstrand
This all looks correct as far as I can tell. However, I'm very concerned about the number of checks such as has_matching_typed_format() that are built-in to the compiler (via surface_builder) where we then go on to do something that is highly dependant on state setup doing the exact same check (no

Re: [Mesa-dev] [PATCH v2 4/7] nv50: configure the ring buffer for reading back PM counters

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: To write data at the right offset, the kernel has to know some parameters of this ring buffer, like the number of domains and the maximum number of queries. Changes since v2: - only configure the ring buffer if the notifier BO is allocated - only use o

Re: [Mesa-dev] [PATCH 09/20] i965/fs: Import image format conversion primitives.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez wrote: > Define bitfield packing, unpacking and type conversion operations in > terms of which the image format conversion code will be implemented. > These don't directly know about image formats: The packing and > unpacking functions take a 4-tupl

Re: [Mesa-dev] [PATCH v2 2/7] nv50: allocate a software object class

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: This will allow to monitor global performance counters through the command stream of the GPU instead of using ioctls. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 11 +++ src/gallium/drivers/nouveau/nv50

Re: [Mesa-dev] [PATCH v2 1/7] nouveau: implement the nvif hardware performance counters interface

2015-07-22 Thread Martin Peres
On 01/07/15 01:01, Samuel Pitoiset wrote: This commit implements the base interface for hardware performance counters that will be shared between nv50 and nvc0 drivers. TODO: Bump libdrm version of mesa when nvif will be merged. Changes since v2: - remove double-query thing for domains, signa

[Mesa-dev] [PATCH] glx: Fix build warnings for PURE being redefined.

2015-07-22 Thread Eric Anholt
We can't completely drop this #define because it's used in the xserver generated code. Until someone gets around to putting xml generation directly in the server, we're stuck #defining it for them. --- src/mapi/glapi/gen/gl_XML.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

2015-07-22 Thread Jose Fonseca
On 22/07/15 17:13, Jose Fonseca wrote: On 21/07/15 15:57, Emil Velikov wrote: On 18 July 2015 at 08:13, Jose Fonseca wrote: On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov writes: On 14/07/15 19:45, Eric Anholt wrote: These are really useful hints to the compiler in the absence of li

Re: [Mesa-dev] [PATCH] mesa: initialize variables to silence compiler warnings

2015-07-22 Thread Anuj Phogat
On Tue, Jul 21, 2015 at 5:42 PM, Brian Paul wrote: > --- > src/mesa/main/fbobject.c | 4 ++-- > src/mesa/main/shaderapi.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index f46554b..cc342c2 100644 > --- a/src/me

Re: [Mesa-dev] [PATCH] radeon: Silence GCC unused-but-set-variable warnings.

2015-07-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jul 22, 2015 at 7:04 AM, Vinson Lee wrote: > radeon_fbo.c: In function 'radeon_map_renderbuffer_s8z24': > radeon_fbo.c:162:9: warning: variable 'ret' set but not used > [-Wunused-but-set-variable] > int ret; > ^ > radeon_fbo.c: In function '

Re: [Mesa-dev] [PATCH v4 3/6] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-07-22 Thread Ilia Mirkin
On Wed, Jul 22, 2015 at 2:55 PM, Ian Romanick wrote: > On 06/26/2015 07:38 AM, Ilia Mirkin wrote: >> On Fri, Jun 26, 2015 at 4:18 AM, Tapani Pälli wrote: >>> >>> >>> On 06/26/2015 01:06 AM, Ilia Mirkin wrote: On Thu, Jun 25, 2015 at 4:22 PM, Ilia Mirkin wrote: > > On Thu, Jun 2

Re: [Mesa-dev] [PATCH v4 3/6] mesa/es3.1: enable GL_ARB_texture_multisample for GLES 3.1

2015-07-22 Thread Ian Romanick
On 06/26/2015 07:38 AM, Ilia Mirkin wrote: > On Fri, Jun 26, 2015 at 4:18 AM, Tapani Pälli wrote: >> >> >> On 06/26/2015 01:06 AM, Ilia Mirkin wrote: >>> >>> On Thu, Jun 25, 2015 at 4:22 PM, Ilia Mirkin wrote: On Thu, Jun 25, 2015 at 5:08 AM, Marta Lofstedt wrote: > > From

[Mesa-dev] [PATCH v2 06/14] meta: Don't do fragment color clamping in _mesa_meta_pbo_GetTexSubImage

2015-07-22 Thread Anuj Phogat
_mesa_meta_pbo_GetTexSubImage() uses _mesa_meta_BlitFrameBuffer(), which will do fragment clamping if enabled. But fragment clamping doesn't affect ReadPixels and GetTexImage. Without this patch, piglit test arb_color_buffer_float-clear fails, when forced to use the meta pbo path. v2: Apply this

Re: [Mesa-dev] [PATCH 06/14] meta: Don't do fragment color clamping in case of ReadPixels

2015-07-22 Thread Anuj Phogat
On Tue, Jul 21, 2015 at 1:18 AM, Iago Toral wrote: > On Tue, 2015-07-21 at 09:24 +0200, Iago Toral wrote: >> On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: >> > Without this patch, piglit test arb_color_buffer_float-readpixels >> > fails, when forced to use the meta pbo path. >> > >> > Sign

Re: [Mesa-dev] [PATCH 07/20] i965/fs: Import image memory offset calculation code.

2015-07-22 Thread Jason Ekstrand
This needs a *lot* more commentary. These calculations are extremely tricky and there are almost no comments. For instance, you are turning a 2D offset on a tiled surface into a new 2D address into the raw view of the surface. Nowhere do you explain what the "raw" surface looks like and how its

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Brian Paul
On 07/22/2015 11:29 AM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the dimensions check after

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Ilia Mirkin
On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: > On 07/22/2015 11:02 AM, Ilia Mirkin wrote: >> >> This moves the width/height/depth == 0 check to the front and avoids >> doing any other checking when that is the case. >> >> Also moves the dimensions check after the format/type checks so that w

Re: [Mesa-dev] [PATCH 04/12] i965/fs: Pass a BAD_FILE header source to LOAD_PAYLOAD in emit_texture_gen7().

2015-07-22 Thread Francisco Jerez
Jason Ekstrand writes: > On Wed, Jul 22, 2015 at 12:43 AM, Francisco Jerez > wrote: >> Jason Ekstrand writes: >> >>> On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez >>> wrote: So that it's left uninitialized by LOAD_PAYLOAD, we only need to reserve space for it in the message sinc

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Brian Paul
On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the dimensions check after the format/type checks so that we don't bail out with success on a width/height/depth == 0 request

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 10:16 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Wed, Jul 22, 2015 at 10:02 AM, Francisco Jerez >> wrote: >>> Jason Ekstrand writes: >>> On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_f

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand writes: > On Wed, Jul 22, 2015 at 10:02 AM, Francisco Jerez > wrote: >> Jason Ekstrand writes: >> >>> On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez >>> wrote: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 63 +++- 1 file ch

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 --- Comment #4 from Brian Paul --- OK, the problem is my local copy of getteximage-invalid-format-for-packed-type.c has the patch "ext_packed_float: fix getteximage-invalid-format-for-packed-type test" which I posted for review (and was R-b'd by

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand writes: > On Wed, Jul 22, 2015 at 12:31 AM, Francisco Jerez > wrote: >> Jason Ekstrand writes: >> >>> A few comments below. Mostly just asking for explanation. >>> >>> 1-3 are >>> >>> Reviewed-by: Jason Ekstrand >>> >>> Obviously, don't merge 4/4 until it actually has users. >

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 10:02 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez >> wrote: >>> --- >>> src/mesa/drivers/dri/i965/brw_fs.cpp | 63 >>> +++- >>> 1 file changed, 55 insertions(+), 8 deletions(-

Re: [Mesa-dev] [PATCH 1/2] mesa: adjust error message when there's a missing teximage

2015-07-22 Thread Brian Paul
On 07/22/2015 11:02 AM, Ilia Mirkin wrote: The current message makes it seem like the zoffset is invalid. Signed-off-by: Ilia Mirkin --- src/mesa/main/texgetimage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand writes: > On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez > wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 63 >> +++- >> 1 file changed, 55 insertions(+), 8 deletions(-) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp >> b/src

[Mesa-dev] [PATCH 1/2] mesa: adjust error message when there's a missing teximage

2015-07-22 Thread Ilia Mirkin
The current message makes it seem like the zoffset is invalid. Signed-off-by: Ilia Mirkin --- src/mesa/main/texgetimage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index 59ec091..2f35ac6 100644 --- a/src/mesa/m

[Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Ilia Mirkin
This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the dimensions check after the format/type checks so that we don't bail out with success on a width/height/depth == 0 request when the format/type don't match. Bugzilla:

Re: [Mesa-dev] [PATCH] gallium/util: Stop bundling our snprintf implementation.

2015-07-22 Thread Brian Paul
On 07/22/2015 10:15 AM, Jose Fonseca wrote: Use MSVCRT functions instead. Their semantics are slightly different but they can be made to work as expected. Also, use the same code paths for both MSVCRT and MinGW. No testing yet. Just built. https://bugs.freedesktop.org/show_bug.cgi?id=91418 -

Re: [Mesa-dev] [PATCH 03/20] i965/fs: Implement lowering of logical surface instructions.

2015-07-22 Thread Jason Ekstrand
On Tue, Jul 21, 2015 at 9:38 AM, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 63 > +++- > 1 file changed, 55 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > i

Re: [Mesa-dev] [PATCH 18/78] i965: Take is_scalar_shader_stage() method out to allow reuse

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 4:26 AM, Eduardo Lima Mitev wrote: > On 07/13/2015 01:38 PM, Jason Ekstrand wrote: >> On Fri, Jul 10, 2015 at 8:53 AM, Eduardo Lima Mitev wrote: >>> On 06/30/2015 06:58 PM, Jason Ekstrand wrote: On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev wrote: > T

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 --- Comment #3 from Ilia Mirkin --- (In reply to Brian Paul from comment #1) > Hmm, I can't reproduce that. The test passes completely for me. > > What driver are you using? I'm testing llvmpipe/softpipe. Odd. I repro with llvmpipe. I guess t

Re: [Mesa-dev] [PATCH] targets/dri: scons: add missing link against libdrm

2015-07-22 Thread Jose Fonseca
On 22/07/15 16:04, Emil Velikov wrote: Otherwise the final dri module will have (additional) unresolved symbols. Cc: Brian Paul Cc: Jose Fonseca Signed-off-by: Emil Velikov --- We can only fix the remaining unresolved symbols (_glapi_foo), as we remove the non-shared glapi when building with

Re: [Mesa-dev] [PATCH 09/12] i965/fs: Hook up SIMD lowering to handle texturing opcodes of unsupported width.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:55 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez >> wrote: >>> This should match the set of cases in which we currently call fail() >>> or no16() from the emit_texture_*() methods and the ones in which >>> em

[Mesa-dev] [PATCH] gallium/util: Stop bundling our snprintf implementation.

2015-07-22 Thread Jose Fonseca
Use MSVCRT functions instead. Their semantics are slightly different but they can be made to work as expected. Also, use the same code paths for both MSVCRT and MinGW. No testing yet. Just built. https://bugs.freedesktop.org/show_bug.cgi?id=91418 --- src/gallium/auxiliary/Makefile.sources |

Re: [Mesa-dev] [PATCH 12/12] i965/fs: Reimplement emit_single_fb_write() in terms of logical framebuffer writes.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:54 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Thu, Jul 16, 2015 at 8:41 AM, Francisco Jerez >> wrote: >>> The only non-trivial thing it still has to do is figure out where to >>> take the src/dst depth values from and predicate the instruction if >>>

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

2015-07-22 Thread Jose Fonseca
On 21/07/15 15:57, Emil Velikov wrote: On 18 July 2015 at 08:13, Jose Fonseca wrote: On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov writes: On 14/07/15 19:45, Eric Anholt wrote: These are really useful hints to the compiler in the absence of link-time optimization, and I'm going to u

Re: [Mesa-dev] [PATCH 04/12] i965/fs: Pass a BAD_FILE header source to LOAD_PAYLOAD in emit_texture_gen7().

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:43 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez >> wrote: >>> So that it's left uninitialized by LOAD_PAYLOAD, we only need to >>> reserve space for it in the message since it will be initialized >>> implici

Re: [Mesa-dev] [PATCH 10/12] i965/fs: Reimplement emit_texture() in terms of logical send messages.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:41 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez >> wrote: >>> --- >>> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 66 >>> +--- >>> 1 file changed, 49 insertions(+), 17 deletions(

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-22 Thread Jason Ekstrand
On Wed, Jul 22, 2015 at 12:31 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> A few comments below. Mostly just asking for explanation. >> >> 1-3 are >> >> Reviewed-by: Jason Ekstrand >> >> Obviously, don't merge 4/4 until it actually has users. >> --Jason > > Thanks. > >> >> On Thu, J

Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-22 Thread Emil Velikov
It should be in master now. -Emil On 21 July 2015 at 23:34, Dylan Baker wrote: > Cool, I was under that impression too, but having it confirmed is great. > > Since these do matter and I don't have push access, could you make sure this > lands? > > On Jul 21, 2015 15:33, "Emil Velikov" wrote: >>

[Mesa-dev] [PATCH] targets/dri: scons: add missing link against libdrm

2015-07-22 Thread Emil Velikov
Otherwise the final dri module will have (additional) unresolved symbols. Cc: Brian Paul Cc: Jose Fonseca Signed-off-by: Emil Velikov --- We can only fix the remaining unresolved symbols (_glapi_foo), as we remove the non-shared glapi when building with DRI. With this we at least match the a

Re: [Mesa-dev] [PATCH 14/14] meta: Use _mesa_need_rgb_to_luminance_conversion() in decompress_texture_image()

2015-07-22 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/common/meta.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/met

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 --- Comment #2 from Michel Dänzer --- FWIW, I got the same regression with radeonsi. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ m

Re: [Mesa-dev] [PATCH 13/14] mesa: Change the signature of _mesa_need_rgb_to_luminance_conversion()

2015-07-22 Thread Iago Toral
Looks good to me, if this did not introduce any regressions: Reviewed-by: Iago Toral Quiroga On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: > This allows us to handle cases when texImage->_BaseFormat doesn't match > _mesa_format_get_base_format(texImage->Format). _BaseFormat is what we >

[Mesa-dev] [Bug 91387] Mesa 10.6.1 implementation error: invalid target in _swrast_choose_texture_sample_func

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91387 --- Comment #5 from Michael Godfrey --- I should have added that the graphics in my system is Intel HD 6000 in an Intel NUC5i5RYH. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

[Mesa-dev] [Bug 91387] Mesa 10.6.1 implementation error: invalid target in _swrast_choose_texture_sample_func

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91387 Brian Paul changed: What|Removed |Added CC||anuj.pho...@gmail.com --- Comment #4 from B

[Mesa-dev] [Bug 91387] Mesa 10.6.1 implementation error: invalid target in _swrast_choose_texture_sample_func

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91387 --- Comment #3 from Michael Godfrey --- Created attachment 117297 --> https://bugs.freedesktop.org/attachment.cgi?id=117297&action=edit backtrace -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 --- Comment #1 from Brian Paul --- Hmm, I can't reproduce that. The test passes completely for me. What driver are you using? I'm testing llvmpipe/softpipe. -- You are receiving this mail because: You are the QA Contact for the bug. You are

Re: [Mesa-dev] [PATCH 11/14] meta: Use _mesa_need_luminance_to_rgb_conversion() in decompress_texture_image()

2015-07-22 Thread Iago Toral
Patches 10-11 are Reviewed-by: Iago Toral Quiroga On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/common/meta.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/drivers/common/meta.c b/s

Re: [Mesa-dev] [PATCH V2 12/14] meta: Fix reading luminance texture as rgba in _mesa_meta_pbo_GetTexSubImage()

2015-07-22 Thread Iago Toral
The problem here is that the _mesa_meta_BlitFramebuffer is not setting G/B channels to 0.0 when doing Luminance/Intensity to RGBA conversions, so why not implement the fix in _mesa_meta_BlitFramebuffer directly? The GL spec expects frambuffer blits to handle these conversions properly, so it looks

Re: [Mesa-dev] [PATCH 16/78] i965/nir/vec4: Implement store_output intrinsic

2015-07-22 Thread Eduardo Lima Mitev
On 07/13/2015 01:57 PM, Jason Ekstrand wrote: > On Wed, Jul 8, 2015 at 11:54 PM, Eduardo Lima Mitev wrote: >> On 06/30/2015 06:51 PM, Jason Ekstrand wrote: >>> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev >>> wrote: The index into the output_reg array where to store the destination

Re: [Mesa-dev] [PATCH 18/78] i965: Take is_scalar_shader_stage() method out to allow reuse

2015-07-22 Thread Eduardo Lima Mitev
On 07/13/2015 01:38 PM, Jason Ekstrand wrote: > On Fri, Jul 10, 2015 at 8:53 AM, Eduardo Lima Mitev wrote: >> On 06/30/2015 06:58 PM, Jason Ekstrand wrote: >>> On Fri, Jun 26, 2015 at 1:06 AM, Eduardo Lima Mitev >>> wrote: This patch makes public the is_scalar_shader_stage() method in brw_s

[Mesa-dev] [PATCH] i965/fs: Fix calculation of the number of registers read in opt_copy_propagate.

2015-07-22 Thread Francisco Jerez
This seems to have been multiplying by stride twice since fs_inst::regs_read/regs_written were changed to return the value in register units rather than in dispatch_width-wide components. The value returned by fs_inst::regs_read() already takes into account the stride so it's wrong to do it again

Re: [Mesa-dev] [PATCH 02/12] st/dri: fix EGL_KHR_fence_sync since the last radeonsi change broke it

2015-07-22 Thread Michel Dänzer
On 17.07.2015 01:54, Marek Olšák wrote: > From: Marek Olšák > > Broken by f1be3d8cdde17a9b9ae283e1bab2f46b992d3bf3, which returns NULL > if no commands have been submitted. I've fixed that in radeonsi, so you can drop this patch. -- Earthling Michel Dänzer | http:/

[Mesa-dev] [Bug 91425] [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails

2015-07-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91425 Bug ID: 91425 Summary: [regression, bisected] Piglit spec/ext_packed_float/ getteximage-invalid-format-for-packed-type fails Product: Mesa Version: git Hardware: Other

Re: [Mesa-dev] [PATCH 01/12] i965/fs: Define logical framebuffer write opcode.

2015-07-22 Thread Francisco Jerez
Kenneth Graunke writes: > On Thursday, July 16, 2015 06:41:16 PM Francisco Jerez wrote: >> The logical variant is largely equivalent to the original opcode but >> instead of taking a single payload source it expects the arguments >> that make up the payload separately as individual sources, like:

Re: [Mesa-dev] [PATCH 09/12] i965/fs: Hook up SIMD lowering to handle texturing opcodes of unsupported width.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand writes: > On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez > wrote: >> This should match the set of cases in which we currently call fail() >> or no16() from the emit_texture_*() methods and the ones in which >> emit_texture_gen4() enables the SIMD16 workaround. >> >> Hint for re

Re: [Mesa-dev] [PATCH 12/12] i965/fs: Reimplement emit_single_fb_write() in terms of logical framebuffer writes.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand writes: > On Thu, Jul 16, 2015 at 8:41 AM, Francisco Jerez > wrote: >> The only non-trivial thing it still has to do is figure out where to >> take the src/dst depth values from and predicate the instruction if >> discard is in use. The manual SIMD unrolling logic in the dual-so

Re: [Mesa-dev] [PATCH 04/12] i965/fs: Pass a BAD_FILE header source to LOAD_PAYLOAD in emit_texture_gen7().

2015-07-22 Thread Francisco Jerez
Jason Ekstrand writes: > On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez > wrote: >> So that it's left uninitialized by LOAD_PAYLOAD, we only need to >> reserve space for it in the message since it will be initialized >> implicitly by the generator. >> --- >> src/mesa/drivers/dri/i965/brw_fs_

Re: [Mesa-dev] [PATCH 10/12] i965/fs: Reimplement emit_texture() in terms of logical send messages.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand writes: > On Sat, Jul 18, 2015 at 7:34 AM, Francisco Jerez > wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 66 >> +--- >> 1 file changed, 49 insertions(+), 17 deletions(-) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp

Re: [Mesa-dev] [PATCH 4/4] i965/fs: Implement pass to lower instructions of unsupported SIMD width.

2015-07-22 Thread Francisco Jerez
Jason Ekstrand writes: > A few comments below. Mostly just asking for explanation. > > 1-3 are > > Reviewed-by: Jason Ekstrand > > Obviously, don't merge 4/4 until it actually has users. > --Jason Thanks. > > On Thu, Jul 16, 2015 at 8:35 AM, Francisco Jerez > wrote: >> This lowering pass im

  1   2   >