Re: [Mesa-dev] [PATCH 4/5] i965: Implement interface to edit binding table entries

2015-05-19 Thread Pohjolainen, Topi
On Wed, May 20, 2015 at 09:32:09AM +0300, Abdiel Janulgue wrote: > Unlike normal software binding tables where the driver has to manually > generate and fill a binding table array which are then uploaded to the > hardware, the resource streamer instead presents the driver with an option > to fill o

Re: [Mesa-dev] [PATCH 3/5] i965: Enable hardware-generated binding tables on render path.

2015-05-19 Thread Pohjolainen, Topi
On Wed, May 20, 2015 at 09:32:08AM +0300, Abdiel Janulgue wrote: > This patch implements the binding table enable command which is also > used to allocate a binding table pool where where hardware-generated > binding table entries are flushed into. Each binding table offset in > the binding table p

Re: [Mesa-dev] [PATCH 1/5] i965: Define HW-binding table and resource streamer control opcodes

2015-05-19 Thread Pohjolainen, Topi
On Wed, May 20, 2015 at 09:32:06AM +0300, Abdiel Janulgue wrote: > Reviewed-by: Topi Pohjolainen > Signed-off-by: Abdiel Janulgue > --- > src/mesa/drivers/dri/i965/brw_defines.h | 24 > src/mesa/drivers/dri/i965/intel_reg.h | 3 +++ > 2 files changed, 27 insertions(+)

[Mesa-dev] [PATCH 4/5] i965: Implement interface to edit binding table entries

2015-05-19 Thread Abdiel Janulgue
Unlike normal software binding tables where the driver has to manually generate and fill a binding table array which are then uploaded to the hardware, the resource streamer instead presents the driver with an option to fill out slots for individual binding table indices. The hardware accumlates th

[Mesa-dev] [PATCH 5/5] i965: Upload binding tables in hw-generated binding table format.

2015-05-19 Thread Abdiel Janulgue
When hardware-generated binding tables are enabled, use the hw-generated binding table format when uploading binding table state. Normally, the CS will will just consume the binding table pointer commands as pipelined state. When the RS is enabled however, the RS flushes whatever edited surface st

[Mesa-dev] i965: Resource Streamer HW-binding tables

2015-05-19 Thread Abdiel Janulgue
I've decided to split my gather constants work into even smaller chunks to make it easier for reviewers which in turn makes it easier to merge. First in this patch series enables hardware-generated binding tables which is required for gather constants[*] to work. Chances since previous posting are

[Mesa-dev] [PATCH 3/5] i965: Enable hardware-generated binding tables on render path.

2015-05-19 Thread Abdiel Janulgue
This patch implements the binding table enable command which is also used to allocate a binding table pool where where hardware-generated binding table entries are flushed into. Each binding table offset in the binding table pool is unique per each shader stage that are enabled within a batch. Als

[Mesa-dev] [PATCH 2/5] i965: Pass resource streamer enable flags on batchbuffer start

2015-05-19 Thread Abdiel Janulgue
This is passed on the kernel to enable the resource streamer enable bit on MI_BATCHBUFFER_START Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_context.h | 1 + src/mesa/drivers/dri/i965/intel_batchbuffer.c | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) dif

[Mesa-dev] [PATCH 1/5] i965: Define HW-binding table and resource streamer control opcodes

2015-05-19 Thread Abdiel Janulgue
Reviewed-by: Topi Pohjolainen Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/brw_defines.h | 24 src/mesa/drivers/dri/i965/intel_reg.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 02/74] glsl: Add ir_var_buffer

2015-05-19 Thread Iago Toral
On Tue, 2015-05-19 at 15:14 -0700, Jordan Justen wrote: > On 2015-05-14 07:06:05, Iago Toral Quiroga wrote: > > From: Kristian Høgsberg > > > > This will be used to identify buffer variables inside shader storage > > buffer objects, which are very similar to uniforms except for a few > > differen

Re: [Mesa-dev] [PATCH 1/2] glsl: Allow dynamic sampler array indexing with GLSL ES < 3.00

2015-05-19 Thread Tapani Pälli
On 05/19/2015 04:20 PM, Francisco Jerez wrote: Tapani Pälli writes: Dynamic indexing of sampler arrays is prohibited by GLSL ES 3.00. Earlier versions allow 'constant-index-expression' indexing, where index can contain a loop induction variable. Patch allows dynamic indexing for sampler arr

Re: [Mesa-dev] [RFC 00/10] Enable support for 2D ASTC HDR and LDR formats

2015-05-19 Thread Ilia Mirkin
On Wed, May 20, 2015 at 12:35 AM, Jason Ekstrand wrote: > On Tue, May 19, 2015 at 7:08 PM, Ilia Mirkin wrote: >> Hi Nanley, >> >> I was expecting to see some code dealing with the fact that the block >> sizes are all different. Did I miss it, or is that still on the TODO >> list? > > I think *mos

Re: [Mesa-dev] [RFC 00/10] Enable support for 2D ASTC HDR and LDR formats

2015-05-19 Thread Jason Ekstrand
On Tue, May 19, 2015 at 7:08 PM, Ilia Mirkin wrote: > Hi Nanley, > > I was expecting to see some code dealing with the fact that the block > sizes are all different. Did I miss it, or is that still on the TODO > list? I think *most* of that code *should* already be there. In theory, it's all key

[Mesa-dev] [Bug 90081] [llvmpipe] piglit ext_transform_feedback-immediate-reuse-uniform-buffer regression

2015-05-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90081 Vinson Lee changed: What|Removed |Added Blocks||79706 -- You are receiving this mail becau

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-05-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Vinson Lee changed: What|Removed |Added Depends on||90081 -- You are receiving this mail becau

[Mesa-dev] [Bug 90346] DispatchSanity_test.GLES2 regression

2015-05-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90346 Vinson Lee changed: What|Removed |Added CC||airl...@freedesktop.org Blocks|

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-05-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Vinson Lee changed: What|Removed |Added Depends on||90346 -- You are receiving this mail becau

Re: [Mesa-dev] [PATCH v2 12/15] nv50/ir: optimize the use of std::tr1::unordered_set

2015-05-19 Thread Ilia Mirkin
Francisco, any opinion on this patch (as the resident C++ expert)? It seems a little odd. I'd just as soon skip this, and just use "using std::tr1::unordered_set" or "using std::unordered_set" as necessary in the next patch. But perhaps this is a common technique? On Tue, May 19, 2015 at 11:25 PM,

[Mesa-dev] [PATCH v2 12/15] nv50/ir: optimize the use of std::tr1::unordered_set

2015-05-19 Thread Chih-Wei Huang
Instead of using unordered_set directly, the patch changes to use unordered_set and adds a wrapper template class to convert the iterators to the expected user-defined type. This avoid instantiating the template multiple times and make the object code be smaller about 4KB. Signed-off-by: Chih-Wei

[Mesa-dev] [PATCH v2 14/15] android: nv50/ir: make the code be compatible with stlport

2015-05-19 Thread Chih-Wei Huang
The stlport uses std::tr1::unordered_set instead of std::unordered_set. Besides, std::isfinite has to be exported. Determine whether to build with lollipop libcxx or stlport. Signed-off-by: Chih-Wei Huang --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 5 + 1 file changed, 5 insertions(

[Mesa-dev] [PATCH v2 08/15] egl/main: let EGL_RECORDABLE_ANDROID be a valid attrib

2015-05-19 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/egl/main/eglconfig.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/main/eglconfig.h b/src/egl/main/eglconfig.h index 84cb227..7121b3d 100644 --- a/src/egl/main/eglconfig.h +++ b/src/egl/main/eglconfig.h @@ -86,6 +86,7 @@ struct _egl_config

[Mesa-dev] [PATCH v2 13/15] nv50/ir: use C++11 compliant unordered_set if possible

2015-05-19 Thread Chih-Wei Huang
If build with C++11 standard, use std::unordered_set instead of std::tr1::unordered_set. Signed-off-by: Chih-Wei Huang --- Android.common.mk | 1 + src/gallium/auxiliary/Android.mk | 2 -- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 8 ++-- 3 file

[Mesa-dev] [PATCH v2 07/15] android: clean up the makefile of libGLES_mesa

2015-05-19 Thread Chih-Wei Huang
Most of the rules for the gallium drivers has been moved to src/gallium/targets/dri/Android.mk. Signed-off-by: Chih-Wei Huang --- src/egl/main/Android.mk | 75 + 1 file changed, 1 insertion(+), 74 deletions(-) diff --git a/src/egl/main/Android.mk

[Mesa-dev] [PATCH v2 02/15] android: export more dirs from libmesa_dri_common

2015-05-19 Thread Chih-Wei Huang
The include paths of libmesa_dri_common are also used by modules that need libmesa_dri_common. Signed-off-by: Chih-Wei Huang --- src/mesa/drivers/dri/common/Android.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/Android.mk b/src/mesa/driver

[Mesa-dev] [PATCH v2 05/15] android: enable the rules to build gallium st/dri

2015-05-19 Thread Chih-Wei Huang
The libmesa_dri_common and libmesa_egl_dri2 should not be limited to the classical drivers only. Allow them to be built with the gallium drivers. v2: add a clean step to rebuild all dri modules properly. Signed-off-by: Chih-Wei Huang --- Android.mk | 6 +- CleanSpec.mk

[Mesa-dev] [PATCH v2 15/15] android: build with libcxx of android lollipop

2015-05-19 Thread Chih-Wei Huang
The libcxx introduced in android lollipop can be used to replace stlport. Fallback to use stlport when build with earlier android releases. Signed-off-by: Chih-Wei Huang --- Android.common.mk | 1 + src/gallium/drivers/nouveau/Android.mk | 4 src/gallium/drivers/r600/A

[Mesa-dev] [PATCH v2 04/15] android: add rules to build gallium_dri.so

2015-05-19 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/gallium/Android.mk | 7 +- src/gallium/targets/dri/Android.mk | 112 +++ src/gallium/winsys/sw/dri/Android.mk | 35 ++ src/gallium/winsys/sw/kms-dri/Android.mk | 37 ++ 4 files change

[Mesa-dev] [PATCH v2 11/15] android: avoid building errors with stlport

2015-05-19 Thread Chih-Wei Huang
The gallium debugging helpers have defined the assert macro. It causes some errors when build with Android stlport. To workaround it, do not include assert.h if the assert macro has been defined. Signed-off-by: Chih-Wei Huang --- src/util/list.h | 2 ++ 1 file changed, 2 insertions(+) diff --g

[Mesa-dev] [PATCH v2 01/15] android: loader: export the path to be included

2015-05-19 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/egl/drivers/dri2/Android.mk | 1 - src/loader/Android.mk | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/Android.mk b/src/egl/drivers/dri2/Android.mk index 5931ce8..d4d809b 100644 --- a/src/egl/drivers/dri2

[Mesa-dev] [PATCH v2 00/15] More Android patches

2015-05-19 Thread Chih-Wei Huang
This is the v2 series of patches for Android. Tested OK with Android-x86 lollipop-x86 branch. Summary of the changes: * Use C++11 compliant unordered_set to fix nouveau driver with Android stlport and libcxx (lollipop). * Add gallium_dri.so for Android. This fixes gallium support since 5564c36. *

[Mesa-dev] [PATCH v2 03/15] android: add rules to build gallium/state_trackers/dri

2015-05-19 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/gallium/Android.mk| 5 ++- src/gallium/state_trackers/dri/Android.mk | 64 +++ 2 files changed, 67 insertions(+), 2 deletions(-) create mode 100644 src/gallium/state_trackers/dri/Android.mk diff --git a/src/g

[Mesa-dev] [PATCH v2 09/15] android: generate files by $(call es-gen)

2015-05-19 Thread Chih-Wei Huang
Use the pre-defined macro es-gen to generate new added files instead of writing new rules manually. The handmade rules that may generate the files before the directory is created result in such an error: /bin/bash: out/target/product/x86/gen/STATIC_LIBRARIES/libmesa_st_mesa_intermediates/main/for

[Mesa-dev] [PATCH v2 10/15] android: enable the radeonsi driver

2015-05-19 Thread Chih-Wei Huang
Based on the nice work of Paulo Sergio Travaglia . The main modifications are: - Include paths for LLVM header files and shared/static libraries - Set C++ flag "c++11" to avoid compiling errors on LLVM header files - Set defines for LLVM - Add GALLIVM source files - Changes path of libelf library

[Mesa-dev] [PATCH v2 06/15] android: try to load gallium_dri.so directly

2015-05-19 Thread Chih-Wei Huang
To avoid the trick of creating links for all dri drivers. Signed-off-by: Chih-Wei Huang --- src/egl/drivers/dri2/egl_dri2.c | 4 1 file changed, 4 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index fe5cbc8..7fc9f78 100644 --- a/src/egl/driver

Re: [Mesa-dev] [PATCH 14.1/15] glapi: Store exec table version info outside the XML

2015-05-19 Thread Ilia Mirkin
On Tue, May 19, 2015 at 3:54 PM, Ian Romanick wrote: > From: Ian Romanick > > Currently on the functions that are exclusive to core-profile are > implemented. The remainder continue to live in the XML. Additional > functions can be moved later. > > The functions for GL_ARB_draw_indirect and GL_

Re: [Mesa-dev] [RFC 10/10] i965: enable ASTC support for Skylake

2015-05-19 Thread Ilia Mirkin
On Tue, May 19, 2015 at 10:16 PM, Matt Turner wrote: > On Tue, May 19, 2015 at 5:48 PM, Nanley Chery wrote: >> From: Nanley Chery >> >> Signed-off-by: Nanley Chery >> --- >> src/mesa/drivers/dri/i965/intel_extensions.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/src/mesa/

Re: [Mesa-dev] [RFC 09/10] i965/surface_formats: add support for 2D ASTC surface formats

2015-05-19 Thread Matt Turner
On Tue, May 19, 2015 at 5:48 PM, Nanley Chery wrote: > From: Nanley Chery > > Intel surface formats default to LDR unless there is hardware > support for HDR and the texture is able to be processed in HDR mode. > > Signed-off-by: Nanley Chery > --- > src/mesa/drivers/dri/i965/brw_defines.h

Re: [Mesa-dev] [RFC 10/10] i965: enable ASTC support for Skylake

2015-05-19 Thread Matt Turner
On Tue, May 19, 2015 at 5:48 PM, Nanley Chery wrote: > From: Nanley Chery > > Signed-off-by: Nanley Chery > --- > src/mesa/drivers/dri/i965/intel_extensions.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c > b/src/mesa/drivers/dri/i9

Re: [Mesa-dev] [RFC 08/10] mesa/formats: store whether or not a format is sRGB in gl_format_info

2015-05-19 Thread Matt Turner
On Tue, May 19, 2015 at 5:48 PM, Nanley Chery wrote: > From: Nanley Chery > > Signed-off-by: Nanley Chery > --- > src/mesa/main/format_info.py | 2 ++ > src/mesa/main/formats.c | 29 + > 2 files changed, 7 insertions(+), 24 deletions(-) > > diff --git a/src/mes

Re: [Mesa-dev] [RFC 04/10] mesa: add ASTC extensions to the extensions table

2015-05-19 Thread Matt Turner
On Tue, May 19, 2015 at 5:48 PM, Nanley Chery wrote: > From: Nanley Chery > > Signed-off-by: Nanley Chery > --- > src/mesa/main/extensions.c | 3 +++ > src/mesa/main/mtypes.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c

Re: [Mesa-dev] [RFC 00/10] Enable support for 2D ASTC HDR and LDR formats

2015-05-19 Thread Ilia Mirkin
Hi Nanley, I was expecting to see some code dealing with the fact that the block sizes are all different. Did I miss it, or is that still on the TODO list? Cheers, -ilia P.S. Congrats on your first public patch submission to mesa-dev :) On Tue, May 19, 2015 at 8:48 PM, Nanley Chery wrote: >

Re: [Mesa-dev] [RFC 02/10] glapi: add support for KHR_texture_compression_astc_ldr

2015-05-19 Thread Ilia Mirkin
On Tue, May 19, 2015 at 8:48 PM, Nanley Chery wrote: > From: Nanley Chery > > Signed-off-by: Nanley Chery > --- > .../glapi/gen/KHR_texture_compression_astc.xml | 40 > ++ > src/mapi/glapi/gen/Makefile.am | 1 + > src/mapi/glapi/gen/gl_API.xml

Re: [Mesa-dev] [PATCH 2/2] nir: Get rid of the array elements parameter on load/store intrinsics

2015-05-19 Thread Connor Abbott
On Tue, May 19, 2015 at 8:28 PM, Jason Ekstrand wrote: > Previously, we used intrinsic->const_index[1] to represent "the number of > array elements to load" for load/store intrinsics. However, this set to 1 > by every pass that ever creates a load/store intrinsic. Also, while it > might make som

[Mesa-dev] [RFC 10/10] i965: enable ASTC support for Skylake

2015-05-19 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- src/mesa/drivers/dri/i965/intel_extensions.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 18b69a0..91ff6e4 100644 --- a/src/mesa/dri

[Mesa-dev] [RFC 00/10] Enable support for 2D ASTC HDR and LDR formats

2015-05-19 Thread Nanley Chery
From: Nanley Chery This patch series adds support for the KHR_texture_compression_astc_{ldr,hdr} extensions. The last two commits enable support for Skylake systems. Some rendering issues were encountered during testing, so there is some more work to be done on this feature. The Piglit tests for

[Mesa-dev] [RFC 07/10] mesa/teximage: return the base internal format of the ASTC formats

2015-05-19 Thread Nanley Chery
From: Nanley Chery This is necesary to initialize the gl_texture_image struct. From the KHR_texture_compression_astc_ldr spec: "Added to Section 3.8.6, Compressed Texture Images Add the tokens specified above to Table 3.16, Compressed Internal Formats. In all cases, the base internal fo

[Mesa-dev] [RFC 08/10] mesa/formats: store whether or not a format is sRGB in gl_format_info

2015-05-19 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- src/mesa/main/format_info.py | 2 ++ src/mesa/main/formats.c | 29 + 2 files changed, 7 insertions(+), 24 deletions(-) diff --git a/src/mesa/main/format_info.py b/src/mesa/main/format_info.py index 40104a2..81

[Mesa-dev] [RFC 06/10] mesa/texcompress: enable translation between MESA and GL ASTC formats

2015-05-19 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- src/mesa/main/texcompress.c | 114 1 file changed, 114 insertions(+) diff --git a/src/mesa/main/texcompress.c b/src/mesa/main/texcompress.c index 1654fc6..203a065 100644 --- a/src/mesa/main/texcompr

[Mesa-dev] [RFC 04/10] mesa: add ASTC extensions to the extensions table

2015-05-19 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- src/mesa/main/extensions.c | 3 +++ src/mesa/main/mtypes.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index c82416a..daf16f9 100644 --- a/src/mesa/main/extensions.c +++ b/

[Mesa-dev] [RFC 05/10] mesa/glformats: recognize ASTC formats as compressed

2015-05-19 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- src/mesa/main/glformats.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 8ced579..d1dfb7a 100644 --- a/src/mesa/main/glformats.c +++ b/src/mesa/main

[Mesa-dev] [RFC 09/10] i965/surface_formats: add support for 2D ASTC surface formats

2015-05-19 Thread Nanley Chery
From: Nanley Chery Intel surface formats default to LDR unless there is hardware support for HDR and the texture is able to be processed in HDR mode. Signed-off-by: Nanley Chery --- src/mesa/drivers/dri/i965/brw_defines.h | 36 + src/mesa/drivers/dri/i965/brw_surface_format

[Mesa-dev] [RFC 02/10] glapi: add support for KHR_texture_compression_astc_ldr

2015-05-19 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- .../glapi/gen/KHR_texture_compression_astc.xml | 40 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 2 +- 3 files changed, 42 insertions(+), 1 deletion

[Mesa-dev] [RFC 03/10] mesa: disable online compression for ASTC formats

2015-05-19 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- src/mesa/main/texcompress.c | 22 ++ src/mesa/main/teximage.c| 28 2 files changed, 50 insertions(+) diff --git a/src/mesa/main/texcompress.c b/src/mesa/main/texcompress.c index 0fd1a36..165

[Mesa-dev] [RFC 01/10] mesa/formats: define the 2D ASTC formats

2015-05-19 Thread Nanley Chery
From: Nanley Chery Includes definition of the formats, updates to functions likely to be used, as well as changes necessary for compilation. Signed-off-by: Nanley Chery --- src/mesa/main/format_info.py | 3 + src/mesa/main/formats.c | 130 +++ src

[Mesa-dev] [PATCH] i965/fs: Fix implied_mrf_writes for scratch writes

2015-05-19 Thread Jason Ekstrand
We build the entire message in the generator so all the MRF writes are implied. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 9b3186b..42a0d78 100644 --

[Mesa-dev] [PATCH 1/2] prog_to_nir: Use a variable for uniform data

2015-05-19 Thread Jason Ekstrand
Previously, the prog_to_nir pass was directly generating uniform load/store intrinsics. This converts it to use a single giant "parameters" variable and we now depend on lowering to get the uniform load/store intrinsics. One advantage of this is that we now have one code-path after we do the initi

[Mesa-dev] [PATCH 2/2] nir: Get rid of the array elements parameter on load/store intrinsics

2015-05-19 Thread Jason Ekstrand
Previously, we used intrinsic->const_index[1] to represent "the number of array elements to load" for load/store intrinsics. However, this set to 1 by every pass that ever creates a load/store intrinsic. Also, while it might make some sense for registers, it makes no sense whatsoever in SSA. On t

Re: [Mesa-dev] [PATCH 6/6] softpipe: start adding gather support

2015-05-19 Thread Brian Paul
On 05/19/2015 03:48 PM, Dave Airlie wrote: From: Dave Airlie This adds both ARB_texture_gather and the enhanced gather for ARB_gpu_shader5. This passes all the piglit tests, it relies on the GLSL lowering pass to make textureGatherOffsets work. Signed-off-by: Dave Airlie --- src/gallium/dr

Re: [Mesa-dev] [PATCH 1/6] softpipe: move some image filter parameters into a struct

2015-05-19 Thread Brian Paul
On 05/19/2015 03:48 PM, Dave Airlie wrote: From: Dave Airlie This moves some of the image filter args into a struct, and passes that instead, this is prep work for adding texture gather support which needs new arguments. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_tex_sam

[Mesa-dev] [PATCH 2/6] softpipe: move control into a filter args struct

2015-05-19 Thread Dave Airlie
From: Dave Airlie more stuff for offsets and gather will go in here later. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_tex_sample.c | 50 +++- src/gallium/drivers/softpipe/sp_tex_sample.h | 8 +++-- 2 files changed, 32 insertions(+), 26 deletions(-)

[Mesa-dev] [PATCH 1/6] softpipe: move some image filter parameters into a struct

2015-05-19 Thread Dave Airlie
From: Dave Airlie This moves some of the image filter args into a struct, and passes that instead, this is prep work for adding texture gather support which needs new arguments. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_tex_sample.c | 468 --- src/g

[Mesa-dev] softpipe textureOffset and textureGather support

2015-05-19 Thread Dave Airlie
Hi, These patches firstly rework the softpipe internal sampling interfaces (and save a couple of k codesize), they then add the missing textureOffset support and finally add ARB_texture_gather and gpu_shader5 texture gather support. Dave. ___ mesa-dev

[Mesa-dev] [PATCH 3/6] softpipe: add textureOffset support.

2015-05-19 Thread Dave Airlie
From: Dave Airlie This was an oversight when GLSL1.30 was enabled, I think my misunderstanding. This fixes a bunch of tex-miplevel-selection tests under softpipe, and is required for textureGather support. I'm not sure this won't make sampling slowering, but its softpipe, correctness first and

[Mesa-dev] [PATCH 6/6] softpipe: start adding gather support

2015-05-19 Thread Dave Airlie
From: Dave Airlie This adds both ARB_texture_gather and the enhanced gather for ARB_gpu_shader5. This passes all the piglit tests, it relies on the GLSL lowering pass to make textureGatherOffsets work. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_screen.c | 5 +- src/g

[Mesa-dev] [PATCH 4/6] tgsi: handle TG4 opcode in tgsi exec

2015-05-19 Thread Dave Airlie
From: Dave Airlie This just adds a new modifier interface for drivers to implement. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 11 ++- src/gallium/auxiliary/tgsi/tgsi_exec.h | 3 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/galli

[Mesa-dev] [PATCH 5/6] softpipe: use arrays to make gather easier

2015-05-19 Thread Dave Airlie
From: Dave Airlie This is a prep change for gather, and it makes more sense to use an array in these cases. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_tex_sample.c | 72 ++-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH 02/74] glsl: Add ir_var_buffer

2015-05-19 Thread Jordan Justen
On 2015-05-14 07:06:05, Iago Toral Quiroga wrote: > From: Kristian Høgsberg > > This will be used to identify buffer variables inside shader storage > buffer objects, which are very similar to uniforms except for a few > differences, most important of which is that they are writable. > > Since b

Re: [Mesa-dev] [PATCH 13/15] Revert "mesa: Make GL_TEXTURE_CUBE_MAP valid in FramebufferTextureLayer"

2015-05-19 Thread Fredrik Höglund
On Tuesday 19 May 2015, Ian Romanick wrote: > On 05/19/2015 09:22 AM, Fredrik Höglund wrote: > > On Monday 18 May 2015, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> This reverts commit 03420eac0c53280beae5f72783e52950fd1e3fba. > > > > Did you mean to revert this commit? > > I did, but t

Re: [Mesa-dev] [PATCH 13/15] Revert "mesa: Make GL_TEXTURE_CUBE_MAP valid in FramebufferTextureLayer"

2015-05-19 Thread Ian Romanick
On 05/19/2015 09:22 AM, Fredrik Höglund wrote: > On Monday 18 May 2015, Ian Romanick wrote: >> From: Ian Romanick >> >> This reverts commit 03420eac0c53280beae5f72783e52950fd1e3fba. > > Did you mean to revert this commit? I did, but that may have been in error. I saw that it depended on gl_exte

[Mesa-dev] [PATCH 14.2/15] glapi: Make GL_ARB_direct_state_access functions exclusive to core profile

2015-05-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: Dave Airlie Cc: Ilia Mirkin Cc: Dylan Baker Cc: "10.6" --- src/mapi/glapi/gen/apiexec.py | 100 ++ 1 file changed, 100 insertions(+) diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/ap

[Mesa-dev] [PATCH 14.1/15] glapi: Store exec table version info outside the XML

2015-05-19 Thread Ian Romanick
From: Ian Romanick Currently on the functions that are exclusive to core-profile are implemented. The remainder continue to live in the XML. Additional functions can be moved later. The functions for GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect are put in the dispatch table inside the V

[Mesa-dev] [PATCH] dri: Add a way to query the driver for supported context flags

2015-05-19 Thread Adam Jackson
xserver would like not to expose (say) ARB_robustness_isolation if the driver doesn't actually support it, as it's pretty cruel to claim a feature works but always throw BadFBConfig if you try to use it. Add a hook to the dri2 and swrast extensions to query the supported context flags, initialize

[Mesa-dev] [Bug 89018] Civilization: Beyond Earth terrain section not rendered

2015-05-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89018 Florian Scandella changed: What|Removed |Added CC||f...@chilicode.com -- You are recei

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-19 Thread Jason Ekstrand
On Tue, May 19, 2015 at 9:25 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Tue, May 19, 2015 at 5:42 AM, Francisco Jerez >> wrote: >>> Jason Ekstrand writes: >>> On Mon, May 18, 2015 at 10:34 AM, Francisco Jerez wrote: >[...] > I've given this idea a shot. Ca

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-19 Thread Francisco Jerez
Jason Ekstrand writes: > On Tue, May 19, 2015 at 5:42 AM, Francisco Jerez > wrote: >> Jason Ekstrand writes: >> >>> On Mon, May 18, 2015 at 10:34 AM, Francisco Jerez >>> wrote: [...] I've given this idea a shot. Can you have a look at the image-load-store-lower branch of my tr

Re: [Mesa-dev] [PATCH 13/15] Revert "mesa: Make GL_TEXTURE_CUBE_MAP valid in FramebufferTextureLayer"

2015-05-19 Thread Fredrik Höglund
On Monday 18 May 2015, Ian Romanick wrote: > From: Ian Romanick > > This reverts commit 03420eac0c53280beae5f72783e52950fd1e3fba. Did you mean to revert this commit? > Cc: "10.6" > --- > src/mesa/main/fbobject.c | 36 +--- > 1 file changed, 5 insertions(+), 31

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-19 Thread Jason Ekstrand
On Tue, May 19, 2015 at 5:42 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Mon, May 18, 2015 at 10:34 AM, Francisco Jerez >> wrote: >>>[...] >>> I've given this idea a shot. Can you have a look at the >>> image-load-store-lower branch of my tree [1]? It's just a quick and >>> di

Re: [Mesa-dev] [PATCH 00/15] Make ARB_direct_state_access exclusive to core profile

2015-05-19 Thread Ian Romanick
On 05/18/2015 06:36 PM, Dave Airlie wrote: > On 19 May 2015 at 11:02, Ian Romanick wrote: >> On 05/18/2015 05:35 PM, Ian Romanick wrote: >>> On 05/18/2015 02:34 PM, Dave Airlie wrote: On 19 May 2015 at 07:28, Ian Romanick wrote: > With the patches already on the piglit list, the only cha

Re: [Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

2015-05-19 Thread Roland Scheidegger
On 05/19/2015 04:46 PM, Adam Jackson wrote: On Tue, 2015-05-12 at 23:34 +0200, Roland Scheidegger wrote: I like faster! I don't really understand though where the wins come from. softpipe can't have much pending work in the first place (maybe tile cache?), llvmpipe potentially has the rasterize

Re: [Mesa-dev] [PATCH 6/9] glx: Implement ARB_context_flush_control in drisw too

2015-05-19 Thread Adam Jackson
On Tue, 2015-05-12 at 11:54 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson This one is still unreviewed, if anyone's interested. It's almost certainly too late to land this series in 10.6, but 10.7 would be nice. - ajax > --- > src/glx/drisw_glx.c | 13 +++-- > 1 file change

Re: [Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

2015-05-19 Thread Adam Jackson
On Tue, 2015-05-12 at 23:34 +0200, Roland Scheidegger wrote: > I like faster! > > I don't really understand though where the wins come from. > softpipe can't have much pending work in the first place (maybe tile > cache?), llvmpipe potentially has the rasterizer threads I guess but > I'm not quit

Re: [Mesa-dev] [PATCH 12/20] glapi: Remove static dispatch for functions that didn't exist in NVIDIA

2015-05-19 Thread Adam Jackson
On Wed, 2015-05-13 at 12:44 -0700, Ian Romanick wrote: > From: Ian Romanick > > Comparing the output of > > nm -D libGL.so.349.16 | grep ' T gl[^X]' | sed 's/.* T //' > > between Catalyst NVIDIA 349.16 and this commit, the only change is a > bunch > of functions that NVIDIA exports that Me

Re: [Mesa-dev] [PATCH 1/2] glsl: Allow dynamic sampler array indexing with GLSL ES < 3.00

2015-05-19 Thread Francisco Jerez
Tapani Pälli writes: > Dynamic indexing of sampler arrays is prohibited by GLSL ES 3.00. > Earlier versions allow 'constant-index-expression' indexing, where > index can contain a loop induction variable. > > Patch allows dynamic indexing for sampler arrays when GLSL ES < 3.00. > This change make

[Mesa-dev] [PATCH] glsl: report builtin variables in getActiveVariables()

2015-05-19 Thread Martin Peres
It seems like there were restrictions on builtin variables introduced in 2011 (07731ed1692eb5d72110b3c5b693f37e581e3809) that never got lifted when proper support got added. At least, getting rid of them do not introduce any regression while fixing the following piglit tests: - glsl-getactiveunifo

[Mesa-dev] Mesa 10.6.0 release candidate 1

2015-05-19 Thread Emil Velikov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This is the first RC for Mesa 10.6.0. Minus the minor delay the schedule remains unchanged: May 22st 2015 - Release candidate 2 May 29th 2015 - Release candidate 3 June 5th 2015 - Release candidate 4/Mesa 10.6.0 As a reminder

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-19 Thread Francisco Jerez
Jason Ekstrand writes: > On Mon, May 18, 2015 at 10:34 AM, Francisco Jerez > wrote: >>[...] >> I've given this idea a shot. Can you have a look at the >> image-load-store-lower branch of my tree [1]? It's just a quick and >> dirty proof of concept, so don't bother to review it carefully, just

[Mesa-dev] [PATCH 0/2] sampler array indexing fixes

2015-05-19 Thread Tapani Pälli
Hello; Here are 2 changes, first one relaxes sampler array index validation during AST->HIR time for GLSL ES versions < 300. Second patch makes sure that during compilation/linking, index expression has been turned in to constant. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=84225 whic

[Mesa-dev] [PATCH 2/2] glsl: validate sampler array indexing for 'constant-index-expression'

2015-05-19 Thread Tapani Pälli
Desktop GLSL < 130 and GLSL ES < 300 allow sampler array indexing where index can contain a loop induction variable. This extra check makes sure that all these indexes turn in to constant expressions during compilation/linking. Signed-off-by: Tapani Pälli Cc: "10.5" and "10.6" --- src/glsl/link

[Mesa-dev] [PATCH 1/2] glsl: Allow dynamic sampler array indexing with GLSL ES < 3.00

2015-05-19 Thread Tapani Pälli
Dynamic indexing of sampler arrays is prohibited by GLSL ES 3.00. Earlier versions allow 'constant-index-expression' indexing, where index can contain a loop induction variable. Patch allows dynamic indexing for sampler arrays when GLSL ES < 3.00. This change makes 'sampler-array-index.frag' parse

Re: [Mesa-dev] [PATCH] Fix symbol 'x86_64_entry_start' is alreadydefined when building with LLVM/clang

2015-05-19 Thread Marc Dietrich
Am Montag, 18. Mai 2015, 13:35:48 schrieb Tomasz Gajc: > Hello, > my patch is based on that LLVM bug. Mesa with that patch was tested only > with clang by me, and I haven't found any issues when running my system > with mesa with that patch applied. we had this discussion in the past already, see

[Mesa-dev] [Bug 26411] Mesa classic-only: Missing textures in Funguloids

2015-05-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=26411 Tapani Pälli changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Mesa-dev] [Bug 90310] Fails to build gallium_dri.so at linking stage with clang because of multiple redefinitions

2015-05-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90310 Julien Isorce changed: What|Removed |Added CC||bri...@vmware.com -- You are receiving

[Mesa-dev] [Bug 90310] Fails to build gallium_dri.so at linking stage with clang because of multiple redefinitions

2015-05-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90310 --- Comment #1 from Julien Isorce --- Created attachment 115891 --> https://bugs.freedesktop.org/attachment.cgi?id=115891&action=edit gallium/dri: fix duplicated symbols build error -- You are receiving this mail because: You are the QA Conta

[Mesa-dev] [PATCH 2/2] clover: try userptr for CL_MEM_USE_HOST_PTR

2015-05-19 Thread Grigori Goronzy
According to spec, CL_MEM_USE_HOST_PTR should directly use host memory, if possible. This is just what userptr is for, so use it. In case the memory cannot be mapped, a fallback similar to CL_MEM_COPY_HOST_PTR is used. --- src/gallium/state_trackers/clover/core/memory.cpp | 2 +- src/gallium/s

[Mesa-dev] [PATCH 1/2] clover: implement CL_MEM_ALLOC_HOST_PTR

2015-05-19 Thread Grigori Goronzy
This flag is typically used to request pinned host memory, to avoid any copies between GPU and CPU. This improves throughput with an older OpenCL app which I unfortunately can't publish due to its licensing. --- src/gallium/state_trackers/clover/core/resource.cpp | 4 1 file changed, 4 inser