Hello; Here are 2 changes, first one relaxes sampler array index validation during AST->HIR time for GLSL ES versions < 300. Second patch makes sure that during compilation/linking, index expression has been turned in to constant.
This fixes https://bugs.freedesktop.org/show_bug.cgi?id=84225 which currently happens with three different WebGL cases. No Piglit regressions observed, following 2 tests explicitly test this: glsl-es-1.00/compiler/structure-and-array-operations/sampler-array-index.frag glsl-es-1.00/linker/glsl-sampler-array-dynamic-index.shader_test (just sent) Tapani Pälli (2): glsl: Allow dynamic sampler array indexing with GLSL ES < 3.00 glsl: validate sampler array indexing for 'constant-index-expression' src/glsl/ast_array_index.cpp | 37 ++++++++++++----------- src/glsl/linker.cpp | 71 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 90 insertions(+), 18 deletions(-) -- 2.1.0 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
