Re: [patch] Solving selection painting bugs

2008-09-12 Thread Vincent van Ravesteijn
Vincent van Ravesteijn - TNW wrote: First, when only selecting the end_margin between 'after i-1' and 'before i', the anchor is incorrectly set to be equal to the cur. This is because comparing two CursorSlices does not take into account the boundary property (because the CursorSlice does not kn

Re: [patch] Solving selection painting bugs

2008-09-12 Thread Vincent van Ravesteijn
Abdel, I took the liberty to change the drawParagraph function in TextMetrics.cpp a bit. This because, after you asked me to use meaningfull names for the variables, I tried to understand the other names in the function and I didn't succeed. I felt that variables shouldn't change their role d

Bug in CS 26372

2008-09-12 Thread Vincent van Ravesteijn - TNW
In the following piece of code, the tmpInset was deleted if insetAllowed was false. After the change, tmpInset is deleted when insetAllowed is true. - if (!toPar.insetAllowed(tmpInset->lyxCode())) { + Inset * inset = toPar.inInset(); + if (inset && inset->insetAllowed(tmpInset->lyxCode()

Re: [blocker] toolbars are no longer displayed

2008-09-12 Thread Uwe Stöhr
> is that repaired when you unset > tools->preferences->Allow saving/restoring of windows geometry > save & restart lyx. Yes. But this option has always been by default turned on. And until Monday evening, this workaround wasn't needed. It cannot be that users first have to modify the preference

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Pavel Sanda
Uwe Stöhr wrote: >> current argumets i see: >> pros: >> - CTRL+B for \boldsymbol is more logically consistent > works also for Greek characters. yes, i forgot on this. >> cons: >> - more people want CTRL+B for bold + upright though > > I don't see this. There is currently only one but several oth

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Uwe Stöhr
Pavel Sanda schrieb: but the last discussions in this thread are not whether \mathbf or \boldsymbol is correct, but that we have two LFUNs one for \mathbf and second for \boldsymbol and two bindings CTRL+B and CTRL+ALT+B. But that's what I was talking about. \boldymbol is the correct one and

Re: [blocker] toolbars are no longer displayed

2008-09-12 Thread Pavel Sanda
Uwe Stöhr wrote: > I just made an SVN update and compiled LyX 1.6. But in contrary to Monday > evening, no toolbar is shown. I can set up in the UI-files and the View > menu settings what I want, but they won't be shown. isn't this http://bugzilla.lyx.org/show_bug.cgi?id=5101#c2 striking again?

[blocker] toolbars are no longer displayed

2008-09-12 Thread Uwe Stöhr
I just made an SVN update and compiled LyX 1.6. But in contrary to Monday evening, no toolbar is shown. I can set up in the UI-files and the View menu settings what I want, but they won't be shown. -> a release blocker regards Uwe

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Pavel Sanda
Uwe Stöhr wrote: > Pavel Sanda schrieb: > >> please could you bring some link to that discussion? somehow i fail to see >> arguments why is the current state improvement. > > See my last post in this topic: > > \mathbf: - changes characters to bold AND upright (this is not correct) > - doe

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Enrico Forestieri
On Fri, Sep 12, 2008 at 07:24:36PM -0400, rgheck wrote: > Enrico Forestieri wrote: > > On Fri, Sep 12, 2008 at 11:29:08PM +0200, Pavel Sanda wrote: > > > > > >> Enrico Forestieri wrote: > >> > >>> I am not really sure that that is the best option. Maybe the two > >>> attached patches make

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread rgheck
Enrico Forestieri wrote: On Fri, Sep 12, 2008 at 11:29:08PM +0200, Pavel Sanda wrote: Enrico Forestieri wrote: I am not really sure that that is the best option. Maybe the two attached patches make everybody happy. The first one restores the toggle behavior on \boldsymbol (Ctrl-B), and

Re: [Cvslog] r26377 - in /lyx-devel/trunk/lib/doc: Makefile.am biblio/...

2008-09-12 Thread Pavel Sanda
[EMAIL PROTECTED] wrote: > Author: uwestoehr > Date: Sat Sep 13 00:51:18 2008 > New Revision: 26377 > Modified: lyx-devel/trunk/lib/doc/Makefile.am > URL: > http://www.lyx.org/trac/file/lyx-devel/trunk/lib/doc/Makefile.am?rev=26377 >

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Uwe Stöhr
Pavel Sanda schrieb: please could you bring some link to that discussion? somehow i fail to see arguments why is the current state improvement. See my last post in this topic: \mathbf: - changes characters to bold AND upright (this is not correct) - doesn't work for Greek characters

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Pavel Sanda
Uwe Stöhr wrote: >>> Note that the math toolbar also provides \mathbf, so its your decision >>> what to use. >> have you tried it? currently i don't see howto cause toggle-like behaviour >> through math-insert \mathbf. ideas? > > This never worked. This should be fixed but is a different issue. >

Re: Missing package in (European) Lyx Standard Installation

2008-09-12 Thread Uwe Stöhr
sms schrieb: Subject: Lyx installers for Windows (ftp://ftp.lyx.org/pub/lyx/bin/1.5.6/LyX-1.5.6-1-Installer.exe) (ftp://ftp.lyx.org/pub/lyx/bin/1.5.6/LyX-1.5.6-1-Installer-Bundle.exe) I noticed that after installation of German version, at the first start of Lyx (when the Documentation documen

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Uwe Stöhr
Pavel Sanda schrieb: Note that the math toolbar also provides \mathbf, so its your decision what to use. have you tried it? currently i don't see howto cause toggle-like behaviour through math-insert \mathbf. ideas? This never worked. This should be fixed but is a different issue. imho two

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Enrico Forestieri
On Fri, Sep 12, 2008 at 11:29:08PM +0200, Pavel Sanda wrote: > Enrico Forestieri wrote: > > I am not really sure that that is the best option. Maybe the two > > attached patches make everybody happy. The first one restores the > > toggle behavior on \boldsymbol (Ctrl-B), and the second one on > >

Re: [Cvslog] r26373 - /lyx-devel/trunk/src/insets/InsetSpace.cpp

2008-09-12 Thread Enrico Forestieri
On Fri, Sep 12, 2008 at 04:54:57PM +0200, Jean-Marc Lasgouttes wrote: > [EMAIL PROTECTED] writes: > > > Author: lasgouttes > > Date: Fri Sep 12 16:38:03 2008 > > New Revision: 26373 > > > > URL: http://www.lyx.org/trac/changeset/26373 > > Log: > > Length::inBP returns big postscript points, not p

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Pavel Sanda
Enrico Forestieri wrote: > I am not really sure that that is the best option. Maybe the two > attached patches make everybody happy. The first one restores the > toggle behavior on \boldsymbol (Ctrl-B), and the second one on > \mathbf (Ctrl-Alt-B). you are probably right. my last question is why \

Re: Bold key binding is not right in Lyx 1.6.0rc2

2008-09-12 Thread Enrico Forestieri
On Fri, Sep 12, 2008 at 04:14:24AM +0200, Pavel Sanda wrote: > Richard Heck wrote: > > Enrico Forestieri wrote: > >> Another option would be the following. When the user enters > >> \mathbf{x\alpha y}, we could output the following latex code: > >> \mathbf{x\boldsymbol{\alpha}y}. > >> > >> > >

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Pavel Sanda
Vincent van Ravesteijn - TNW wrote: > > The outline pane is obviously more than an outliner in 1.6. > > I am annoyed by the fact that I have to first open a document > > before I can open the pane. I propose to move the menu item > > from 'Document->Outline' to 'Tools->Navigator'. This of course >

Re: [Cvslog] r26359 - /lyx-devel/trunk/src/frontends/qt4/GuiView.cpp

2008-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2008 at 02:03:01AM -, [EMAIL PROTECTED] wrote: > Author: sanda > Date: Fri Sep 12 04:02:56 2008 > New Revision: 26359 > > URL: http://www.lyx.org/trac/changeset/26359 > Log: > Try to fix the rest of bug http://bugzilla.lyx.org/show_bug.cgi?id=5082 . > (Initialize dialogs after

Re: LDM 2008

2008-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2008 at 06:16:10PM +0200, Christian Ridderström wrote: > On Fri, 12 Sep 2008, Jean-Marc Lasgouttes wrote: > >> Andre Poenitz <[EMAIL PROTECTED]> writes: >>> So unless someone comes up with a really convincing argument to the >>> contrary I'll call 15.11. "final". Bad luck for Ed,

Re: LDM 2008

2008-09-12 Thread Christian Ridderström
On Fri, 12 Sep 2008, Jean-Marc Lasgouttes wrote: Andre Poenitz <[EMAIL PROTECTED]> writes: So unless someone comes up with a really convincing argument to the contrary I'll call 15.11. "final". Bad luck for Ed, but apart from that it does not look too bad. I hope that Abdel and Lgb can reach a

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Pavel Sanda
Konrad Hofbauer wrote: > Jürgen Spitzmüller wrote: > We previously concluded that we do (not really) want platform-dependent > menus (although the biggest counter-argument (documentation) is gone now > with the Info-inset). another argument is that people use lyx on different archs simultaneousl

Re: r26369 - /lyx-devel/trunk/src/Text2.cpp

2008-09-12 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: Agreed. Could the paste code be the culprit? Found it: breakParagraphConservative(): don't forget to set the inset owner. This is the real fix for bughttp://bugzilla.lyx.org/show_bug.cgi?id=5099

Re: r26369 - /lyx-devel/trunk/src/Text2.cpp

2008-09-12 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Agreed. Could the paste code be the culprit? >> > > Found it: > breakParagraphConservative(): don't forget to set the inset owner. This is > the real fix for bughttp://bugzilla.lyx.org/show_bug.cgi?id=5099 Great. It might even be my fault...

Re: r26369 - /lyx-devel/trunk/src/Text2.cpp

2008-09-12 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: I think there's something fishy in there. I don't like at all this inset owner concept but I guess we should never be in a case where this is not initialized, should we? Agreed. Could the paste code be the culp

Re: [Cvslog] r26373 - /lyx-devel/trunk/src/insets/InsetSpace.cpp

2008-09-12 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] writes: > Author: lasgouttes > Date: Fri Sep 12 16:38:03 2008 > New Revision: 26373 > > URL: http://www.lyx.org/trac/changeset/26373 > Log: > Length::inBP returns big postscript points, not pixel width This should be done to InsetMathGrid::skipPixels too, but I do not know how t

Re: InsetSpace Too Narrow With Ems

2008-09-12 Thread Jean-Marc Lasgouttes
rgheck <[EMAIL PROTECTED]> writes: > Create a 3em custom InsetSpace. It gets drawn way too narrow. Fixed at r26373: Author: lasgouttes Date: Fri Sep 12 16:38:03 2008 New Revision: 26373 URL: http://www.lyx.org/trac/changeset/26373 Log: Length::inBP returns big postscript points, not pixel width

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: So we are stuck up until someone is willing to read as many HIG and good quality mainstream programs as possible? Well at least John did this before proposing the current structure. I'm opposed as well to "I like it like that" change

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Abdelrazak Younes
Konrad Hofbauer wrote: Abdelrazak Younes wrote: So we are stuck up until someone is willing to read as many HIG and good quality mainstream programs as possible? Please not! Better a small fix than no fix. It IMHO can't get worse than it is now. think we should not change the menus after 1

Re: Help needed on small table movement bug

2008-09-12 Thread Jean-Marc Lasgouttes
Pavel Sanda <[EMAIL PROTECTED]> writes: >> needsUpdate returns true when the status of the selection has changed >> (turned on or turned off). > > you meant selHandle? Indeed. JMarc

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Konrad Hofbauer
Abdelrazak Younes wrote: So we are stuck up until someone is willing to read as many HIG and good quality mainstream programs as possible? Please not! Better a small fix than no fix. It IMHO can't get worse than it is now. think we should not change the menus after 1.6.0 is released (until

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Konrad Hofbauer
Jean-Marc Lasgouttes wrote: (and our menus are already difficult to use IMO). +1 /Konrad

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: What I'm going to say may go against a well established consensus, but I feel that the "Outliner" should be next to "View Source" and I'd like them most to be in the View menu. Incidentally that's also my opin

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Konrad Hofbauer
Vincent van Ravesteijn - TNW wrote: (I also think that all the file-format thingies in the View menu should be in a File->View menu next to File->Export). +1 /Konrad

Missing package in (European) Lyx Standard Installation

2008-09-12 Thread sms
Subject: Lyx installers for Windows (ftp://ftp.lyx.org/pub/lyx/bin/1.5.6/LyX-1.5.6-1-Installer.exe) (ftp://ftp.lyx.org/pub/lyx/bin/1.5.6/LyX-1.5.6-1-Installer-Bundle.exe) --- Dear Lyx team, I noticed that after installation of German version, at the first start of Lyx (when the Documentation d

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> What I'm going to say may go against a well established consensus, but I >> feel that the "Outliner" should be next to "View Source" and I'd like >> them most to be in the View menu. > > Incidentally that's also my opinion but last I suggested that,

Re: LDM 2008

2008-09-12 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > So unless someone comes up with a really convincing argument to the > contrary I'll call 15.11. "final". Bad luck for Ed, but apart from that > it does not look too bad. I hope that Abdel and Lgb can reach a 3+ ;-} I booked a flight. I'll arrive on Thurs

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: (I also think that all the file-format thingies in the View menu should be in a File->View menu next to File->Export). Oh and I think I agree with that too. Abdel.

Re: [Cvslog] r26369 - /lyx-devel/trunk/src/Text2.cpp

2008-09-12 Thread Jean-Marc . Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > He he, I guess we hit the reply button at the same time :-) Yes, and I was in the process of pointing to labelFont in bugzilla %-| JMarc

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: The outline pane is obviously more than an outliner in 1.6. I am annoyed by the fact that I have to first open a document before I can open the pane. I propose to move the menu item from 'Document->Outline' to 'Tools->Navigator'. This of course means that the p

Re: r26369 - /lyx-devel/trunk/src/Text2.cpp

2008-09-12 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: I think there's something fishy in there. I don't like at all this inset owner concept but I guess we should never be in a case where this is not initialized, should we? Agreed. Could the paste code be the culp

RE: Move the outliner from Document to Tools?

2008-09-12 Thread Vincent van Ravesteijn - TNW
> The outline pane is obviously more than an outliner in 1.6. > I am annoyed by the fact that I have to first open a document > before I can open the pane. I propose to move the menu item > from 'Document->Outline' to 'Tools->Navigator'. This of course > means that the pane could be opened even if

Re: [Cvslog] r26369 - /lyx-devel/trunk/src/Text2.cpp

2008-09-12 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: [EMAIL PROTECTED] writes: Author: younes Date: Fri Sep 12 14:55:35 2008 New Revision: 26369 URL: http://www.lyx.org/trac/changeset/26369 Log: Test Paragraph::inInset() before using it. Fixes bug http://bugzilla.lyx.org/show_bug.cgi?id=5099 But how come

Re: r26369 - /lyx-devel/trunk/src/Text2.cpp

2008-09-12 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > I think there's something fishy in there. I don't like at all this > inset owner concept but I guess we should never be in a case where > this is not initialized, should we? Agreed. Could the paste code be the culprit? JMarc

Re: r26369 - /lyx-devel/trunk/src/Text2.cpp

2008-09-12 Thread Abdelrazak Younes
[EMAIL PROTECTED] wrote: Author: younes Date: Fri Sep 12 14:55:35 2008 New Revision: 26369 URL: http://www.lyx.org/trac/changeset/26369 Log: Test Paragraph::inInset() before using it. Fixes bug http://bugzilla.lyx.org/show_bug.cgi?id=5099 I think there's something fishy in there. I don't like

Re: [Cvslog] r26369 - /lyx-devel/trunk/src/Text2.cpp

2008-09-12 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] writes: > Author: younes > Date: Fri Sep 12 14:55:35 2008 > New Revision: 26369 > > URL: http://www.lyx.org/trac/changeset/26369 > Log: > Test Paragraph::inInset() before using it. Fixes bug > http://bugzilla.lyx.org/show_bug.cgi?id=5099 But how come inInset can be null? JMarc

Re: Move the outliner from Document to Tools?

2008-09-12 Thread Konrad Hofbauer
Abdelrazak Younes wrote: Hello there, The outline pane is obviously more than an outliner in 1.6. I am annoyed by the fact that I have to first open a document before I can open the pane. I propose to move the menu item from 'Document->Outline' to 'Tools->Navigator'. This of course means that

Move the outliner from Document to Tools?

2008-09-12 Thread Abdelrazak Younes
Hello there, The outline pane is obviously more than an outliner in 1.6. I am annoyed by the fact that I have to first open a document before I can open the pane. I propose to move the menu item from 'Document->Outline' to 'Tools->Navigator'. This of course means that the pane could be opened

Re: [FIXED] Strange 8s delay when resizing the window

2008-09-12 Thread rgheck
Pavel Sanda wrote: Helge Hafting wrote: I've fixed at least part of this at r26356. A pair of uninitialized variables was causing the size of the TOC slider to be set to huge values in certain cases. I just checked out from svn, and can no longer reproduce the problem. LyX is snappy

Re: 1.6svn: Strange 8s delay when resizing the window, blame theoutliner

2008-09-12 Thread rgheck
Pavel Sanda wrote: Richard Heck wrote: (Note, by the way, that the depth is still set to 3, although there is nothing in the TOC. This is itself a problem.) hopefully fixed in http://www.lyx.org/trac/changeset/26360 I think we both fixed that one, in different ways. So it's defini

Re: [Cvslog] r26367 - /lyx-devel/trunk/src/Cursor.h

2008-09-12 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: [EMAIL PROTECTED] writes: Author: sanda Date: Fri Sep 12 12:42:23 2008 New Revision: 26367 URL: http://www.lyx.org/trac/changeset/26367 Log: Let doxygen document this. Ah, this is what the leading * are good for... Thanks. Incidentally, the preferr

Re: [Cvslog] r26367 - /lyx-devel/trunk/src/Cursor.h

2008-09-12 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] writes: > Author: sanda > Date: Fri Sep 12 12:42:23 2008 > New Revision: 26367 > > URL: http://www.lyx.org/trac/changeset/26367 > Log: > Let doxygen document this. Ah, this is what the leading * are good for... Thanks. It would be nice to have a short doxygen howto documenting

Re: [FIXED] Strange 8s delay when resizing the window

2008-09-12 Thread Pavel Sanda
Helge Hafting wrote: >> I've fixed at least part of this at r26356. A pair of uninitialized >> variables was causing the size of the TOC slider to be set to huge values >> in certain cases. > I just checked out from svn, and can no longer reproduce the problem. > LyX is snappy with the outliner v

Re: [FIXED] Strange 8s delay when resizing the window

2008-09-12 Thread Helge Hafting
rgheck wrote: I've fixed at least part of this at r26356. A pair of uninitialized variables was causing the size of the TOC slider to be set to huge values in certain cases. I just checked out from svn, and can no longer reproduce the problem. LyX is snappy with the outliner visible - great!