Re: lines in tables again

2006-06-23 Thread Abdelrazak Younes
Peter Kümmel wrote: I found a bug in the Qt4 version: 1. start lyx 2. new document 3. insert new table 4. mark whole table 5. right mouse click -> crash Confirmed for qt3: Assertion triggered in CursorSlice LCursor::anchor() const by failing check "anc hor_.depth() >= depth()" in file D:\de

Re: lines in tables again

2006-06-23 Thread Abdelrazak Younes
Peter Kümmel wrote: I found a bug in the Qt4 version: 1. start lyx 2. new document 3. insert new table 4. mark whole table 5. right mouse click -> crash Confirmed.

Re: lines in tables again

2006-06-23 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Juergen Spitzmueller wrote: Peter Kümmel wrote: It seems this could be done by a lyx newbie like me. You're clearly not a newbie, but it could even be done by a newbie. Adding a RC_TABLE_LINES to LyXRC and then using lyxrc.read(RC_TABLE_LINES) in

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> Lars Gullik Bjønnes wrote: I have no idea why you think having just one frontend is some kind of silver bullet. Peter> Ever heard about "lowest common denominator"? When you use more Peter> front ends you

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Abdelrazak Younes
Jose' Matos wrote: On Friday 23 June 2006 17:43, Andre Poenitz wrote: No. But xforms could be removed right away. Is there any reason for it to here? What is the reason for not removing it now? As a compromise I propose to mark it in the same level as gtk, people don't try to break it

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Jose' Matos
On Friday 23 June 2006 17:43, Andre Poenitz wrote: > No. But xforms could be removed right away. Is there any reason for it to here? What is the reason for not removing it now? As a compromise I propose to mark it in the same level as gtk, people don't try to break it on purpose, keep it w

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Enrico Forestieri
On Fri, Jun 23, 2006 at 06:33:03PM +0200, Peter Kümmel wrote: > Lars Gullik Bjønnes wrote: > > Peter Kümmel <[EMAIL PROTECTED]> writes: > > > > | Juergen Spitzmueller wrote: > > | > Jean-Marc Lasgouttes wrote: > > | >> 1.6: qt4, gtk and maybe qt3. > > | > > > | > And qt5. > > | > > | And the ol

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: > > Peter> Lars Gullik Bjønnes wrote: >>> I have no idea why you think having just one frontend is some kind >>> of silver bullet. > > Peter> Ever heard about "lowest common denominator"? When you use more > Pe

Re: tex2lyx produces a file upon which lyx crashes

2006-06-23 Thread Enrico Forestieri
On Fri, Jun 23, 2006 at 12:32:59AM +0200, Enrico Forestieri wrote: > On Thu, Jun 22, 2006 at 08:39:37PM +0200, Enrico Forestieri wrote: > > > When trying to import xxx.tex (attached) lyx (both 1.4 and 1.5) crashes. > > The file xxx.lyx (attached, too) is produced, so it is lyx that is > > crashin

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Andre Poenitz
On Thu, Jun 22, 2006 at 02:39:21PM -0500, Bo Peng wrote: > >We have abondoned Coding_Rules(?) a long time ago and used 'do whatever > >the majority in src/* does' > > Because it is easier to change the rules than change source code. BTW, > the style I like is: > > class ThisClass > { > int thisF

Re: lines in tables again

2006-06-23 Thread Andre Poenitz
On Fri, Jun 23, 2006 at 02:58:03PM +0200, Lars Gullik Bjønnes wrote: > Edwin Leuven <[EMAIL PROTECTED]> writes: > > | Jose' Matos wrote: > | > On Friday 23 June 2006 13:30, Jose' Matos wrote: > | >> Surprisingly (at least to me) there was a so clear cut between those two > | >> options. > | > t

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Andre Poenitz
On Fri, Jun 23, 2006 at 08:44:21AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | We have abondoned Coding_Rules(?) a long time ago and used 'do whatever > | the majority in src/* does' > > No. Have a look at the archives. Andre'

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Andre Poenitz
On Fri, Jun 23, 2006 at 11:06:20AM +0200, Lars Gullik Bjønnes wrote: > | I always have to force myself to put it to the right. > > When you get used to it, it feels a lot more natural. I think you agree that I have written enough code with 'const' on the right and still like it more on the left.

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Andre Poenitz
On Fri, Jun 23, 2006 at 12:00:11PM +0200, Peter Kümmel wrote: > This is the responsibility of the system window manager. If this > functionality was drawn into Qt it would restrict the freedom with > which differing windowing/layout approaches are applied. > > This would be easy to implement, but

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Andre Poenitz
On Fri, Jun 23, 2006 at 01:37:19PM +0200, Lars Gullik Bjønnes wrote: > No. I am saying that we should change the code rules when we see a > need. That might be allowing "this_is_a_variable", but that has not > really ben discussed yet. We could do that. A head count in src suggests a small majorit

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Andre Poenitz
On Fri, Jun 23, 2006 at 02:09:38PM +0200, Lars Gullik Bjønnes wrote: > Well... my point is that we cannot delete frontends just because it is > easier to work with just one. Guess what you do with apple trees. > Do you really belive LyX is a driver for distros to use Qt4? No. But xforms could be

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Andre Poenitz
On Fri, Jun 23, 2006 at 09:44:38AM +0200, Abdelrazak Younes wrote: > Lars Gullik Bjønnes wrote: > >Andre Poenitz <[EMAIL PROTECTED]> writes: > > > >| We have abondoned Coding_Rules(?) a long time ago and used 'do whatever > >| the majority in src/* does' > > > >No. > > Is that an answer to a quest

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Jean-Marc Lasgouttes
> "Peter" == Peter Kümmel <[EMAIL PROTECTED]> writes: Peter> Lars Gullik Bjønnes wrote: >> I have no idea why you think having just one frontend is some kind >> of silver bullet. Peter> Ever heard about "lowest common denominator"? When you use more Peter> front ends you could only support th

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Juergen Spitzmueller wrote: > | > Jean-Marc Lasgouttes wrote: > | >> 1.6: qt4, gtk and maybe qt3. > | > > | > And qt5. > | > | And the old story goes on: lyx supports too much frontends. > > I have no idea why you think

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Juergen Spitzmueller wrote: > | > Jean-Marc Lasgouttes wrote: > | >> 1.6: qt4, gtk and maybe qt3. > | > > | > And qt5. > | > | And the old story goes on: lyx supports too much frontends. > > I have no idea why you think

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Juergen Spitzmueller wrote: | > Jean-Marc Lasgouttes wrote: | >> 1.6: qt4, gtk and maybe qt3. | > | > And qt5. | | And the old story goes on: lyx supports too much frontends. I have no idea why you think having just one frontend is some kind of silver

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Peter Kümmel
Jean-Marc Lasgouttes wrote: >> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: > > Juergen> Jean-Marc Lasgouttes wrote: >>> 1.6: qt4, gtk and maybe qt3. > > Juergen> And qt5. > > It depends how slow we manage to be. It's always so slow because no clear cut is made.

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Peter Kümmel
Juergen Spitzmueller wrote: > Jean-Marc Lasgouttes wrote: >> 1.6: qt4, gtk and maybe qt3. > > And qt5. And the old story goes on: lyx supports too much frontends.

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> The longer term vision is that xforms and qt3 goes away, but | Lars> that qt4 and gtk stays. | | Agreed (provided that we do have people who are dedicated to gtk). Of cou

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Jean-Marc Lasgouttes wrote: >> 1.6: qt4, gtk and maybe qt3. Juergen> And qt5. It depends how slow we manage to be. JMarc

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > 1.6: qt4, gtk and maybe qt3. And qt5. SCNR, Jürgen

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> The longer term vision is that xforms and qt3 goes away, but Lars> that qt4 and gtk stays. Jean-Marc> Agreed (provided that we do have people who are dedicat

Re: [patch] fix bug 2655

2006-06-23 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> This patch fixes bug 2655 (off by one error). It goes in trunk Georg> right now. Jean-Marc, also OK for 1.4.2? Yes, definitely. JMarc

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> The longer term vision is that xforms and qt3 goes away, but Lars> that qt4 and gtk stays. Agreed (provided that we do have people who are dedicated to gtk). JMarc

Re: lines in tables again

2006-06-23 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > Probably both. I mean: a bug and a misnaming. It's not limited to Qt4, though. Jürgen

Re: lines in tables again

2006-06-23 Thread Juergen Spitzmueller
Also sprach Peter Kümmel: > I don't see this options here. Maybe because of my latex installation? It's not yet implemented. But there is a booktabs branch. And I think we should set up the proper interface for those enhancements now. Else, we have to change it again. > A other point: in the ta

Re: lines in tables again

2006-06-23 Thread Peter Kümmel
Juergen Spitzmueller wrote: > Peter Kümmel wrote: >> I also think a overall default behavior must not be changed in a dialog >> for one special table. But the Table dialog really misses on option to >> remove/add ALL lines, which then also applies to added columns and rows. > > Please do not think

Re: lines in tables again

2006-06-23 Thread Juergen Spitzmueller
Peter Kümmel wrote: > I also think a overall default behavior must not be changed in a dialog > for one special table. But the Table dialog really misses on option to > remove/add ALL lines, which then also applies to added columns and rows. Please do not think "borders/no borders" only. Think of

Re: lines in tables again

2006-06-23 Thread Peter Kümmel
I found a bug in the Qt4 version: 1. start lyx 2. new document 3. insert new table 4. mark whole table 5. right mouse click -> crash

Re: lines in tables again

2006-06-23 Thread Juergen Spitzmueller
Juergen Spitzmueller wrote: > I was talking about the tabular *create* dialog. But I see now this is still there. Jürgen

Re: lines in tables again

2006-06-23 Thread Peter Kümmel
Abdelrazak Younes wrote: > Juergen Spitzmueller wrote: >> Peter Kümmel wrote: >>> It seems this could be done by a lyx newbie like me. >> >> You're clearly not a newbie, but it could even be done by a newbie. >> >>> Adding a RC_TABLE_LINES to LyXRC and then using >>> lyxrc.read(RC_TABLE_LINES) in t

Re: lines in tables again

2006-06-23 Thread Juergen Spitzmueller
Abdelrazak Younes wrote: > No, a default behavior doesn't need any choice. That's very bad UI wise. Why default behaviour? Depending on the content, I might want either a booktabs, an empty or a grid table. That's the choice I get from word processors. > But you could configure in the Preferenc

[patch] fix bug 2655

2006-06-23 Thread Georg Baum
This patch fixes bug 2655 (off by one error). It goes in trunk right now. Jean-Marc, also OK for 1.4.2? Georg Log: * src/mathed/math_gridinset.C (doDispatch): fix off by one error when checking cur.idx() (bug 2655)Index: src/mathed/math_gridinset.C ==

Re: qt4: table borders are wrong

2006-06-23 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: Yes, rather than fixing the symptom we should fix the origin of the problem. afaics, every time we contruct a painter: QPainter qp(qwa_->paintDevice()); Wait, there is somet

Re: lines in tables again

2006-06-23 Thread Georg Baum
Edwin Leuven wrote: > i call this pretty clear cut > > NO LINES: > > Paul Rubin > Andre Poenitz > Helge Hafting > Juergen Spitzmueller > Stephan Witt > Oscar Lopez > Ingar Pareliussen > Myself > > LINES: > > Lars > A.Scott Edward Hodel > Todd Denniston You forgot those who wanted three horiz

Re: lines in tables again

2006-06-23 Thread Abdelrazak Younes
Juergen Spitzmueller wrote: Peter Kümmel wrote: It seems this could be done by a lyx newbie like me. You're clearly not a newbie, but it could even be done by a newbie. Adding a RC_TABLE_LINES to LyXRC and then using lyxrc.read(RC_TABLE_LINES) in the ctor? Also an item in the "look and feel"

Re: qt4: table borders are wrong

2006-06-23 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: Yes, rather than fixing the symptom we should fix the origin of the problem. afaics, every time we contruct a painter: QPainter qp(qwa_->paintDevice()); Wait, there is something fishy here. My origin

Re: lines in tables again

2006-06-23 Thread Juergen Spitzmueller
Peter Kümmel wrote: > It seems this could be done by a lyx newbie like me. You're clearly not a newbie, but it could even be done by a newbie. > Adding a RC_TABLE_LINES to LyXRC and then using > lyxrc.read(RC_TABLE_LINES) in the ctor? > Also an item in the "look and feel" ui interface? > > Or is

Re: lines in tables again

2006-06-23 Thread Georg Baum
Edwin Leuven wrote: > so i don't understand why you are blocking this... This has been mentioned already: Most of us agree that the current default is bad, but if you ask what should be done instead there is no such good agreement anymore. Furthermore, this default has been like that for years. T

Re: Lyx 1.4.2svn Windows

2006-06-23 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> This patch adds support for \intop and \ointop. It goes in > Georg> later if nobody objects. > > Georg> Jean-Marc, also for 1.4? I think it is safe. > > Why not just > > \def\intop{\in

Re: lines in tables again

2006-06-23 Thread Peter Kümmel
Juergen Spitzmueller wrote: > This feature is so > easy to implement, I guess while arguing on the issue, we could have be done > with implementing already. It seems this could be done by a lyx newbie like me. Adding a RC_TABLE_LINES to LyXRC and then using lyxrc.read(RC_TABLE_LINES) in the cto

Re: lines in tables again

2006-06-23 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Good. so then you are 8 people that can collaborate to create an | > solution that is acceptable to all. _And_ at the same time gives LyX | > a new feature. | | if this is a joke, then you are the only one that is laughing.

Re: lines in tables again

2006-06-23 Thread Edwin Leuven
Juergen Spitzmueller wrote: > That's not a fair bill. I said I use no lines usually, not that I want to change the default to that. I agree with José that if we change we go for flexibility. This feature is so easy to implement, I guess while arguing on the issue, we could have be done with im

Re: lines in tables again

2006-06-23 Thread Juergen Spitzmueller
Edwin Leuven wrote: > NO LINES: [...] > Juergen Spitzmueller That's not a fair bill. I said I use no lines usually, not that I want to change the default to that. I agree with José that if we change we go for flexibility. This feature is so easy to implement, I guess while arguing on the issue

Re: lines in tables again

2006-06-23 Thread Edwin Leuven
Lars Gullik Bjønnes wrote: Good. so then you are 8 people that can collaborate to create an solution that is acceptable to all. _And_ at the same time gives LyX a new feature. if this is a joke, then you are the only one that is laughing...

Re: lines in tables again

2006-06-23 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | Jose' Matos wrote: | > On Friday 23 June 2006 13:30, Jose' Matos wrote: | >> Surprisingly (at least to me) there was a so clear cut between those two | >> options. | > there was _not_ a clear cut... | | i call this pretty clear cut | | NO LINES: | |

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Edwin Leuven
Peter Kümmel wrote: I would say "There Can Be Only One" we need to make a choice for trunk

Re: lines in tables again

2006-06-23 Thread Edwin Leuven
Jose' Matos wrote: On Friday 23 June 2006 13:30, Jose' Matos wrote: Surprisingly (at least to me) there was a so clear cut between those two options. there was _not_ a clear cut... i call this pretty clear cut NO LINES: Paul Rubin Andre Poenitz Helge Hafting Juergen Spitzmueller Stephan

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Peter Kümmel <[EMAIL PROTECTED]> writes: > > | Qt3 is a short term solution, in the long run it is a dead end. > | > | At the latest when KDE 4 is out the majority of the distros have Qt4. > | Also Qt4 could optionally ship with LSB systems. > | > | But LyX fiddles w

Re: lines in tables again

2006-06-23 Thread Jose' Matos
On Friday 23 June 2006 13:30, Jose' Matos wrote: > Surprisingly (at least to me) there was a so clear cut between those two > options. there was _not_ a clear cut... Today is a "no smiley day, not as I and Abdel seem to be doing a no no day. -- José Abílio

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | Qt3 is a short term solution, in the long run it is a dead end. | | At the latest when KDE 4 is out the majority of the distros have Qt4. | Also Qt4 could optionally ship with LSB systems. | | But LyX fiddles with four frontends. I want to see a longter

Re: lines in tables again

2006-06-23 Thread Edwin Leuven
Jose' Matos wrote: I am sorry but that is the point. You changing one arbitrary default by another arbitrary default. no lines is not an arbitrary default, it is the minimal (default) tabular Surprisingly (at least to me) there was a so clear cut between those two options. i have troub

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Peter Kümmel
Lars Gullik Bjønnes wrote: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > | Lars Gullik Bjønnes wrote: > | > Peter Kümmel <[EMAIL PROTECTED]> writes: > | > | > | > | Yes, I would drop all other front ends from trunk immediately. > | > | > | > So we should keep only the one that is possible

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Edwin Leuven
Abdelrazak Younes wrote: I am [not] saying that we should delete them but maybe not force all and every change to happen on all frontend at the same time. We should choose one (qt4) and let the other frontends be developed by those interested in them. i couldn't agree more

Re: lines in tables again

2006-06-23 Thread Jose' Matos
On Friday 23 June 2006 13:12, Edwin Leuven wrote: >> I also see that most peoble would like to retain the ability to insert >> tabulars with lines... > > > > sure, more is better, but that is besides the point I am sorry but that is the point. You changing one arbitrary default by another arbit

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Abdelrazak Younes
Abdelrazak Younes wrote: I am saying that we should delete them but maybe not force all and every I am _not_ saying ...

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Peter Kümmel
Abdelrazak Younes wrote: > Lars Gullik Bjønnes wrote: >> Peter Kümmel <[EMAIL PROTECTED]> writes: >> >> | >> | Yes, I would drop all other front ends from trunk immediately. >> | >> >> So we should keep only the one that is possible to use on most distros >> and platforms then? Qt3 it is. I'll co

Re: Bug: Label overlays display equation 1.4.1 on Mac

2006-06-23 Thread Enrico Forestieri
On Thu, Jun 22, 2006 at 04:33:16PM -0700, Bryan Gmyrek wrote: > In LyX version 1.4.1 on Mac OS X 10.4.6 the labels of equations > overlays the equation. This is different from bug # 681 > Screen shot here: > http://www.flickr.com/photos/[EMAIL PROTECTED]/172899674/ I think this happens because

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Peter Kümmel <[EMAIL PROTECTED]> writes: | > | | > | Yes, I would drop all other front ends from trunk immediately. | > | | > So we should keep only the one that is possible to use on most

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Man... isn't that what we are discussing right now? What is the | difference between this and a "real" discussion? Putting on the correct hat perhaps. I have only been discussing: - Do we have code rules - What do they say, and do w

Re: lines in tables again

2006-06-23 Thread Edwin Leuven
Lars Gullik Bjønnes wrote: do you get lines if you import that into lyx with tex2lyx? of course not I also see that most peoble would like to retain the ability to insert tabulars with lines... sure, more is better, but that is besides the point if people have to choose between no lines

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Peter Kümmel <[EMAIL PROTECTED]> writes: | > | | > | Yes, I would drop all other front ends from trunk immediately. | > | | > So we should keep only the one that is possible to use on most | > distros | > and platform

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Lars Gullik Bjønnes wrote: | > | > Andre Poenitz <[EMAIL PROTECTED]> writes: | > | > | We have abondoned Coding_Rules(?) a long time ago a

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Peter Kümmel <[EMAIL PROTECTED]> writes: | | Yes, I would drop all other front ends from trunk immediately. | So we should keep only the one that is possible to use on most distros and platforms then? Qt3 it is. I'll commence with the deleteion of the others right a

Re: lines in tables again

2006-06-23 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > "stupid" is not objective. so you have to remove that | | i don't see why: | | 1. if i insert a tabular in latex | | \begin{tabular}{ccc} | & & \\ | & & \\ | \end(tabular) | | i don't have any lines | | so why does

Re: lines in tables again

2006-06-23 Thread Edwin Leuven
Lars Gullik Bjønnes wrote: "stupid" is not objective. so you have to remove that i don't see why: 1. if i insert a tabular in latex \begin{tabular}{ccc} & & \\ & & \\ \end(tabular) i don't have any lines so why does lyx add lines? 2. why are lines the way they are in lyx? historical acc

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Lars Gullik Bjønnes
Peter Kümmel <[EMAIL PROTECTED]> writes: | | Yes, I would drop all other front ends from trunk immediately. | So we should keep only the one that is possible to use on most distros and platforms then? Qt3 it is. I'll commence with the deleteion of the others right away. | | Often it sounds li

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Lars Gullik Bjønnes wrote: | > | > Andre Poenitz <[EMAIL PROTECTED]> writes: | > | > | We have abondoned Coding_Rules(?) a long time ago and used 'do | > | > whatever

Re: lines in tables again

2006-06-23 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > p1: Changing user visible defaults is bad | > p2: This patch changes user visible defaults | > - | > This patch is bad | | | p1. changing stupid user visible defaults is good | p2. t

Re: [Path] WorkArea eradication from BufferView, step 2: fix scrollbar handling

2006-06-23 Thread Peter Kümmel
Abdelrazak Younes wrote: > And the good news is that, with this patch and msvc2005, the UserGuide > PageDown scrolling test is now at *18* seconds whereas it was at *34* > seconds previously! It is now faster than qt3 on my machine (which is 22s). Great, I also get a huge speedup, from 31 to 19 se

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Jose' Matos
On Friday 23 June 2006 11:00, Peter Kümmel wrote: > Abdelrazak Younes wrote: > > Peter Kümmel wrote: > > > > I didn't know the 'no-smiley day', but it looks > interesting, and I think I like it. The concept is best expressed here: http://www.lyx.org/news/2726.php#item3 -- José Abílio

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Peter Kümmel
Andre Poenitz wrote: > On Tue, Jun 20, 2006 at 01:09:15PM +0200, Peter Kümmel wrote: >> +if (width != -1 && height != -1 && posx != -1 && posy != -1) { >> +view.initNormalGeometry(QRect(posx, posy, width, height)); >> +view.resize(width, height); >> +view.mo

Re: qt4: table borders are wrong

2006-06-23 Thread Edwin Leuven
Abdelrazak Younes wrote: Edwin Leuven wrote: Abdelrazak Younes wrote: Yes, rather than fixing the symptom we should fix the origin of the problem. afaics, every time we contruct a painter: QPainter qp(qwa_->paintDevice()); Wait, there is something fishy here. My original patched used to ca

Re: [Still better patch] Re: [New patch] Re: [Patch] Re: Drawing error with collapsable insets.

2006-06-23 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> I do not know whether this is related to your patch(es): try to >> insert a collapsable inset in a tabular cell; the right margin of >> the inset is outside of the screen. Martin> I suppose the speed-up patch exposed this bug, Umm

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Andre Poenitz <[EMAIL PROTECTED]> writes: | > | We have abondoned Coding_Rules(?) a long time ago and used 'do | > whatever | > | the majority in src/* does' | > No. | | Is that an answer t

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: I didn't know the 'no-smiley day', but it looks interesting, and I think I like it. > We should keep one (qt4 of course) Yes, I would drop all other front ends from trunk immediately. >> 2 operating systems, > > 3. You forgot MacOSX! > >> Qt

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: "Bo Peng" <[EMAIL PROTECTED]> writes: | > We have abondoned Coding_Rules(?) a long time ago and used 'do whatever | > the majority in src/* does' | | Because it is easier to change the rules than change source code. BTW, | the style I like is: | | class ThisClass |

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: | >> I think it's just because we decided it improves readability. These things | >> should be read from right to left: | >>QRect

Re: qt4: table borders are wrong

2006-06-23 Thread Abdelrazak Younes
Edwin Leuven wrote: Edwin Leuven wrote: we could check for default values instead at the beginning of setQPainterPen, but this seems a bit fragile this seems to work fine (since we call this one only after creating a painter): void QLPainter::setQPainterPen(QPainter & qp, LColor_color col,

Re: lines in tables again

2006-06-23 Thread Edwin Leuven
Lars Gullik Bjønnes wrote: p1: Changing user visible defaults is bad p2: This patch changes user visible defaults - This patch is bad p1. changing stupid user visible defaults is good p2. this patch changes stupid user visible defaults -

Re: [Fwd: bug?: section numbering in note-insets]

2006-06-23 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Sven" == Sven Schreiber <[EMAIL PROTECTED]> writes: Sven> Hi all, when I shove an entire subsection into a note inset, the Sven> numbering of the other non-note subsections remains as if Sven> nothing was "commented out",

Re: qt4: table borders are wrong

2006-06-23 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Yes, rather than fixing the symptom we should fix the origin of the problem. afaics, every time we contruct a painter: QPainter qp(qwa_->paintDevice()); Wait, there is something fishy here. My original patched used to cache also the current

Re: [Fwd: bug?: section numbering in note-insets]

2006-06-23 Thread Jean-Marc Lasgouttes
> "Sven" == Sven Schreiber <[EMAIL PROTECTED]> writes: Sven> Hi all, when I shove an entire subsection into a note inset, the Sven> numbering of the other non-note subsections remains as if Sven> nothing was "commented out", i.e. numbers on screen do not match Sven> the printed output. Sven>

Re: lines in tables again

2006-06-23 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > | > I do not think such a change of defaults is acceptable without | > providing for a mechanism to retain the same defaults. | | to me this looks like you are pointing a gun with a blank | | really, where's the logic?

Re: Qt4 frontend save/restore geoemtry patch

2006-06-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Wed, Jun 21, 2006 at 10:24:31AM +, Angus Leeming wrote: | >> I think it's just because we decided it improves readability. These things | >> should be read from right to left: | >>QRect const & | >>A reference

Re: qt4: table borders are wrong

2006-06-23 Thread Edwin Leuven
Edwin Leuven wrote: we could check for default values instead at the beginning of setQPainterPen, but this seems a bit fragile this seems to work fine (since we call this one only after creating a painter): void QLPainter::setQPainterPen(QPainter & qp, LColor_color col, Painter::line

Re: lines in tables again

2006-06-23 Thread Edwin Leuven
Lars Gullik Bjønnes wrote: I do not think such a change of defaults is acceptable without providing for a mechanism to retain the same defaults. to me this looks like you are pointing a gun with a blank really, where's the logic?

Re: lines in tables again

2006-06-23 Thread Lars Gullik Bjønnes
Edwin Leuven <[EMAIL PROTECTED]> writes: | the majority of the people who responded were clearly in favor of | defaulting to tables without lines | | it makes more sense in any case so unless someone is going to point a | shotgun at me, i am going to shove in the attached... I do not think suc

[Fwd: bug?: section numbering in note-insets]

2006-06-23 Thread Sven Schreiber
Got no replies on this on the users list, so I'm trying again on lyx-devel. -sven Original-Nachricht Betreff: bug?: section numbering in note-insets Datum: Thu, 15 Jun 2006 14:33:13 +0200 Von: Sven Schreiber <[EMAIL PROTECTED]> An: LyX Users Hi all, when I shove an entire subse

Re: [Patch] reduce the number of call to

2006-06-23 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Hello, One more brick to the wall: 16/17 seconds for UserGuide now. Abdel. Your recent two patches are very interesting. Are they already in your branch? (Wanna see the speedup by myself. :) ) Yes, they are in my branch. By the way look in the

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Andre Poenitz <[EMAIL PROTECTED]> writes: | > | We have abondoned Coding_Rules(?) a long time ago and used 'do | > whatever | > | the majority in src/* does' | > No. | | Is that an answer to a question, an imperative a

Re: r14166 - in /lyx-devel/trunk/src: frontends/qt3/QtView.C ...

2006-06-23 Thread Abdelrazak Younes
Peter Kümmel wrote: Peter Kümmel wrote: Haven't we discussed the patch on the list? I don't wanna explain all the stuff again in the log message. . don't wanna see here my comments again ;) Sorry, this was a very emotional reply on a harmless request, but I didn't expect that this patch

Re: [PATCH] GUI API Cleanup Merge patch

2006-06-23 Thread Jose' Matos
On Friday 23 June 2006 08:44, Abdelrazak Younes wrote: > Does your "No" weight more than our three "Yes"? That is one of the privileges of the BDFL (python jargon). > The weather is hot today... Foggy around here, so not much. But then we always expected our lost king to appear in a foggy m

Re: qt4: table borders are wrong

2006-06-23 Thread Edwin Leuven
Abdelrazak Younes wrote: Yes, rather than fixing the symptom we should fix the origin of the problem. afaics, every time we contruct a painter: QPainter qp(qwa_->paintDevice()); we get the default pen: The default pen is a solid black brush with 0 width, square cap style (Qt::Square

Re: [Patch] reduce the number of call to

2006-06-23 Thread Peter Kümmel
Abdelrazak Younes wrote: > Hello, > > One more brick to the wall: 16/17 seconds for UserGuide now. > > Abdel. > Your recent two patches are very interesting. Are they already in your branch? (Wanna see the speedup by myself. :) ) Peter

  1   2   >