Re: Properties to control placement of accidentals in KeySignatures (issue 6461085)

http://codereview.appspot.com/6461085/diff/2001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/6461085/diff/2001/scm/define-grob-properties.scm#newcode481 scm/define-grob-properties.scm:481: for the clef, such as @code{#(2 3 4 2 1 2 1)}.

Re: Brain surgery on the build system, first stage (issue 6446096)

http://codereview.appspot.com/6446096/diff/2001/stepmake/stepmake/generic-targets.make File stepmake/stepmake/generic-targets.make (left): http://codereview.appspot.com/6446096/diff/2001/stepmake/stepmake/generic-targets.make#oldcode1 stepmake/stepmake/generic-targets.make:1: .PHONY : all clean

Re: Use directory-local variables to establish some coding styles in Emacs (issue 6460109)

Reviewers: Ian Hulin (gmail), Message: On 2012/08/19 12:12:36, Ian Hulin (gmail) wrote: Do we need to add anything to the standard .gitignore for these? Why should we? This adds just one file which _should_ be checked out. They're files in the git directories for developers developing the k

Re: Use directory-local variables to establish some coding styles in Emacs (issue 6460109)

http://codereview.appspot.com/6460109/diff/3001/.dir-locals.el File .dir-locals.el (right): http://codereview.appspot.com/6460109/diff/3001/.dir-locals.el#newcode6 .dir-locals.el:6: (indent-tabs-mode)) On 2012/08/19 16:02:31, Graham Percival wrote: Does this mean what I think it means? No, it

Re: Use directory-local variables to establish some coding styles in Emacs (issue 6460109)

On 2012/08/19 16:07:28, Ian Hulin (gmail) wrote: On 2012/08/19 12:37:38, dak wrote: > I don't get the point you are trying to make. Sorry for being obtuse. I'd like your patch description to say more and give answers to some of the following questions. Who is the target

Re: Doc: Bar_engraver is required for system-start clefs (2694) (issue 6446160)

http://codereview.appspot.com/6446160/diff/1/lily/bar-engraver.cc File lily/bar-engraver.cc (right): http://codereview.appspot.com/6446160/diff/1/lily/bar-engraver.cc#newcode119 lily/bar-engraver.cc:119: " is required to trigger the creation of system-start clefs.", system-start is either an ide

Re: Doc: Bar_engraver is required for system-start clefs (2694) (issue 6446160)

On 2012/08/20 09:32:18, Trevor Daniels wrote: On 2012/08/20 08:13:32, dak wrote: > or it is plain English, in which case it should be written > system start, namely without a dash in the middle. It /is/ plain English; system-start is a compound adjective of clef. Shouldn't

Re: GOP2-4: add script for batch indenting Scheme files (issue 6450162)

http://codereview.appspot.com/6450162/diff/1/scripts/auxiliar/fixscm.sh File scripts/auxiliar/fixscm.sh (right): http://codereview.appspot.com/6450162/diff/1/scripts/auxiliar/fixscm.sh#newcode15 scripts/auxiliar/fixscm.sh:15: emacs -batch "$@" --eval "${elisp_expression}" Can you verify that ema

Re: CG: All engravers should have double-quotes around them (issue 6461098)

Reviewers: Graham Percival, Message: On 2012/08/21 11:57:45, Graham Percival wrote: LGTM, but two questions: 1) why should engravers have double-quotes? Because the CG states so. Was it only working by accident before, or are you hoping to simplify the parser by no longer accepting the non

Re: CG: All engravers should have double-quotes around them (issue 6461098)

On 2012/08/21 12:08:16, dak wrote: On 2012/08/21 11:57:45, Graham Percival wrote: > LGTM, but two questions: > 1) why should engravers have double-quotes? Because the CG states so. > Was it only working by accident > before, or are you hoping to simplify the parser by no longe

Re: hairpin.cc: consider suicide before drawing stencil; issue 2583 (issue 6449126)

http://codereview.appspot.com/6449126/diff/1003/lily/grob-property.cc File lily/grob-property.cc (right): http://codereview.appspot.com/6449126/diff/1003/lily/grob-property.cc#newcode254 lily/grob-property.cc:254: *alist = scm_assq_remove_x (*alist, sym); I was considering cherry-picking this pa

Re: Issue 2366: THANKS needs updating or deleting (issue 6478050)

Reviewers: colinpkcampbell_gmail.com, http://codereview.appspot.com/6478050/diff/1/THANKS File THANKS (right): http://codereview.appspot.com/6478050/diff/1/THANKS#newcode15 THANKS:15: Benkő Pál On 2012/08/24 04:11:53, Colin Campbell wrote: I believe that Pál is his given name and Benkő his sur

Re: Check for Fontforge with enable-double (1637) (issue 6484062)

On 2012/08/26 22:56:44, John Mandereau wrote: LGTM except one nitpick (see comment). http://codereview.appspot.com/6484062/diff/1/configure.in File configure.in (right): http://codereview.appspot.com/6484062/diff/1/configure.in#newcode174 configure.in:174: if $FONTFORGE --version 2>&1|egrep

Re: Check for Fontforge with enable-double (1637) (issue 6484062)

On 2012/08/27 09:04:46, dak wrote: On 2012/08/26 22:56:44, John Mandereau wrote: > LGTM except one nitpick (see comment). > > http://codereview.appspot.com/6484062/diff/1/configure.in > File configure.in (right): > > http://codereview.appspot.com/6484062/diff/1/confi

Re: Adds octavation-eight-interface to the Beam_collision_engraver (issue 6475065)

http://codereview.appspot.com/6475065/diff/1/scm/define-grob-interfaces.scm File scm/define-grob-interfaces.scm (right): http://codereview.appspot.com/6475065/diff/1/scm/define-grob-interfaces.scm#newcode223 scm/define-grob-interfaces.scm:223: annotation." What about \clef "bass_8" or \clef "tre

Re: Adds octavation-eight-interface to the Beam_collision_engraver (issue 6475065)

On 2012/08/29 15:48:36, mike7 wrote: On 29 août 2012, at 16:13, mailto:d...@gnu.org wrote: > http://codereview.appspot.com/6475065/diff/1/scm/define-grob-interfaces.scm#newcode223 > scm/define-grob-interfaces.scm:223: annotation." > What about \clef "bass_8" or \clef "treble_15" ? Should

Re: Creates FingeringColumn to prevent vertical fingering intersections. (issue 6472056)

http://codereview.appspot.com/6472056/diff/1/lily/fingering-column.cc File lily/fingering-column.cc (right): http://codereview.appspot.com/6472056/diff/1/lily/fingering-column.cc#newcode38 lily/fingering-column.cc:38: map shifted; It seems quite pointless to use a map here instead of a bool arra

Re: Adds support for cross-staff-stems (issue 6344092)

http://codereview.appspot.com/6344092/diff/12002/scm/music-functions.scm File scm/music-functions.scm (right): http://codereview.appspot.com/6344092/diff/12002/scm/music-functions.scm#newcode1784 scm/music-functions.scm:1784: (if (<= 2 (length stems)) Why not use "and" here and leave out the #f

Re: Creates getter and setter functions for buildings (issue 6496067)

On 2012/08/31 10:20:04, Graham Percival wrote: http://codereview.appspot.com/6496067/diff/1/lily/include/skyline.hh File lily/include/skyline.hh (right): http://codereview.appspot.com/6496067/diff/1/lily/include/skyline.hh#newcode42 lily/include/skyline.hh:42: inline Real start () const { ret

Allow digits in identifiers (issue 6493072)

All in all, a large step backwards for making the lexer behave predictably across modes regarding word and command syntax, connected with several timing problems when parsing. It looks like some _severe_ doctoring around with regard to notenames was done to make regtests pass without an actual un

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

http://codereview.appspot.com/6498077/diff/21/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/6498077/diff/21/lily/axis-group-interface.cc#newcode390 lily/axis-group-interface.cc:390: /* Where is the point in putting a whole callback inside o

Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073)

http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc#newcode213 lily/self-alignment-interface.cc:213: vector_sort (vais, less ()); Seriously? If

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

.end ()) On 2012/09/02 16:45:14, MikeSol wrote: On 2012/09/02 15:59:00, dak wrote: > It is quite nonsensical to have slur_stubs be a map indexed via slurs_[j] rather > than just an array indexed through j. > > That is inefficient use of time, memory, and complexity. It is sens

Re: Allow digits in identifiers (issue 6493072)

wrote: On 2012/09/02 11:52:46, dak wrote: > Did you check that r-. does still work as intended when removing this rule? The syntax never allowed new identifier definitions in sequential/simultaneous music. That is not an answer to my question. \relative c' { new-variable-name = {

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

On 2012/09/03 03:41:39, Patrick McCarty wrote: LGTM Let's not get this merged. ly_lily_module_constant ("module-variable") is available in _both_ Guile 1.8 as well as Guile 2.0. It may cause a slight cell count hit in Guile 1.8, but we don't want Guile 1 to stick around until the end of 2.17

Re: layout.cc: do not draw empty boxes (issue 6450113)

http://codereview.appspot.com/6450113/diff/10001/lily/lookup.cc File lily/lookup.cc (right): http://codereview.appspot.com/6450113/diff/10001/lily/lookup.cc#newcode172 lily/lookup.cc:172: if (b.x ().length () < blotdiameter) On 2012/09/03 07:25:53, Keith wrote: It is arguably valid to request a

Re: Allow digits in identifiers (issue 6493072)

On 2012/09/03 18:08:23, Keith wrote: The version "digits, but not at the end" lets us read vn2_meas345ff = \relative c' cis1 by depending on the ability of the scanner to back up. The input ceses128_3ap is a single word, but upon finding the \ in ceses128_3\p the scanner has to back u

Re: part-combiner.scm: replace use of "when" with "moment" (issue 6500069)

Reviewers: Keith, http://codereview.appspot.com/6500069/diff/1/scm/part-combiner.scm File scm/part-combiner.scm (right): http://codereview.appspot.com/6500069/diff/1/scm/part-combiner.scm#newcode21 scm/part-combiner.scm:21: (use-modules (oop goops)) On 2012/09/03 20:14:24, Keith wrote: I'm jus

Re: Allow direction - ^ _ before string indication \1, \2... (issue 6489074)

Reviewers: janek, http://codereview.appspot.com/6489074/diff/1/lily/parser.yy File lily/parser.yy (right): http://codereview.appspot.com/6489074/diff/1/lily/parser.yy#newcode2457 lily/parser.yy:2457: | string_number_event On 2012/09/04 05:56:15, janek wrote: Why is this now in "direction_less_

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

On 2012/09/04 08:09:21, mike7 wrote: On 4 sept. 2012, at 09:45, mailto:k-ohara5...@oco.net wrote: > Works for me. 16% slower than master. > (I'll try make clean and make.) > It makes no change for the Chopin; can you give an example where it > helps? In the Chopin, ragged-bottom is false s

Re: Allow digits in identifiers (issue 6493072)

On 2012/09/05 06:59:16, Keith wrote: While we are thinking about this, I suggest we remove (later) the rule forbidding backing-up states in the scanner. It made only a 0.2% in the worst-case scenario I could think of. The rule had been violated, giving us the slightly slower scanner, for a

Re: Allow digits in identifiers (issue 6493072)

On 2012/09/05 09:26:12, Keith wrote: Agreed, but I'll still pout a couple more times that you get your Schemy-dashes and underscores but I still have to refer to the motif from measure tousend_sechshundert_siebzig _I_ get my Schemy-dashes? I was _not_, I repeat, _not_ the person who invente

Allows user to set ChordName text (issue 6496085)

http://codereview.appspot.com/6496085/diff/1/lily/chord-name-engraver.cc File lily/chord-name-engraver.cc (right): http://codereview.appspot.com/6496085/diff/1/lily/chord-name-engraver.cc#newcode83 lily/chord-name-engraver.cc:83: || ly_is_procedure (chord_name_->get_property ("text"))); If it is

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

On 2012/09/06 17:20:59, Ian Hulin (gmail) wrote: On 2012/09/03 07:25:20, Patrick McCarty wrote: > On 2012/09/03 05:39:57, dak wrote: > > On 2012/09/03 03:41:39, Patrick McCarty wrote: > > > LGTM > > > > Let's not get this merged. ly_lily_module_constant (&quo

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

On 2012/09/06 23:24:04, Ian Hulin (gmail) wrote: On 2012/09/06 18:07:53, dak wrote: > When we go Guilev2, we don't want to search for all the backward compatibility. > So I'd say you use something like > > #if GUILEV1 > > for splicing in the compatibility stuff, a

Re: change defaults for dot spacing in repeat sign to accommodate tab staves (issue 6488097)

On 2012/09/08 18:54:07, Keith wrote: http://codereview.appspot.com/6488097/diff/3001/scm/bar-line.scm File scm/bar-line.scm (right): http://codereview.appspot.com/6488097/diff/3001/scm/bar-line.scm#newcode178 scm/bar-line.scm:178: ;; the default distance between centre of dots is composed o

Re: change defaults for dot spacing in repeat sign to accommodate tab staves (issue 6488097)

Stupid question: anybody have an idea where the dots are to fall in four-line plainchant? Is this compatible to where we want to see them in six-line and four-line tablature? http://codereview.appspot.com/6488097/ ___ lilypond-devel mailing list lilyp

Re: change defaults for dot spacing in repeat sign to accommodate tab staves (issue 6488097)

Anybody else annoyed just how hard it is to get simple things like that right, when they probably weren't thought through before anyhow? In any case, is there a "natural" already existing override for hand-tweaking dot distance? With vertical time signature position, the user would always have t

Re: Preliminary work on issue 2547 (issue 6261048)

Reviewers: Trevor Daniels, Message: On 2012/09/09 09:39:02, Trevor Daniels wrote: As I don't own this Issue I've created a new one to continue this work at 6498109. David: you could close this one now. Done, and thanks for taking over. Description: Preliminary work on issue 2547 This is u

Re: Approximates cross-staff slurs in VerticalAxisGroup vertical-skylines. (issue 6498077)

http://codereview.appspot.com/6498077/diff/6033/lily/phrasing-slur-engraver.cc File lily/phrasing-slur-engraver.cc (right): http://codereview.appspot.com/6498077/diff/6033/lily/phrasing-slur-engraver.cc#newcode116 lily/phrasing-slur-engraver.cc:116: Grob *stub = make_spanner ("SlurStub", info.gr

Re: Allows user to set ChordName text (issue 6496085)

06 09:59:09, MikeSol wrote: On 2012/09/06 08:50:40, dak wrote: > If one is doing the chord calculation manually, you can't make the decision of > whether a chord changed based on the automatic calculation. For better or > worse, you need to compare the computed chord versions/

Re: Allows user to set ChordName text (issue 6496085)

://codereview.appspot.com/6496085/diff/1/lily/chord-name-engraver.cc#newcode87 lily/chord-name-engraver.cc:87: { On 2012/09/06 08:50:40, dak wrote: What kind of contorted logic and guessing game is that? if (make_markup) { [old code ending in setting "text"] } Please don't obfuscate co

Re: Allows user to set ChordName text (issue 6496085)

On 2012/09/12 11:48:45, mike7 wrote: > http://codereview.appspot.com/6496085/diff/1/lily/chord-name-engraver.cc#newcode87 > lily/chord-name-engraver.cc:87: { > On 2012/09/06 08:50:40, dak wrote: >> What kind of contorted logic and guessing game is that? >> if (make_ma

Re: Allows user to set ChordName text (issue 6496085)

On 2012/09/12 16:11:05, dak wrote: when it should rather have the form if (rest_event_) { - SCM no_chord_markup = get_property ("noChordSymbol"); - if (!Text_interface::is_markup (no_chord_markup)) ... + if (make_markup) + { + SCM no_ch

Re: Implement \hidden/\hide as a shorthands for \tweak/override #'\stencil = ##f (issue 6443087)

Reviewers: Graham Percival, Message: On 2012/09/12 23:20:46, Graham Percival wrote: I'm really not happy with \hide vs. \hidden depending on whether it's override or tweak. How do we expect novice users (or moderate users) to know which they need to use? How do we expect them to know whet

Re: Implement \hidden/\hide as a shorthands for \tweak/override #'\stencil = ##f (issue 6443087)

On 2012/09/15 06:34:02, Keith wrote: On 2012/09/13 00:06:12, dak wrote: > I copy your "not happy" sentiment, but when thinking this through, > one really wants to have both override and tweak under a reasonably > idiomatic shortcut available. After trying them out, t

Re: layout.cc: do not draw empty boxes (issue 6450113)

http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm File scm/fret-diagrams.scm (right): http://codereview.appspot.com/6450113/diff/8003/scm/fret-diagrams.scm#newcode649 scm/fret-diagrams.scm:649: (ordered-cons (car corner1) (car corner2)) I was wondering whether it would not ma

Re: Doc: document \time command fully (2807) (issue 6532055)

On 2012/09/22 01:30:50, Graham Percival wrote: LGTM http://codereview.appspot.com/6532055/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/6532055/diff/1/Documentation/notation/rhythms.itely#newcode1067 Documentat

Re: Doc: document \time command fully (2807) (issue 6532055)

On 2012/09/22 04:37:42, dak wrote: On 2012/09/22 01:30:50, Graham Percival wrote: > LGTM > > http://codereview.appspot.com/6532055/diff/1/Documentation/notation/rhythms.itely > File Documentation/notation/rhythms.itely (right): > > http://codereview.appspot.com/6532055/di

Re: Issue 2717: Implement \single, \omit and \hide (issue 6495135)

Reviewers: Keith, Message: On 2012/09/24 06:34:00, Keith wrote: Works well for me. You mis-typed something in the description because > so you can use things like \single\voiceOne c4 . is not true. But it is _intended_ to be true. It is just that LilyPond is an inconsistent heap of g

Re: Set up indent-tabs-mode in lexer.ll and parser.yy (issue 6551050)

Reviewers: joeneeman, janek, Message: On 2012/09/26 05:24:37, janek wrote: Do i understand correctly that this is something for Emacs' sake? If so, please add this information to the commit message, so that non-emacs people like me will immediately know what's it about. Oops. Sorry for the

Re: parser.yy: remove STRING_IDENTIFIER token (issue 6542057)

Reviewers: lemzwerg, joeneeman, janek, Message: On 2012/09/26 05:35:16, janek wrote: David wrote: > ...and where the semantics indeed require a plain string, > an error is generated explicitly in the action instead > of leaving it to the parser to complain about bad grammar. I'm not sure i un

Re: Get along with use of grob-property instead of grob-property-path in overrides (issue 6544060)

Reviewers: janek, Message: On 2012/09/26 06:14:04, janek wrote: Do i understand correctly that grob-property-path is just a list of properties, like '('thickness 'gap 'color)? Apart from overquoting (when quoting a list, its members are already quoted), yes. If so, i find the name misleadi

Re: Issue 2717: Implement \single, \omit and \hide (issue 6495135)

On 2012/09/26 09:05:18, Reinhold wrote: is there any particular reason why you created a new command (\single) and didn't reuse \once. IMO, using \once as an indicator that the next command applies only to the next item would make it more consistent. \once does something entirely different.

Re: Issue 2717: Implement \single, \omit and \hide (issue 6495135)

Reinhold Kainhofer writes: On 26/09/2012 11:26, d...@gnu.org wrote: \once does something entirely different. It does not turn an override into a tweak but rather marks it at being active only at the current timestep. \once applies at a single time, \single applies on a single item. To

Re: Adds tick mark to scripts (issue 6568055)

http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf File mf/feta-scripts.mf (right): http://codereview.appspot.com/6568055/diff/1/mf/feta-scripts.mf#newcode1781 mf/feta-scripts.mf:1781: fet_beginchar ("snap pizzicato (Bartok pizzicato)", "snappizzicat"); It would appear you renamed t

Re: Provide \hide and \omit functions for transparent and void glyphs (issue 6575048)

Reviewers: janek, Message: On 2012/09/28 05:18:42, janek wrote: sorry to join the discussion so late... what about using \no for turning stencil off? e.g. \new Voice \with { \no StringNumber } As for the code, it LGTM. It is grammatically cuter in connection with \with, but that's actual

Re: Provide \hide and \omit functions for transparent and void glyphs (issue 6575048)

On 2012/09/28 06:26:03, janek wrote: On Fri, Sep 28, 2012 at 7:33 AM, wrote: >> what about using \no for turning stencil off? e.g. >> \new Voice \with { \no StringNumber } > > It is grammatically cuter in connection with \with, but that's actually > more a problem of \wit

Re: Provide \hide and \omit functions for transparent and void glyphs (issue 6575048)

On 2012/09/28 15:06:38, janek wrote: On Fri, Sep 28, 2012 at 9:30 AM, wrote: > I must be in a controversial mood today since I feel like upholding the > idea. I had been thinking about it while fetching breakfast and eating > and was about to reenter discussion when I

Re: Eliminate MARKUP_IDENTIFIER and MARKUPLIST_IDENTIFIER (issue 6561053)

Reviewers: janek, Message: On 2012/09/28 06:22:40, janek wrote: The description looks really nice, but unfortunately i think i don't grasp the consequences of this change. Could you give some before/after input examples? Embarrassingly, not really. The point of this change is to move forwa

Re: Eliminate MARKUP_IDENTIFIER and MARKUPLIST_IDENTIFIER (issue 6561053)

On 2012/09/29 13:37:28, janek wrote: On Sat, Sep 29, 2012 at 3:10 PM, wrote: > Embarrassingly, not really. The point of this change is to move forward > in removing the special-casing of various *_IDENTIFIER token types. The > target is to arrive at only a single SCM_I

Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052)

http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm File scm/bar-line.scm (right): http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm#newcode225 scm/bar-line.scm:225: (define-public bar-glyph-alist '()) This interface definition is asking for trouble. It is an impor

Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052)

On 2012/09/30 08:33:16, marc wrote: Am 30.09.2012 10:01, schrieb d...@gnu.org: > > http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm > File scm/bar-line.scm (right): > > http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm#newcode225 > > scm/bar-line.scm:225: (defi

Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052)

On 2012/09/30 19:44:49, marc wrote: Am 30.09.2012 11:02, schrieb d...@gnu.org: > [...] > First, the define-public is asking for trouble. You are exposing an > internal Scheme data structure to users and make it overwritable by the > user. If the user follows this invitation, the effects will bl

Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052)

On 2012/10/01 08:46:09, marc wrote: Am 30.09.2012 22:03, schrieb d...@gnu.org: > On 2012/09/30 19:44:49, marc wrote: >> Am 30.09.2012 11:02, schrieb d...@gnu.org: >> > [...] >> > First, the define-public is asking for trouble. You are exposing an >> > internal Scheme data structure to users and

Re: Provide define-session and define-session-public commands (issue 6588056)

Reviewers: Ian Hulin (gmail), Message: On 2012/10/01 18:02:16, Ian Hulin (gmail) wrote: Just a question about the doc-string. http://codereview.appspot.com/6588056/diff/1/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/6588056/diff/1/scm/lily.scm#newcode51 scm/lily.sc

Re: Provide \hide and \no functions for transparent and void glyphs (issue 6575048)

On 2012/10/02 00:23:55, Graham Percival wrote: https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly#newcode649 ly/music-functions-init.ly:649: no = why

Re: Provide \hide and \no functions for transparent and void glyphs (issue 6575048)

On 2012/10/02 03:38:42, dak wrote: On 2012/10/02 00:23:55, Graham Percival wrote: > https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly > File ly/music-functions-init.ly (right): > > https://codereview.appspot.com/6575048/diff/8001/ly/music-funct

Re: Provide \hide and \no functions for transparent and void glyphs (issue 6575048)

On 2012/10/02 11:01:52, Keith wrote: Still looks good. What does still look good? \omit is better than \no because 'omit' is a verb like we use in parallel constructions \override, etc. A verb is appropriate because your function does perform an action: the \f is conceptually part of the

Re: Provide \hide and \no functions for transparent and void glyphs (issue 6575048)

On 2012/10/02 11:50:04, J_lowe wrote: I know \remove has been taken, but is it possible to make a function (?) know what the context of it's action is? \remove is a reserved word, so it is treated specially in the syntax. If we hypothesize that it was a function, determining its context would

Re: Provide define-session and define-session-public commands (issue 6588056)

On 2012/10/03 05:10:27, janek wrote: Could you modify the commit message so that it says why we need this change? It's not really a change but an API to something you had to do by hand previously if you were working on .scm files providing user customization in some manner (and there are a numb

Re: Provide \hide and \no functions for transparent and void glyphs (issue 6575048)

On 2012/10/03 04:04:07, Keith wrote: If you name it '\hide', I'll probably make an '\unHide' to revert the stencil. If you name it \no, I'll name the stencil-restoring function '\restore'. You can paint your shed whatever color you like. \hide and \no are for different purposes (so far, \h

Re: Provide define-session and define-session-public commands (issue 6588056)

On 2012/10/03 06:20:10, janek wrote: On Wed, Oct 3, 2012 at 8:01 AM, wrote: > On 2012/10/03 05:10:27, janek wrote: >> After reading the comments in your code i don't understant what's its >> purpose. > > Sounds like I should rather delete the comments... oh, no! They

Re: Provide \hide and \no functions for transparent and void glyphs (issue 6575048)

On 2012/10/03 06:27:56, Keith wrote: On Tue, 02 Oct 2012 23:15:23 -0700, wrote: > \hide and \no are for different purposes Oops, I forgot we were talking about the name 'no' for the function '\omit'. The command to restore the stencil could be \unOmit or \restore.

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

Reviewers: david.nalesnik, janek, Message: On 2012/10/03 05:04:11, janek wrote: i've skimmed over the discussion in http://code.google.com/p/lilypond/issues/detail?id=2858 and i'm confused. Do we want to change \shape GrobName #'offsets into \shape #'offsets GrobName or \shape #'offsets (used

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

On 2012/10/02 23:39:05, david.nalesnik wrote: LGTM [...] I wonder if it would be helpful to alter one or two of the following applications of the function as override to the tweak form. [...] What about adding a demonstration here of the ability to modify curves beginning at the same ti

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

On 2012/10/03 15:08:30, david.nalesnik wrote: On 2012/10/03 13:57:25, dak wrote: [...] > To those suggestions let me answer with the famous answer to the question "Mr > Gandhi, what do you think of Western civilization?", namely with "I would > consider it a goo

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

On 2012/10/03 16:38:45, janek wrote: On Wed, Oct 3, 2012 at 3:46 PM, wrote: > On 2012/10/03 05:04:11, janek wrote: >> >> i've skimmed over the discussion in >> http://code.google.com/p/lilypond/issues/detail?id=2858 >> and i'm confused. Do we want to change >> \shape GrobNa

Re: Issue 2859: Provide \hide and \omit functions for transparent and void glyphs (issue 6575048)

On 2012/10/03 19:32:15, pounderd_lineone.net wrote: >Original Message >From: mailto:d...@gnu.org >Call me an optimist, but I think we are good now. Apologies if this ship has sailed, but has anyone considered \suppress and \unsuppress? The ship has not sailed, but retailoring the

Re: Provide an \un function for turning overrides and sets into reverts and unsets (issue 6588067)

Reviewers: janek, Message: On 2012/10/05 14:46:09, janek wrote: please provide usage example(s). I suppose i like this idea, but without examples i don't know what exactly will be possible, and what won't be possible. Is it enough to say that after unHideNotes = \un\hideNotes oneVoice = \u

Re: Provide an \un function for turning overrides and sets into reverts and unsets (issue 6588067)

On 2012/10/06 07:44:51, Trevor Daniels wrote: I think I would prefer to name this function \undo. This more accurately expresses what it does: \undo\voiceOne reverses everything that \voiceOne does, or did. The action of \un\voiceOne is not so intuitively obvious, nor does it make an English wor

Re: convert-ly (issue 2670) (issue 6610058)

On 2012/10/08 04:58:06, janek wrote: http://codereview.appspot.com/6610058/diff/9001/scripts/convert-ly.py File scripts/convert-ly.py (right): http://codereview.appspot.com/6610058/diff/9001/scripts/convert-ly.py#newcode231 scripts/convert-ly.py:231: ly.progress (_ (u"Processing `%s\'... ") %

Re: convert-ly (issue 2670) (issue 6610058)

On 2012/10/08 20:08:20, Graham Percival wrote: The changelog says "Don't update \version when no rule is applied." That's what the existing -d --diff-version-update command does. No, that's what the existing -d --diff-version-update is supposed to do. The problem was that if the last applic

Re: Make arguments like Context.GrobName accessible as symbol lists (issue 6635050)

Reviewers: lemzwerg, Message: On 2012/10/09 05:04:50, lemzwerg wrote: LGTM, without testing, and without really understanding the change. However, simplifications and generalizations are always a good thing. http://codereview.appspot.com/6635050/diff/1/Documentation/de/notation/pitches.itel

Re: Make arguments like Context.GrobName accessible as symbol lists (issue 6635050)

On 2012/10/09 08:14:55, t.daniels_treda.co.uk wrote: : Tuesday, October 09, 2012 8:36 AM > so I'd crank open another convert-ly rule to turn those into > \accidentalStyle piano-cautionary > as well. Which makes for worse backward-compatibility of scores. > > What do people prefer to see? A

Re: Make arguments like Context.GrobName accessible as symbol lists (issue 6635050)

On 2012/10/09 10:03:59, t.daniels_treda.co.uk wrote: d...@gnu.org: Tuesday, October 09, 2012 9:38 AM > I think I'll prepare a radical convert-ly-only patch on top of this > patch series that demonstrates what "now valid" syntax we _could_ be > using/advertising as input if we wanted to. It'

Re: Make arguments like Context.GrobName accessible as symbol lists (issue 6635050)

http://codereview.appspot.com/6635050/diff/7002/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/6635050/diff/7002/ly/music-functions-init.ly#newcode105 ly/music-functions-init.ly:105: (ly:input-warning location (_ "not a spanner name, `~a'") name

Re: Make arguments like Context.GrobName accessible as symbol lists (issue 6635050)

On 2012/10/09 21:08:47, janek wrote: I'm just skimming the discussion (the patch is big and non-trivial, so i will have problems reviewing it), but i spotted one interesting sentence... On Tue, Oct 9, 2012 at 10:38 AM, wrote: > We can get rid of a _lot_ of #' style thing

Re: Make arguments like Context.GrobName accessible as symbol lists (issue 6635050)

http://codereview.appspot.com/6635050/diff/15002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6635050/diff/15002/Documentation/notation/changing-defaults.itely#newcode4202 Documentation/notation/changing

Re: Create \temporary for doing overrides without pop-first set (issue 6687044)

Reviewers: janek, Trevor Daniels, Message: On 2012/10/15 10:45:02, Trevor Daniels wrote: I'm not sure this is the right way to go. Here's my reasoning: a) Unifying the interface to context and grob properties seems to be a desirable long-term goal; at least several people have spoken in favou

Re: Create \temporary for doing overrides without pop-first set (issue 6687044)

On 2012/10/15 13:02:38, wl_gnu.org wrote: > Let's assume that we "unify" the interface to context and grob > properties. The _default_ operation on a context property will > _always_ be overwrite rather than push, since context properties > track the change of things like the current clef, the c

Re: Create \temporary for doing overrides without pop-first set (issue 6687044)

On 2012/10/15 14:03:07, janek wrote: On Mon, Oct 15, 2012 at 2:51 PM, wrote: > Let's assume that we "unify" the interface to context and grob > properties. The _default_ operation on a context property will > _always_ be overwrite rather than push, since context propert

Re: Create \temporary for doing overrides without pop-first set (issue 6687044)

http://codereview.appspot.com/6687044/diff/4001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/6687044/diff/4001/ly/music-functions-init.ly#newcode1250 ly/music-functions-init.ly:1250: @emph{corresponding} reverts in a stack-neutral manner. An

Re: Create \temporary for doing overrides without pop-first set (issue 6687044)

On 2012/10/15 14:46:50, Trevor Daniels wrote: On 2012/10/15 14:21:08, dak wrote: > But that does not mean that the default mode of setting a property > should be pushing. Why not? What harm will it do? A stack filled with garbage from pushes that happened without particular int

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

Reviewers: lemzwerg, Message: On 2012/10/23 11:19:59, lemzwerg wrote: LGTM. Any convert rules necessary? Well, I abolish list-or-symbol? here on the assumption that nobody used this peculiar and mostly ill-advised predicate. That is somewhat optimistic. Converting list-or-symbol? automatica

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

On 2012/10/23 19:05:09, marc wrote: Hey, that was quick! Thanks for solving this issue - LGTM! Well, there is no regtest and no documentation, so it is not like there is nothing left to do. And to be honest, the usual "to check this feature, you have used some code and could equally well turn

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

On 2012/10/24 09:58:12, janek wrote: LGTM shall the tracker issues "write doc for this" It is not as much "write doc for this" as the function itself has its docs updated. It is more "update the existing docs in the manual to reflect the change". and "add a regtest for this" be added now

Re: prevent collision of ligatures and next note (issue 6740046)

On 2012/10/24 10:36:52, benko.pal wrote: [...] > Ah, so this is a by-the-way fix. Can it be in a separate commit, please? it is; I meant to note it but forgot, sorry. is there interest in pushing such multi-commit patches to some dev branch? If there is, people should ask. Substructurin

Re: fix representation switching from line-position to staff-space (issue 6778050)

http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc File lily/breathing-sign.cc (left): http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc#oldcode88 lily/breathing-sign.cc:88: int const int_dim = (int) ydim[i]; On 2012/10/27 19:36:21, Keith wrote: If you w

Re: fix representation switching from line-position to staff-space (issue 6778050)

On 2012/10/27 20:34:35, benko.pal wrote: I want staves with line-positions like (-2 0 2 4) work. Why would somebody specify (-2 0 2 4) with the expectation that the results should be identical to (-3 -1 1 3)? Why would he not specify (-3 -1 1 3) in the first place then? How is something "wor

<    1   2   3   4   5   6   7   8   9   10   >