On 2012/08/21 12:08:16, dak wrote:
On 2012/08/21 11:57:45, Graham Percival wrote:
> LGTM, but two questions:
> 1) why should engravers have double-quotes?
Because the CG states so.
> Was it only working by accident
> before, or are you hoping to simplify the parser by no longer
accepting the
> non-quoted versions?
Neither. There are no plans to stop supporting underline-containing
unquoting
strings, and the recent change unifying string syntax across lexer
modes
reinforces this.
> 2) the patch title says "CG:", but this doesn't touch the CG.
But the CG touches the patch. Concretely, it states:
<URL:http://lilypond.org/doc/v2.15/Documentation/contributor/lilypond-formatting>
All engravers should have double-quotes around them:
\consists "Spans_arpeggio_engraver"
LilyPond does not strictly require this, but it is a useful convention
to
follow.
And this rule has been added to the policies by
commit a545fc2d47d53b0124f796d45def240e5f3834ab
Author: Graham Percival <gra...@percival-music.ca>
Date: Sat Mar 29 07:48:35 2008 -0700
Update policy.
http://codereview.appspot.com/6461098/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
