chia7712 merged PR #19301:
URL: https://github.com/apache/kafka/pull/19301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-19087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cheng Yi Chang reassigned KAFKA-19087:
--
Assignee: Cheng Yi Chang (was: Chia-Ping Tsai)
> Move TransactionState to transactio
chia7712 merged PR #19367:
URL: https://github.com/apache/kafka/pull/19367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
OmniaGM commented on PR #15968:
URL: https://github.com/apache/kafka/pull/15968#issuecomment-2778290434
> That's great, thanks!
@ijuma and @jolshan I fixed the conflicts now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
[
https://issues.apache.org/jira/browse/KAFKA-19087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940938#comment-17940938
]
Chia-Ping Tsai commented on KAFKA-19087:
Maybe we should consider leveraging `Tr
lucasbru commented on code in PR #19219:
URL: https://github.com/apache/kafka/pull/19219#discussion_r2028472624
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8148,7 +8174,10 @@ private TaskAssignor streamsGroupAssignor(St
Chia-Ping Tsai created KAFKA-19088:
--
Summary: Consider logging the unknownStateFilters when listing
transation ids
Key: KAFKA-19088
URL: https://issues.apache.org/jira/browse/KAFKA-19088
Project: Kaf
AndrewJSchofield merged PR #19328:
URL: https://github.com/apache/kafka/pull/19328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
[
https://issues.apache.org/jira/browse/KAFKA-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940959#comment-17940959
]
Jhen-Yung Hsu commented on KAFKA-19088:
---
Hi, I'm working on this, thanks. :)
> Co
[
https://issues.apache.org/jira/browse/KAFKA-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jhen-Yung Hsu reassigned KAFKA-19088:
-
Assignee: Jhen-Yung Hsu (was: Chia-Ping Tsai)
> Consider logging the unknownStateFilte
Andrew Schofield created KAFKA-19031:
Summary: Ensure brokers do not return null records in
ShareFetchResponse
Key: KAFKA-19031
URL: https://issues.apache.org/jira/browse/KAFKA-19031
Project: Kafk
OmniaGM commented on PR #15968:
URL: https://github.com/apache/kafka/pull/15968#issuecomment-2773053998
> @OmniaGM Would you like someone to help get this over the finish line?
I am nearly done with fixing the conflict should publish this this week.
sorry for late replay I have been a
sjhajharia commented on PR #19372:
URL: https://github.com/apache/kafka/pull/19372#issuecomment-2779234357
Thanks @m1a2st for the review.
I have addressed the comments and pushed a fresh commit. Pls review when
possible.
--
This is an automated message from the Apache Git Service.
To r
adixitconfluent commented on PR #19261:
URL: https://github.com/apache/kafka/pull/19261#issuecomment-2774680482
> Thanks for the updates. In general, I'm happy with the PR, with the
exception of the `filterRecordBatchesFromAcquiredRecords` method. It needs much
more comprehensive commenting
Abhinav Dixit created KAFKA-19085:
-
Summary: SharePartitionManagerTest
testMultipleConcurrentShareFetches throws silent exception and works incorrectly
Key: KAFKA-19085
URL: https://issues.apache.org/jira/browse/K
junrao commented on code in PR #19167:
URL: https://github.com/apache/kafka/pull/19167#discussion_r2025673505
##
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##
@@ -87,7 +87,7 @@ public FetchResponseData data() {
* We may also return INCONSIST
[
https://issues.apache.org/jira/browse/KAFKA-19066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940079#comment-17940079
]
Chia-Ping Tsai commented on KAFKA-19066:
related to https://github.com/apache/ka
Chia-Ping Tsai created KAFKA-19087:
--
Summary: Move TransactionState to transaction-coordinator module
Key: KAFKA-19087
URL: https://issues.apache.org/jira/browse/KAFKA-19087
Project: Kafka
I
chirag-wadhwa5 commented on PR #18976:
URL: https://github.com/apache/kafka/pull/18976#issuecomment-2778711584
Hi @AndrewJSchofield, I have resolved the conflicts. The PR is ready for
another round of review. Thanks !
--
This is an automated message from the Apache Git Service.
To respond
m1a2st commented on code in PR #19375:
URL: https://github.com/apache/kafka/pull/19375#discussion_r2028926018
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -147,7 +150,10 @@ class LogManagerTest {
assertEquals(1, logManager.liveLogDirs.size)
val log
frankvicky commented on code in PR #19376:
URL: https://github.com/apache/kafka/pull/19376#discussion_r2029040633
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {
cadonna opened a new pull request, #19377:
URL: https://github.com/apache/kafka/pull/19377
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some comm
trnguyencflt commented on code in PR #19353:
URL: https://github.com/apache/kafka/pull/19353#discussion_r2029055199
##
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##
@@ -51,8 +53,8 @@ final ByteBuffer serializeWithHeader(ResponseHeader header,
trnguyencflt commented on PR #19353:
URL: https://github.com/apache/kafka/pull/19353#issuecomment-2779128261
[nit] Please remove this block "Delete this text " from the description
of the PR.
Otherwise, LGTM
--
This is an automated message from the Apache Git Service.
To respon
[
https://issues.apache.org/jira/browse/KAFKA-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-19089:
--
Assignee: Chia-Ping Tsai
> Gradle :test task failing unexpectedly
> -
m1a2st opened a new pull request, #19375:
URL: https://github.com/apache/kafka/pull/19375
Some parameter is unused and fix assertion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lucasbru merged PR #19373:
URL: https://github.com/apache/kafka/pull/19373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
m1a2st commented on PR #19371:
URL: https://github.com/apache/kafka/pull/19371#issuecomment-2778790334
Hello @junrao, @chia7712
I have a question about this problem.
In
[[KAFKA-16368](https://github.com/apache/kafka/pull/18140/files)](https://github.com/apache/kafka/pull/18140/files),
TaiJuWu commented on code in PR #19357:
URL: https://github.com/apache/kafka/pull/19357#discussion_r2029013870
##
server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTest.java:
##
@@ -43,11 +52,15 @@ public class ShareFetchTest {
private static final String M
Parkerhiphop commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r2029035269
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
testWhenFetchResponseReturnsALeaderSh
Parkerhiphop commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r2029035269
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
testWhenFetchResponseReturnsALeaderSh
cadonna opened a new pull request, #19373:
URL: https://github.com/apache/kafka/pull/19373
With the Streams rebalance protocol, when the partition count
for changelog topics are computed the topic manager only
considers external source topics and throws if there are no
source topics
m1a2st commented on code in PR #19376:
URL: https://github.com/apache/kafka/pull/19376#discussion_r2029039303
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {
resp
Parkerhiphop opened a new pull request, #19376:
URL: https://github.com/apache/kafka/pull/19376
This is from [#16532's
comment](https://github.com/apache/kafka/pull/16532/files#r2028985028):
The forEach loop in the assertion will never execute because
`nonResponseData` is empty.
chia7712 commented on code in PR #19376:
URL: https://github.com/apache/kafka/pull/19376#discussion_r2029039198
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {
re
Parkerhiphop opened a new pull request, #19374:
URL: https://github.com/apache/kafka/pull/19374
As described in the JIRA ticket, controlPlaneRequestChannelOpt was removed
from KRaft mode, so there's no need to use the metrics prefix anymore.
This change removes `metricNamePrefix` from
FrankYang0529 commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r2028985028
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
testWhenFetchResponseReturnsALeaderS
FrankYang0529 commented on code in PR #19357:
URL: https://github.com/apache/kafka/pull/19357#discussion_r2028994700
##
server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTest.java:
##
@@ -43,11 +52,15 @@ public class ShareFetchTest {
private static final St
soarez merged PR #19351:
URL: https://github.com/apache/kafka/pull/19351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
m1a2st commented on code in PR #19372:
URL: https://github.com/apache/kafka/pull/19372#discussion_r2029065027
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -357,7 +356,7 @@ public CompletableFuture {
return isrSize == 0 && elrSize ==
Parkerhiphop commented on code in PR #19376:
URL: https://github.com/apache/kafka/pull/19376#discussion_r2029101369
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {
chia7712 merged PR #19365:
URL: https://github.com/apache/kafka/pull/19365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Parkerhiphop commented on code in PR #19376:
URL: https://github.com/apache/kafka/pull/19376#discussion_r2029102952
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {
chia7712 commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r2028993496
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
testWhenFetchResponseReturnsALeaderShipCh
David Arthur created KAFKA-19089:
Summary: Gradle :test task failing unexpectedly
Key: KAFKA-19089
URL: https://issues.apache.org/jira/browse/KAFKA-19089
Project: Kafka
Issue Type: Bug
mjsax merged PR #19218:
URL: https://github.com/apache/kafka/pull/19218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
frankvicky commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r2029109982
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java:
##
@@ -182,7 +181,7 @@ public NetworkClientDelegate.PollRe
kumarpritam863 commented on PR #19341:
URL: https://github.com/apache/kafka/pull/19341#issuecomment-2779267375
Hi @mimaison can you please review this. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
lucasbru merged PR #19360:
URL: https://github.com/apache/kafka/pull/19360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky commented on code in PR #19376:
URL: https://github.com/apache/kafka/pull/19376#discussion_r2029047826
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {
Parkerhiphop commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2028918289
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -349,8 +348,8 @@ class RequestChannel(val queueSize: Int,
private val requestQueue = new Arra
lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2028433315
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##
@@ -197,6 +197,13 @@ public static class DeadlineAndEpoch {
*
soondenana commented on code in PR #19353:
URL: https://github.com/apache/kafka/pull/19353#discussion_r2029166476
##
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##
@@ -51,8 +53,8 @@ final ByteBuffer serializeWithHeader(ResponseHeader header,
sh
AndrewJSchofield opened a new pull request, #19378:
URL: https://github.com/apache/kafka/pull/19378
This PR removes the unstable API flag for the KIP-932 RPCs.
The 4 RPCs which were exposed for the early access release in AK 4.0 are
stabilised at v1. This is because the RPCs have evol
[
https://issues.apache.org/jira/browse/KAFKA-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu updated KAFKA-19073:
---
Summary: Add Transactional ID pattern filter to ListTransactions API (was:
Add Transactional ID pre
[
https://issues.apache.org/jira/browse/KAFKA-18761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-18761.
--
Resolution: Fixed
> kafka-share-groups.sh --describe only shows offset information whe
[
https://issues.apache.org/jira/browse/KAFKA-18902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield reassigned KAFKA-18902:
Assignee: Shivsundar R (was: Andrew Schofield)
> Implement ShareConsumer option
[
https://issues.apache.org/jira/browse/KAFKA-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-19089:
-
Component/s: build
> Gradle :test task failing unexpectedly
> --
m1a2st commented on PR #19068:
URL: https://github.com/apache/kafka/pull/19068#issuecomment-2777484507
Thanks for @mimaison review, addressed all comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
TaiJuWu commented on code in PR #19286:
URL: https://github.com/apache/kafka/pull/19286#discussion_r2022590789
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -407,14 +413,17 @@ private void configureRLMM() {
rlmmProps.put(LOG_DIR_CONFIG, logDir);
ableegoldman commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r2025873637
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerHeartbeatRequestManager.java:
##
@@ -211,6 +214,28 @@ public ConsumerMembershipManager
adixitconfluent commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2022946269
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2484,6 +2504,205 @@ private long startOffsetDuringInitialization(long
partitionDataStartOf
frankvicky commented on code in PR #19167:
URL: https://github.com/apache/kafka/pull/19167#discussion_r2025822378
##
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##
@@ -87,7 +87,7 @@ public FetchResponseData data() {
* We may also return INCON
[
https://issues.apache.org/jira/browse/KAFKA-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937947#comment-17937947
]
David Jacot commented on KAFKA-19033:
-
I alraedy have a patch for it: https://github
[
https://issues.apache.org/jira/browse/KAFKA-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield reassigned KAFKA-18900:
Assignee: Shivsundar R (was: Andrew Schofield)
> Create a consumer config to sel
sjhajharia opened a new pull request, #19379:
URL: https://github.com/apache/kafka/pull/19379
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some c
sjhajharia closed pull request #19379: Cleanup core 2
URL: https://github.com/apache/kafka/pull/19379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: ji
Parkerhiphop commented on code in PR #19376:
URL: https://github.com/apache/kafka/pull/19376#discussion_r2029097843
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3663,8 +3663,7 @@ public void testFetcherDontCacheAnyData() {
TaiJuWu commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r2029018014
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3665,6 +3670,18 @@ public void
testWhenFetchResponseReturnsALeaderShipCha
[
https://issues.apache.org/jira/browse/KAFKA-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941041#comment-17941041
]
Justine Olshan commented on KAFKA-19079:
[~iamoshione]
KIP-890 is a kafka impr
[
https://issues.apache.org/jira/browse/KAFKA-15758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-15758:
--
Assignee: David Jacot
> Always schedule wrapped callbacks
>
[
https://issues.apache.org/jira/browse/KAFKA-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu updated KAFKA-19073:
---
Description:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1152%3A+Add+transactional+ID+patt
Yunyung commented on code in PR #19068:
URL: https://github.com/apache/kafka/pull/19068#discussion_r2029114746
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/server/quota/CustomQuotaCallbackTest.java:
##
@@ -121,4 +165,17 @@ public void configure(Map configs
chia7712 commented on PR #18828:
URL: https://github.com/apache/kafka/pull/18828#issuecomment-2765456093
> but we're facing an issue—PlainSaslServer can only pass the
authorizationID to the authorizer, meaning the client info is lost.
Have you considered implementing a custom `SaslSer
mimaison commented on code in PR #19285:
URL: https://github.com/apache/kafka/pull/19285#discussion_r2021190137
##
storage/src/main/java/org/apache/kafka/server/purgatory/DelayedRemoteListOffsets.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
frankvicky commented on code in PR #19223:
URL: https://github.com/apache/kafka/pull/19223#discussion_r2008619688
##
core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala:
##
@@ -1153,4 +1153,29 @@ class AbstractFetcherThreadTest {
assertTrue(fetcher.fetchSt
FrankYang0529 commented on code in PR #19227:
URL: https://github.com/apache/kafka/pull/19227#discussion_r2007370090
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -341,10 +341,10 @@ class KRaftMetadataCache(
Option(_currentImage.cluster.broke
github-actions[bot] commented on PR #18334:
URL: https://github.com/apache/kafka/pull/18334#issuecomment-2777485586
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
[
https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ranganath Samudrala updated KAFKA-19022:
Description:
While migrating Kafka from zookeeper to kraft, we see errors in logs
frankvicky commented on PR #19269:
URL: https://github.com/apache/kafka/pull/19269#issuecomment-2746260805
Hi @ableegoldman
This is a reimplementation of 18067.
Please take a look when you have a free moment.
Many thanks 🙇🏼
--
This is an automated message from the Apache Git Ser
mumrah opened a new pull request, #66:
URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/66
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod
tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam,
quis nostrud exercitation ullamco labo
mumrah commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2743749389
@ijuma I don't think GH will truncate the commit subject, but I'm not sure
-- I'll try it out on the sandbox repo.
It is _really_ annoying that we can't tweak the commit message with
mimaison commented on code in PR #19285:
URL: https://github.com/apache/kafka/pull/19285#discussion_r2029279945
##
storage/src/main/java/org/apache/kafka/server/purgatory/DelayedRemoteListOffsets.java:
##
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939732#comment-17939732
]
Donny Nadolny commented on KAFKA-19012:
---
> I know it's a long shot, but could we p
AndrewJSchofield commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2025141887
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3199,13 +3199,21 @@ class KafkaApis(val requestChannel: RequestChannel,
request.context.
squah-confluent opened a new pull request, #19333:
URL: https://github.com/apache/kafka/pull/19333
Previously in KAFKA-18484, we added exception handling for exceptions
coming from batch events. Also handle exceptions from 0-record write
events and transaction completion events.
-
chia7712 commented on code in PR #19284:
URL: https://github.com/apache/kafka/pull/19284#discussion_r2022952520
##
raft/src/main/java/org/apache/kafka/raft/ControlRecord.java:
##
@@ -80,20 +80,14 @@ public ControlRecordType type() {
}
public short version() {
Review
Tombert commented on code in PR #19366:
URL: https://github.com/apache/kafka/pull/19366#discussion_r2027527786
##
clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java:
##
@@ -34,6 +34,7 @@
* The callback may be executed in any thread calli
github-actions[bot] commented on PR #17978:
URL: https://github.com/apache/kafka/pull/17978#issuecomment-2763069973
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
m1a2st commented on PR #19068:
URL: https://github.com/apache/kafka/pull/19068#issuecomment-2766450546
Thanks for @mimaison review, all comments addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #18912:
URL: https://github.com/apache/kafka/pull/18912#issuecomment-2767974798
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
kirktrue commented on PR #17022:
URL: https://github.com/apache/kafka/pull/17022#issuecomment-2767367218
> I think the overall approach makes sense. But I would like to see some
tests to see if the issue is improved. If so the logging could also give us
some more insight.
The unit te
ShivsundarR commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r2012626389
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##
@@ -1223,21 +1343,15 @@ public void
testAcknowledgemen
junrao commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2029290363
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2484,6 +2505,182 @@ private long startOffsetDuringInitialization(long
partitionDataStartOffset) thr
chirag-wadhwa5 opened a new pull request, #19247:
URL: https://github.com/apache/kafka/pull/19247
This PR adds extra information in assertion failed messages for tests in
SharePartitionTest revolving around acquisition lock timeouts functionality.
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940056#comment-17940056
]
Chia-Ping Tsai commented on KAFKA-19065:
this ticket should include
https://git
frankvicky commented on PR #19235:
URL: https://github.com/apache/kafka/pull/19235#issuecomment-2735304675
It seems the gradle team is still working on it.
https://github.com/gradle/gradle/pull/32576
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang resolved KAFKA-19067.
---
Resolution: Won't Fix
> AsyncKafkaConsumer may return stale fetch result after seek operation
>
TaiJuWu commented on code in PR #19286:
URL: https://github.com/apache/kafka/pull/19286#discussion_r2027851831
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -413,24 +418,19 @@ void
testRemoteLogMetadataManagerWithEndpointConfigOverridden() throws IOExc
[
https://issues.apache.org/jira/browse/KAFKA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940838#comment-17940838
]
Justine Olshan commented on KAFKA-18042:
Hey [~taijuwu] if you would like to wor
101 - 200 of 239 matches
Mail list logo
