[jira] [Created] (KAFKA-19038) Migrate GroupAssignment to record class

2025-03-25 Thread TengYao Chi (Jira)
TengYao Chi created KAFKA-19038: --- Summary: Migrate GroupAssignment to record class Key: KAFKA-19038 URL: https://issues.apache.org/jira/browse/KAFKA-19038 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to client-integration-tests module

2025-03-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19042: -- Description: This is an umbrella Jira about moving integration tests from kafka.api module to client-

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-25 Thread via GitHub
mimaison commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2011895838 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogToClean.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to client-integration-tests module

2025-03-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19042: -- Description: This is an umbrella Jira about moving integration tests from kafka.api module to client-

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-25 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r2011815405 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,277 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18616; Refactor Tools's ApiMessageFormatter [kafka]

2025-03-25 Thread via GitHub
chia7712 commented on code in PR #18695: URL: https://github.com/apache/kafka/pull/18695#discussion_r2011905649 ## tools/src/test/java/org/apache/kafka/tools/consumer/CoordinatorRecordMessageFormatterTest.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] MINOR: add missing link for KIP-1104 [kafka]

2025-03-25 Thread via GitHub
chia7712 merged PR #19271: URL: https://github.com/apache/kafka/pull/19271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-6333 java.awt.headless should not be on commandline [kafka]

2025-03-25 Thread via GitHub
mimaison commented on code in PR #19237: URL: https://github.com/apache/kafka/pull/19237#discussion_r2011889803 ## core/src/main/scala/kafka/Kafka.scala: ## @@ -73,7 +73,7 @@ object Kafka extends Logging { try { val serverProps = getPropsFromArgs(args) val ser

[PR] KAFKA-19036: Rewrite LogAppendTimeTest and move it to storage module [kafka]

2025-03-25 Thread via GitHub
FrankYang0529 opened a new pull request, #19282: URL: https://github.com/apache/kafka/pull/19282 Use Java to rewrite `LogAppendTimeTest` by new test infra and move it to storage module. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] MINOR: add missing link for KIP-1104 [kafka]

2025-03-25 Thread via GitHub
FrankYang0529 commented on PR #19271: URL: https://github.com/apache/kafka/pull/19271#issuecomment-2751002790 @chia7712 Thanks for the review. Created a PR for kafka-site. Thanks. https://github.com/apache/kafka-site/pull/680 -- This is an automated message from the Apache Git Servi

[jira] [Resolved] (KAFKA-19040) Fail test BrokerApiVersionsCommandTest#testAdminSendNoBlock

2025-03-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-19040. - Resolution: Won't Fix This issue won't fix after test in different enviroment. > Fail test BrokerApiVersionsCom

Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

2025-03-25 Thread via GitHub
fvaleri commented on PR #19198: URL: https://github.com/apache/kafka/pull/19198#issuecomment-2750383015 @ijuma @jsancio @chia7712 what we want to do with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-18281: Kafka (3.9.0) is improperly validating non-advertised listeners for routable controller addresses [kafka]

2025-03-25 Thread via GitHub
chia7712 commented on code in PR #18387: URL: https://github.com/apache/kafka/pull/18387#discussion_r2011523341 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -519,29 +519,44 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) } def eff

[jira] [Commented] (KAFKA-18054) Automatically detect missed configs needed by a topology

2025-03-25 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938134#comment-17938134 ] Lorcan commented on KAFKA-18054: Hi [~cadonna], thanks for the additional insight. I th

[jira] [Created] (KAFKA-19037) Integrate consumer-side code with Streams

2025-03-25 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-19037: - Summary: Integrate consumer-side code with Streams Key: KAFKA-19037 URL: https://issues.apache.org/jira/browse/KAFKA-19037 Project: Kafka Issue Type: Sub-

Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

2025-03-25 Thread via GitHub
fvaleri commented on code in PR #19198: URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309 ## docs/upgrade.html: ## @@ -72,10 +72,8 @@ Upgrading Servers to 4.0.0 from brokers will be running the latest version and you can verify that the cluster's

[jira] [Resolved] (KAFKA-18736) Add Streams group heartbeat request manager

2025-03-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-18736. --- Resolution: Fixed > Add Streams group heartbeat request manager > --

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-25 Thread via GitHub
cadonna commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r2011701017 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,277 @@ private List fromShareGroupAssi

[PR] MINOR: Update .asf.yaml collaborators [kafka]

2025-03-25 Thread via GitHub
mimaison opened a new pull request, #19280: URL: https://github.com/apache/kafka/pull/19280 Update the collaborators following 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-25 Thread via GitHub
dajac opened a new pull request, #19281: URL: https://github.com/apache/kafka/pull/19281 This patch applies a few cleanups to uniformize how group coordinator's integration tests are setup. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (KAFKA-19039) The refresh_collaborators.py script messes .asf.yaml

2025-03-25 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-19039: -- Summary: The refresh_collaborators.py script messes .asf.yaml Key: KAFKA-19039 URL: https://issues.apache.org/jira/browse/KAFKA-19039 Project: Kafka Issu

Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

2025-03-25 Thread via GitHub
fvaleri commented on code in PR #19198: URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309 ## docs/upgrade.html: ## @@ -72,10 +72,8 @@ Upgrading Servers to 4.0.0 from brokers will be running the latest version and you can verify that the cluster's

Re: [PR] MINOR: Update .asf.yaml collaborators [kafka]

2025-03-25 Thread via GitHub
mimaison merged PR #19280: URL: https://github.com/apache/kafka/pull/19280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-19040) Fail test BrokerApiVersionsCommandTest#testAdminSendNoBlock

2025-03-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-19040: --- Assignee: 黃竣陽 > Fail test BrokerApiVersionsCommandTest#testAdminSendNoBlock > -

Re: [PR] KAFKA-19026: AlterConfigPolicy incompatibility between ZK mode and KR… [kafka]

2025-03-25 Thread via GitHub
edoardocomar commented on PR #19263: URL: https://github.com/apache/kafka/pull/19263#issuecomment-2750791901 I'd love to have this fix in 3.9.1 ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-25 Thread via GitHub
m1a2st commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2011458305 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Update .asf.yaml collaborators [kafka]

2025-03-25 Thread via GitHub
dajac commented on PR #19280: URL: https://github.com/apache/kafka/pull/19280#issuecomment-2750740211 Somehow, I was convinced that it was executed automatically now every quarter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] MINOR: Update .asf.yaml collaborators [kafka]

2025-03-25 Thread via GitHub
mimaison commented on PR #19280: URL: https://github.com/apache/kafka/pull/19280#issuecomment-2750730801 Also opened https://issues.apache.org/jira/browse/KAFKA-19039 as when I ran `refresh_collaborators.py` it made other changes to our `.asf.yaml` file. -- This is an automated message fr

[PR] MINOR: Move record helper methods out of CoordinatorRuntimeTest [kafka]

2025-03-25 Thread via GitHub
squah-confluent opened a new pull request, #19279: URL: https://github.com/apache/kafka/pull/19279 These methods are generally useful for constructing records in coordinator tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-19013 Reformat PR body to 72 characters [kafka]

2025-03-25 Thread via GitHub
dajac commented on PR #19242: URL: https://github.com/apache/kafka/pull/19242#issuecomment-2750756701 @mumrah I have noticed that it also breaks the `Reviewers` line. This will make listing commits reviewed by someone harder, doesn't it? I wonder whether we should also switch to using `Revi

[jira] [Created] (KAFKA-19041) Automatically run refresh_collaborators.py quarterly

2025-03-25 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-19041: -- Summary: Automatically run refresh_collaborators.py quarterly Key: KAFKA-19041 URL: https://issues.apache.org/jira/browse/KAFKA-19041 Project: Kafka Issu

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

2025-03-25 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938167#comment-17938167 ] Mickael Maison commented on KAFKA-14995: As far as I can tell this PR only added

Re: [PR] MINOR: Update .asf.yaml collaborators [kafka]

2025-03-25 Thread via GitHub
mimaison commented on PR #19280: URL: https://github.com/apache/kafka/pull/19280#issuecomment-2750771273 Opened https://issues.apache.org/jira/browse/KAFKA-19041 to try automating it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to client-integration-tests module

2025-03-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19042: -- Description: This is an umbrella Jira about moving integration tests from kafka.api module to client-

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-25 Thread via GitHub
junrao commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2012567540 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,793 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-03-25 Thread via GitHub
chia7712 commented on PR #19223: URL: https://github.com/apache/kafka/pull/19223#issuecomment-2752004577 > Could you provide a PR for the 3.9 and 4.0 branch as well? should we backport KAFKA-18723 first? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (KAFKA-18991) AbstractFetcherThread should verify the current leader epoch in the fetch request matches the leader epoch in the fetch state

2025-03-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18991: --- Fix Version/s: 4.1.0 > AbstractFetcherThread should verify the current leader epoch in the f

[PR] KAFKA-14523: Move DelayedRemoteListOffsets to the storage module [kafka]

2025-03-25 Thread via GitHub
mimaison opened a new pull request, #19285: URL: https://github.com/apache/kafka/pull/19285 Introduce an interface, PartitionChecker, to decouple RemoteLogManager and ReplicaManager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-25 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r2012387113 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1452,6 +1533,49 @@ private void throwIfShareGroupHeartbeatReque

[PR] MINOR: Cleanup Raft Module [kafka]

2025-03-25 Thread via GitHub
sjhajharia opened a new pull request, #19284: URL: https://github.com/apache/kafka/pull/19284 Given that now we support Java 17 on our brokers, this PR replace the use of the following in raft module: - Collections.singletonList() and Collections.emptyList() with List.of() - Collec

Re: [PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-25 Thread via GitHub
ShivsundarR commented on code in PR #19192: URL: https://github.com/apache/kafka/pull/19192#discussion_r2012623984 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java: ## @@ -1004,10 +1090,7 @@ public void testShareFetchWithS

Re: [PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-25 Thread via GitHub
ShivsundarR commented on code in PR #19192: URL: https://github.com/apache/kafka/pull/19192#discussion_r2012623532 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java: ## @@ -954,10 +1046,7 @@ public void testShareFetchWithSub

Re: [PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-25 Thread via GitHub
ShivsundarR commented on code in PR #19192: URL: https://github.com/apache/kafka/pull/19192#discussion_r2012625215 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java: ## @@ -1223,21 +1343,15 @@ public void testAcknowledgemen

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-03-25 Thread via GitHub
junrao commented on PR #19223: URL: https://github.com/apache/kafka/pull/19223#issuecomment-2752066965 > should we backport [KAFKA-18723](https://issues.apache.org/jira/browse/KAFKA-18723) first? The fixed version for KAFKA-18723 already includes 3.9.1 and 4.0.1? -- This is an auto

Re: [PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-25 Thread via GitHub
ShivsundarR commented on code in PR #19192: URL: https://github.com/apache/kafka/pull/19192#discussion_r2012627954 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java: ## @@ -457,9 +453,7 @@ public void testAcknowledgeOnClose(

Re: [PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-25 Thread via GitHub
ShivsundarR commented on code in PR #19192: URL: https://github.com/apache/kafka/pull/19192#discussion_r2012627441 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java: ## @@ -652,19 +633,15 @@ public void testBatchingAcknowled

Re: [PR] KAFKA-18914 Migrate ConsumerRebootstrapTest to use new test infra [kafka]

2025-03-25 Thread via GitHub
chia7712 merged PR #19154: URL: https://github.com/apache/kafka/pull/19154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-25 Thread via GitHub
chia7712 commented on code in PR #19213: URL: https://github.com/apache/kafka/pull/19213#discussion_r2007697849 ## tools/src/test/java/org/apache/kafka/tools/ClientMetricsCommandTest.java: ## @@ -156,6 +168,41 @@ public void testAlterGenerateName() { assertTrue(captured

[jira] [Created] (KAFKA-19045) ByteBufferUnmapper should not use the deprecated sun.misc.Unsafe#invokeCleaner()

2025-03-25 Thread Houston Putman (Jira)
Houston Putman created KAFKA-19045: -- Summary: ByteBufferUnmapper should not use the deprecated sun.misc.Unsafe#invokeCleaner() Key: KAFKA-19045 URL: https://issues.apache.org/jira/browse/KAFKA-19045

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to client-integration-tests module

2025-03-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19042: -- Description: This is an umbrella Jira about moving integration tests from kafka.api module to client-

Re: [PR] KAFKA-18981: Fix flaky QuorumControllerTest.testMinIsrUpdateWithElr [kafka]

2025-03-25 Thread via GitHub
mumrah commented on code in PR #19262: URL: https://github.com/apache/kafka/pull/19262#discussion_r2012156078 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -654,6 +658,19 @@ public void testMinIsrUpdateWithElr() throws Throwable {

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-25 Thread via GitHub
cadonna commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r2012101803 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,277 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-25 Thread via GitHub
cadonna commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r2012101803 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1805,6 +1990,277 @@ private List fromShareGroupAssi

Re: [PR] KAFKA-18981: Fix flaky QuorumControllerTest.testMinIsrUpdateWithElr [kafka]

2025-03-25 Thread via GitHub
FrankYang0529 commented on code in PR #19262: URL: https://github.com/apache/kafka/pull/19262#discussion_r2012174856 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -654,6 +658,19 @@ public void testMinIsrUpdateWithElr() throws Throwable {

[PR] KAFKA-19042: [1/N] Move ConsumerTopicCreationTest to client-integration-tests module [kafka]

2025-03-25 Thread via GitHub
frankvicky opened a new pull request, #19283: URL: https://github.com/apache/kafka/pull/19283 JIRA: KAFKA-19042 This patch moves `ConsumerTopicCreationTest` to the `client-integration-tests` and rewrite it as Java. The patch also streamlines the test flow. In the Scala version,

[jira] [Created] (KAFKA-19043) Move DelayedRemoteListOffsets to the storage module

2025-03-25 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-19043: -- Summary: Move DelayedRemoteListOffsets to the storage module Key: KAFKA-19043 URL: https://issues.apache.org/jira/browse/KAFKA-19043 Project: Kafka Issue

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-03-25 Thread via GitHub
mimaison commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2012290418 ## server-common/src/main/java/org/apache/kafka/server/common/DelayedDeleteRecords.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-25 Thread via GitHub
jsancio commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r2012339800 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first,

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-25 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r2012357466 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1452,6 +1533,49 @@ private void throwIfShareGroupHeartbeatReque

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-03-25 Thread via GitHub
junrao merged PR #19223: URL: https://github.com/apache/kafka/pull/19223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Commented] (KAFKA-19045) ByteBufferUnmapper should not use the deprecated sun.misc.Unsafe#invokeCleaner()

2025-03-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938275#comment-17938275 ] Ismael Juma commented on KAFKA-19045: - Thanks for filing the ticket. Moving to the F

[jira] [Commented] (KAFKA-19045) ByteBufferUnmapper should not use the deprecated sun.misc.Unsafe#invokeCleaner()

2025-03-25 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938276#comment-17938276 ] Houston Putman commented on KAFKA-19045: I'm testing with a preview version of J

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-03-25 Thread via GitHub
junrao commented on PR #19223: URL: https://github.com/apache/kafka/pull/19223#issuecomment-2751810808 @frankvicky : Could you provide a PR for the 3.9 and 4.0 branch as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [MINOR] Cleanup Storage Module [kafka]

2025-03-25 Thread via GitHub
sjhajharia commented on PR #19072: URL: https://github.com/apache/kafka/pull/19072#issuecomment-2750323406 hey @chia7712 can you please take a lot at this PR when possible. TIA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (KAFKA-18768) Backport KAFKA-806 to 4.0

2025-03-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18768. Resolution: Fixed https://github.com/apache/kafka/commit/4dd893ba212d05fb2201d884d962f0c0f

[jira] [Commented] (KAFKA-18981) Fix flaky QuorumControllerTest.testMinIsrUpdateWithElr

2025-03-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937328#comment-17937328 ] PoAn Yang commented on KAFKA-18981: --- The root cause of this flaky test is that: if bro

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-03-25 Thread via GitHub
mimaison commented on code in PR #18930: URL: https://github.com/apache/kafka/pull/18930#discussion_r2011825612 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java: ## @@ -320,6 +321,10 @@ String entityLabel() { in(Util

[jira] [Created] (KAFKA-19042) Move kafka.api test cases to client-integration-tests module

2025-03-25 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-19042: - Summary: Move kafka.api test cases to client-integration-tests module Key: KAFKA-19042 URL: https://issues.apache.org/jira/browse/KAFKA-19042 Project: Kafka Issue

[jira] [Created] (KAFKA-19040) Fail test BrokerApiVersionsCommandTest#testAdminSendNoBlock

2025-03-25 Thread Jira
黃竣陽 created KAFKA-19040: --- Summary: Fail test BrokerApiVersionsCommandTest#testAdminSendNoBlock Key: KAFKA-19040 URL: https://issues.apache.org/jira/browse/KAFKA-19040 Project: Kafka Issue Type: Test

Re: [PR] MINOR: Move record helper methods out of CoordinatorRuntimeTest [kafka]

2025-03-25 Thread via GitHub
dajac merged PR #19279: URL: https://github.com/apache/kafka/pull/19279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18607: Update jfreechart dependency [kafka]

2025-03-25 Thread via GitHub
mimaison commented on PR #19074: URL: https://github.com/apache/kafka/pull/19074#issuecomment-2750868800 Thanks @mingdaoy for the PR. Have you been able to run the `ReplicationQuotasTestRig` tool and verify it still generates a graph? -- This is an automated message from the Apache Git S

Re: [PR] KAFKA-18842: add configurable max number of connectors [kafka]

2025-03-25 Thread via GitHub
mimaison commented on PR #18993: URL: https://github.com/apache/kafka/pull/18993#issuecomment-2750876431 Thanks for the PR. To add new configurations we need a Kafka Improvement Proposal (KIP). You can find the process to create a KIP in https://cwiki.apache.org/confluence/display/KAFKA/Kaf

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to client-integration-tests module

2025-03-25 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19042: -- Description: This is an umbrella Jira about moving integration tests from kafka.api module to client-

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to client-integration-tests module

2025-03-25 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu updated KAFKA-19042: -- Description: This is an umbrella Jira about moving integration tests from kafka.api module to

Re: [PR] MINOR: add missing link for KIP-1104 [kafka]

2025-03-25 Thread via GitHub
chia7712 commented on PR #19271: URL: https://github.com/apache/kafka/pull/19271#issuecomment-2750981943 @FrankYang0529 please fix kafka-site too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (KAFKA-19026) AlterConfigPolicy incompatibility between ZK mode and KRaft mode when using AlterConfigOp.OpType.SUBTRACT

2025-03-25 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-19026: -- Attachment: KAFKA19026Test-1.java > AlterConfigPolicy incompatibility between ZK mode and KRaf

[PR] MINOR: Remove stray printStackTrace in RequestConvertToJsonTest [kafka]

2025-03-25 Thread via GitHub
ijuma opened a new pull request, #19287: URL: https://github.com/apache/kafka/pull/19287 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] KAFKA-19013 Reformat PR body to 72 characters [kafka]

2025-03-25 Thread via GitHub
mumrah commented on PR #19242: URL: https://github.com/apache/kafka/pull/19242#issuecomment-2752805699 I started a DISCUSS thread about this cc @ijuma @dajac @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Updated] (KAFKA-19040) Fail test BrokerApiVersionsCommandTest#testAdminSendNoBlock

2025-03-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-19040: Priority: Minor (was: Major) > Fail test BrokerApiVersionsCommandTest#testAdminSendNoBlock >

Re: [PR] Update readme [kafka-merge-queue-sandbox]

2025-03-25 Thread via GitHub
mumrah merged PR #69: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] KAFKA-19008 Remove scala version from artifacts [kafka]

2025-03-25 Thread via GitHub
chia7712 commented on PR #19241: URL: https://github.com/apache/kafka/pull/19241#issuecomment-2752098163 @m1a2st in the e2e, we usually add "scala version" to the download url. should we fix them also? https://github.com/apache/kafka/blob/trunk/vagrant/base.sh#L72 -- This is an aut

[jira] [Resolved] (KAFKA-18914) Migrate ConsumerRebootstrapTest to use new test infra

2025-03-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18914. Fix Version/s: 4.1.0 Resolution: Fixed > Migrate ConsumerRebootstrapTest to use new

Re: [PR] [WIP]KAFKA-18960: The default type of ssh key used by vagrant is disabled … [kafka]

2025-03-25 Thread via GitHub
apalan60 commented on PR #19264: URL: https://github.com/apache/kafka/pull/19264#issuecomment-2752831655 Due to the limitations of my local hardware resources, I wasn't able to run all the tests. For now, I've selected and run multiple tests from different modules to verify that the adjuste

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-25 Thread via GitHub
wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2012948501 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,793 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Created] (KAFKA-19044) Handle tasks that are not present in the current topology

2025-03-25 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19044: -- Summary: Handle tasks that are not present in the current topology Key: KAFKA-19044 URL: https://issues.apache.org/jira/browse/KAFKA-19044 Project: Kafka

[PR] (WIP) KAFKA-18891: Add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-03-25 Thread via GitHub
TaiJuWu opened a new pull request, #19286: URL: https://github.com/apache/kafka/pull/19286 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

Re: [PR] KAFKA-18899: Improve handling of timeouts for commitAsync() in ShareConsumer. [kafka]

2025-03-25 Thread via GitHub
ShivsundarR commented on code in PR #19192: URL: https://github.com/apache/kafka/pull/19192#discussion_r2012630742 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -1242,6 +1271,10 @@ void processingComplete() {

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-25 Thread via GitHub
soondenana commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r2012740807 ## clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java: ## @@ -204,13 +204,17 @@ public static boolean compareRawTaggedFields(List first,

Re: [PR] KAFKA-19013 Reformat PR body to 72 characters [kafka]

2025-03-25 Thread via GitHub
mumrah commented on PR #19242: URL: https://github.com/apache/kafka/pull/19242#issuecomment-2752507990 @dajac yes that's right. We can see that GH happily breaks existing trailers with it's auto-reformatting https://github.com/apache/kafka-merge-queue-sandbox/commit/27183691c299612a6f3d50a8

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-25 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2012532595 ## server-common/src/main/java/org/apache/kafka/server/storage/log/FetchIsolation.java: ## @@ -25,11 +25,11 @@ public enum FetchIsolation { TXN_COMMITTED;

[PR] Update readme [kafka-merge-queue-sandbox]

2025-03-25 Thread via GitHub
mumrah opened a new pull request, #69: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/69 Here is the PR description Reviewers: David Arthur , David Arthur , David Arthur -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-25 Thread via GitHub
wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2012561038 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogToClean.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-25 Thread via GitHub
cadonna commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r2012130909 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1452,6 +1533,49 @@ private void throwIfShareGroupHeartbeatReques

[jira] [Assigned] (KAFKA-18989) Optimize FileRecord#searchForOffsetWithSize

2025-03-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18989: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > Optimize FileRecord#searchForOffsetWithSize >

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-25 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013434152 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOff

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-25 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013463435 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -104,7 +104,8 @@ class KafkaApis(val requestChannel: RequestChannel, time: Time,

Re: [PR] KAFKA-6333 java.awt.headless should not be on commandline [kafka]

2025-03-25 Thread via GitHub
jack5505 commented on code in PR #19237: URL: https://github.com/apache/kafka/pull/19237#discussion_r2013316960 ## core/src/main/scala/kafka/Kafka.scala: ## @@ -73,7 +73,7 @@ object Kafka extends Logging { try { val serverProps = getPropsFromArgs(args) val ser

Re: [PR] [WIP]KAFKA-19000 Flaky test report should use absolute time for links [kafka]

2025-03-25 Thread via GitHub
github-actions[bot] commented on PR #19228: URL: https://github.com/apache/kafka/pull/19228#issuecomment-2753137811 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Add FunctionalInterface Annotation to most of the interfaces primarily used by Lambdas [kafka]

2025-03-25 Thread via GitHub
github-actions[bot] commented on PR #19234: URL: https://github.com/apache/kafka/pull/19234#issuecomment-2753137771 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-03-25 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2753137796 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

  1   2   >