mimaison commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2011895838
########## storage/src/main/java/org/apache/kafka/storage/internals/log/LogToClean.java: ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.storage.internals.log; + +import org.apache.kafka.common.TopicPartition; + +import java.util.Map; +import java.util.Objects; + +/** + * Helper class for a log, its topic/partition, the first cleanable position, the first uncleanable dirty position, + * and whether it needs compaction immediately. + */ +public final class LogToClean implements Comparable<LogToClean> { + private final TopicPartition topicPartition; + private final UnifiedLog log; + private final long firstDirtyOffset; + private final boolean needCompactionNow; + private final long cleanBytes; + private final long firstUncleanableOffset; + private final long cleanableBytes; + private final long totalBytes; + private final double cleanableRatio; + + public LogToClean(UnifiedLog log, long firstDirtyOffset, long uncleanableOffset, boolean needCompactionNow) { + this.log = Objects.requireNonNull(log, "log must not be null"); + this.topicPartition = Objects.requireNonNull(log.topicPartition(), "topicPartition must not be null"); Review Comment: Same for `log` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
