mumrah commented on code in PR #19262:
URL: https://github.com/apache/kafka/pull/19262#discussion_r2012156078
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -654,6 +658,19 @@ public void testMinIsrUpdateWithElr() throws Throwable {
// Unfence all brokers and create a topic foo (min ISR 2)
sendBrokerHeartbeatToUnfenceBrokers(active, allBrokers,
brokerEpochs);
+ AtomicBoolean onlyKeepUnfenced = new AtomicBoolean(false);
+ exec.scheduleAtFixedRate(() -> {
Review Comment:
What was the underlying problem with sending the heartbeat sync'ly
throughout the test? Was it a timing issue or some kind of race?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
