cadonna commented on code in PR #19114:
URL: https://github.com/apache/kafka/pull/19114#discussion_r2012130909
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1452,6 +1533,49 @@ private void throwIfShareGroupHeartbeatRequestIsInvalid(
}
}
+ /**
+ * Validates the request.
+ *
+ * @param request The request to validate.
+ * @throws InvalidRequestException if the request is not valid.
+ * @throws UnsupportedAssignorException if the assignor is not supported.
+ */
+ private static void throwIfStreamsGroupHeartbeatRequestIsInvalid(
Review Comment:
I agree on the "not adding now part". I do not completely understand the
"topology updating" part. We can still perform this check for the current
topology epoch, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
