ShivsundarR commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r2012623984
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##########
@@ -1004,10 +1090,7 @@ public void
testShareFetchWithSubscriptionChangeMultipleNodes() {
networkClientDelegate.poll(time.timer(0));
assertTrue(shareConsumeRequestManager.hasCompletedFetches());
- Acknowledgements acknowledgements = Acknowledgements.empty();
- acknowledgements.add(0L, AcknowledgeType.ACCEPT);
- acknowledgements.add(1L, AcknowledgeType.RELEASE);
- acknowledgements.add(2L, AcknowledgeType.ACCEPT);
+ Acknowledgements acknowledgements = getAcknowledgements(0,
AcknowledgeType.ACCEPT, AcknowledgeType.ACCEPT, AcknowledgeType.REJECT);
Review Comment:
Thanks, I have restored it back to ACCEPT, RELEASE, ACCEPT now. Missed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
