jsancio commented on code in PR #19163:
URL: https://github.com/apache/kafka/pull/19163#discussion_r2012339800
##########
clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java:
##########
@@ -204,13 +204,17 @@ public static boolean
compareRawTaggedFields(List<RawTaggedField> first,
}
}
- public static ByteBuffer toByteBuffer(final Message message, final short
version) {
+ public static ByteBufferAccessor toReadable(final Message message, final
short version) {
ObjectSerializationCache cache = new ObjectSerializationCache();
int messageSize = message.size(cache, version);
ByteBufferAccessor bytes = new
ByteBufferAccessor(ByteBuffer.allocate(messageSize));
message.write(bytes, cache, version);
bytes.flip();
- return bytes.buffer();
+ return bytes;
+ }
+
+ public static ByteBuffer toByteBuffer(final Message message, final short
version) {
Review Comment:
I agree with @artemlivshits . Why not just remove this method? Any code that
wants access to the byte buffer can just call `toReadable(message,
version).buffer()`.
##########
clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java:
##########
@@ -204,13 +204,17 @@ public static boolean
compareRawTaggedFields(List<RawTaggedField> first,
}
}
- public static ByteBuffer toByteBuffer(final Message message, final short
version) {
+ public static ByteBufferAccessor toReadable(final Message message, final
short version) {
Review Comment:
How about name this `toByteBufferAccessor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
