fvaleri commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309
##########
docs/upgrade.html:
##########
@@ -72,10 +72,8 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading
Servers to 4.0.0 from
brokers will be running the latest version and you can verify that the
cluster's behavior and performance meet expectations.
</li>
<li>Once the cluster's behavior and performance have been verified,
finalize the upgrade by running
- <code>
- bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade
--release-version 4.0
- </code>
- </li>
+ <code>bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade
--release-version 4.0</code>
+ (use <code>--bootstrap-controller</code> when running against a
controller node).</li>
Review Comment:
@jsancio thanks for your feedback. Effectively I was laser focused on this
use case, and forgot to look at the extended documentation. I noticed that all
the other documented commands don't have `--bootstrap-broker` or
`--bootstrap-controller`, so I think we should follow the same approach here,
for consistency. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
