ShivsundarR commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r2012627954
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##########
@@ -457,9 +453,7 @@ public void testAcknowledgeOnClose() {
shareConsumeRequestManager.fetch(Map.of(tip0, new
NodeAcknowledgements(0, acknowledgements)));
// Remaining acknowledgements sent with close().
- Acknowledgements acknowledgements2 = Acknowledgements.empty();
- acknowledgements2.add(2L, AcknowledgeType.ACCEPT);
- acknowledgements2.add(3L, AcknowledgeType.REJECT);
+ Acknowledgements acknowledgements2 = getAcknowledgements(2,
AcknowledgeType.ACCEPT, AcknowledgeType.ACCEPT, AcknowledgeType.REJECT);
Review Comment:
Thanks, I had added an extra, I have updated the PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
