ijuma commented on pull request #9159:
URL: https://github.com/apache/kafka/pull/9159#issuecomment-671772453
Thanks for the PR. I think we'd prefer to avoid having this as a compile
time dependency. @cmccabe was working on an alternative approach.
-
ijuma commented on pull request #9155:
URL: https://github.com/apache/kafka/pull/9155#issuecomment-671772900
I fixed the commit message too before merging, so no worries. :)
This is an automated message from the Apache Git Se
RamanVerma commented on a change in pull request #9112:
URL: https://github.com/apache/kafka/pull/9112#discussion_r468377991
##
File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala
##
@@ -229,7 +205,7 @@ class MetadataCacheTest {
tombentley commented on a change in pull request #9136:
URL: https://github.com/apache/kafka/pull/9136#discussion_r468389851
##
File path:
clients/src/main/java/org/apache/kafka/common/config/provider/DirectoryConfigProvider.java
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Ap
urbandan commented on pull request #8123:
URL: https://github.com/apache/kafka/pull/8123#issuecomment-671794441
Hi, are there any plans on merging this PR?
I'm working on
[KIP-635](https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+
ijuma commented on pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#issuecomment-671832339
@omkreddy this is ready for review.
This is an automated message from the Apache Git Service.
To respond to the mess
ijuma opened a new pull request #9160:
URL: https://github.com/apache/kafka/pull/9160
A couple of important bug fixes affecting Scala compilation are the main
driver:
* https://github.com/gradle/gradle/issues/13224
* https://github.com/gradle/gradle/issues/13392
Full release no
sebastien diaz created KAFKA-10385:
--
Summary: When DetailStat activated Final Print is necessary when
result is out of time.
Key: KAFKA-10385
URL: https://issues.apache.org/jira/browse/KAFKA-10385
Pr
sebadiaz opened a new pull request #9161:
URL: https://github.com/apache/kafka/pull/9161
if (currentTimeMillis - lastReportTime >= config.reportingInterval) {
--
This is an automated message from the Apache
jeqo commented on a change in pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#discussion_r468589037
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyKeyValueStore.java
##
@@ -38,35 +38,68 @@
*
* @param key The key to fet
jeqo commented on a change in pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#discussion_r468589324
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/BytesRangeValidator.java
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Softw
jeqo commented on a change in pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#discussion_r468590167
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractMergedSortedCacheStoreIterator.java
##
@@ -136,14 +151,26 @@ public K pee
jeqo commented on a change in pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#discussion_r468594243
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
##
@@ -310,12 +421,11 @@ public synchronized void close()
rajinisivaram commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468632388
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable thro
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r468653951
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java
##
@@ -0,0 +1,387 @@
+/*
+ * Licensed to t
lbradstreet commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r468658313
##
File path: README.md
##
@@ -199,6 +199,27 @@ You can run spotbugs using:
The spotbugs warnings will be found in `reports/spotbugs/main.html` and
`r
lbradstreet commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r468661509
##
File path: README.md
##
@@ -199,6 +199,27 @@ You can run spotbugs using:
The spotbugs warnings will be found in `reports/spotbugs/main.html` and
`r
chia7712 opened a new pull request #9162:
URL: https://github.com/apache/kafka/pull/9162
scala throws and then catches ```NonLocalReturnException``` to implement the
control flow of returning from a nested anonymous function. That is
anti-pattern and we should avoid using it in the hot met
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r468690429
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java
##
@@ -0,0 +1,387 @@
+/*
+ * Licensed to t
[
https://issues.apache.org/jira/browse/KAFKA-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175662#comment-17175662
]
Boyang Chen commented on KAFKA-9007:
[https://builds.apache.org/job/kafka-pr-jdk8-sca
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672044991
2/3 with one flaky test
This is an automated message from the Apache Git Service.
To respond to the message, plea
abbccdda commented on a change in pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#discussion_r468693036
##
File path:
clients/src/main/java/org/apache/kafka/common/internals/InvalidProducerEpochException.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apach
abbccdda commented on a change in pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#discussion_r468694089
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -539,7 +539,7 @@ class TransactionCoordinator(brokerId:
Jason Gustafson created KAFKA-10386:
---
Summary: Fix record serialization with flexible versions
Key: KAFKA-10386
URL: https://issues.apache.org/jira/browse/KAFKA-10386
Project: Kafka
Issue T
abbccdda commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-672053206
@mimaison Will take a look this week, thanks!
This is an automated message from the Apache Git Service.
To respon
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen reassigned KAFKA-10284:
---
Assignee: (was: Boyang Chen)
> Group membership update due to static member rejoin shou
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10284:
Labels: help-wanted (was: )
> Group membership update due to static member rejoin should be persi
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175669#comment-17175669
]
Boyang Chen commented on KAFKA-10284:
-
Resign from this ticket for now, others feel
ijuma commented on pull request #9160:
URL: https://github.com/apache/kafka/pull/9160#issuecomment-672066397
1 job passed, 2 failed with a single unrelated flaky test failure:
```
kafka.api.ConsumerBounceTest.testClose
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrat
ijuma merged pull request #9160:
URL: https://github.com/apache/kafka/pull/9160
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hachikuji opened a new pull request #9163:
URL: https://github.com/apache/kafka/pull/9163
This patch fixes the generated serde logic for the 'records' type so that it
uses the compact byte array representation consistently when flexible versions
are enabled.
### Committer Checklist
vvcephei commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468713975
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -204,17 +204,17 @@ private void maybeSetUpStatistics(
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468736687
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -721,6 +730,11 @@ protected Node curNode() {
r
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468738156
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -1295,7 +1309,7 @@ private void processRequests() {
rondagostino commented on pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#issuecomment-672110976
@cmccabe and @rajinisivaram Thanks for the reviews. I think this is where
we stand:
1. I removed `-1` as a valid `iterations` value in the code. I will need to
annou
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468742346
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -2739,8 +2753,8 @@ private void
rescheduleFindCoordinatorT
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468746415
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
##
@@ -70,7 +70,7 @@
private boolean shouldRebalance;
hachikuji opened a new pull request #9164:
URL: https://github.com/apache/kafka/pull/9164
This patch removes the `PartitionHeader` grouping from the `Fetch` response.
With old versions of the protocol, there was no cost for this grouping, but
once we add flexible version support, then it a
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468756144
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -814,10 +821,10 @@ private void validateOffsetsAsync(Ma
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468756144
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -814,10 +821,10 @@ private void validateOffsetsAsync(Ma
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468757303
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1303,6 +1311,10 @@ boolean isRetry() {
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468758893
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1114,7 +1119,7 @@ private boolean
maybeTer
hachikuji commented on a change in pull request #9112:
URL: https://github.com/apache/kafka/pull/9112#discussion_r468761215
##
File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala
##
@@ -187,49 +191,24 @@ class MetadataCacheTest {
new UpdateMetadataBr
abbccdda commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r468735528
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -4068,6 +4093,58 @@ public void testListOffsetsMetadata
vvcephei opened a new pull request #9165:
URL: https://github.com/apache/kafka/pull/9165
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
guozhangwang commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468775002
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorCon
[
https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175767#comment-17175767
]
Marco Lotz commented on KAFKA-10383:
Cool! That's also a feasible approach - if havi
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468780454
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -49,6 +59,30 @@
this.stateDirectory
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468781264
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -93,9 +90,7 @@ public boolean isActive() {
Arjun Satish created KAFKA-10387:
Summary: Cannot include SMT configs with source connector that
include topic.creation.* properties
Key: KAFKA-10387
URL: https://issues.apache.org/jira/browse/KAFKA-10387
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Description:
Let's say we try to create a connector with the following config:
{{
{
"connecto
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Description:
Let's say we try to create a connector with the following config:
{{{
"connector
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Description:
Let's say we try to create a connector with the following config:
{code:java}
{
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Description:
Let's say we try to create a connector with the following config:
{code:java}
{
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arjun Satish updated KAFKA-10387:
-
Summary: Cannot include SMT configs with source connector that uses
topic.creation.* properties
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468793170
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java
##
@@ -207,15 +207,25 @@ public void
shouldFlus
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468796183
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##
@@ -1259,13 +1262,47 @@ public void shouldReIn
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468796333
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorContext
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r468796354
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java
##
@@ -0,0 +1,387 @@
+/*
+ * Licensed to t
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r468799847
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##
@@ -1458,50 +1498,91 @@ public void shouldThro
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468802841
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -204,17 +204,17 @@ private void maybeSetUpStatistics(f
mumrah commented on pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#issuecomment-672203738
Here are some results from the new JMH added:
```
KAFKA-8806:
Benchmark (partitionCount)
(topicCount) Mode Cnt
mumrah edited a comment on pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#issuecomment-672203738
Here are some results from the new JMH added (note that the units are
milliseconds)
```
KAFKA-8806:
Benchmark
ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r468814368
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java
##
@@ -0,0 +1,387 @@
+/*
+ * Licens
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468824804
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1215,6 +1220,8 @@ private void completeTran
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468829772
##
File path: core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala
##
@@ -281,8 +281,7 @@ object BrokerApiVersionsCommand {
val logContext
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468830657
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMember.java
##
@@ -105,7 +105,7 @@ public WorkerGroupM
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468832838
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -553,7 +558,11 @@ private KafkaAdminClient(AdminClientConfi
vvcephei commented on pull request #9165:
URL: https://github.com/apache/kafka/pull/9165#issuecomment-672257710
I tested this locally by running `./gradlew clean systemTestLibs` and also:
```
TC_PATHS="tests/kafkatest/tests/streams/streams_application_upgrade_test.py::StreamsUpgradeTe
vvcephei merged pull request #9165:
URL: https://github.com/apache/kafka/pull/9165
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468840231
##
File path:
clients/src/main/java/org/apache/kafka/common/network/KafkaChannel.java
##
@@ -147,6 +153,7 @@ public KafkaChannel(String id, TransportLayer
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468840712
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java
##
@@ -42,6 +44,8 @@
* @param clientId The client ID to use for the he
abbccdda commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468834973
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##
@@ -528,13 +529,56 @@ public synchronized StreamsBuilder addStateStore(
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468841223
##
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##
@@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,
Abstra
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468841825
##
File path:
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java
##
@@ -69,4 +69,11 @@
* Returns the correlatio
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468842602
##
File path: core/src/main/scala/kafka/network/RequestChannel.scala
##
@@ -309,7 +309,10 @@ object RequestChannel extends Logging {
}
}
-class Reques
Jason Gustafson created KAFKA-10388:
---
Summary: Casting errors in tagged struct conversion
Key: KAFKA-10388
URL: https://issues.apache.org/jira/browse/KAFKA-10388
Project: Kafka
Issue Type:
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468843129
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -88,15 +88,17 @@ class SocketServer(val config: KafkaConfig,
private val memoryP
abbccdda commented on pull request #9158:
URL: https://github.com/apache/kafka/pull/9158#issuecomment-672261138
test this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
cmccabe commented on pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#issuecomment-672261745
We should also have a test of the privileged listener logic, to ensure that
the right listeners are privileged in various configurations (not sure what
junit test file that could
ableegoldman commented on a change in pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#discussion_r468843465
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDbIterator.java
##
@@ -58,7 +61,8 @@ public synchronized boolean has
[
https://issues.apache.org/jira/browse/KAFKA-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175833#comment-17175833
]
Josh Chan commented on KAFKA-9328:
--
By main docs are you referring to: [https://kafka.ap
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468871225
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##
@@ -528,13 +529,56 @@ public synchronized StreamsBuilder addStateStore(
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468871453
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1214,6 +1215,64 @@ default AlterClientQuotasResult
alterClientQuotas(C
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468871887
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1214,6 +1215,64 @@ default AlterClientQuotasResult
alterClientQuotas(C
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468872295
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -532,14 +539,14 @@ public final void a
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468872733
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apac
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468873428
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468873464
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java
##
@@ -54,7 +54,19 @@
private Sensor createSensor
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468874664
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468876395
##
File path:
core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala
##
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foun
[
https://issues.apache.org/jira/browse/KAFKA-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis reassigned KAFKA-10387:
--
Assignee: Konstantine Karantasis
> Cannot include SMT configs with so
ijuma commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672294145
Are we using `return` inside an anonymous function here?
This is an automated message from the Apache Git Service.
T
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468881832
##
File path:
core/src/test/scala/unit/kafka/server/DescribeUserScramCredentialsRequestTest.scala
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Softw
ijuma commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672294311
Ah, is `maybeHandleIOException` the issue?
This is an automated message from the Apache Git Service.
To respond to t
ijuma commented on a change in pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#discussion_r468882551
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1501,43 +1501,36 @@ class Log(@volatile private var _dir: File,
case FetchTxnCommitted =
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468882676
##
File path:
core/src/test/scala/unit/kafka/server/AlterUserScramCredentialsRequestTest.scala
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache Software
dajac commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468090360
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java
##
@@ -74,7 +77,9 @@ public RequestAndSize parseRequest(ByteBuffer b
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468884545
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/ResourceNotFoundException.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Softwa
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468885795
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialUpsertion.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Sof
1 - 100 of 138 matches
Mail list logo
