d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468746415
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
##########
@@ -70,7 +70,7 @@
private boolean shouldRebalance;
public MockConsumer(OffsetResetStrategy offsetResetStrategy) {
- this.subscriptions = new SubscriptionState(new LogContext(),
offsetResetStrategy);
+ this.subscriptions = new SubscriptionState(new LogContext(),
offsetResetStrategy, 100, 100);
Review comment:
If we pass the same value for `retryBackoffMs` and `retryBackoffMaxMs`,
a static backoff of 100 ms will be applied. I was thinking that we'd better
make the MockConsumer use the static backoff since some of the written tests
are assuming that.
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
##########
@@ -70,7 +70,7 @@
private boolean shouldRebalance;
public MockConsumer(OffsetResetStrategy offsetResetStrategy) {
- this.subscriptions = new SubscriptionState(new LogContext(),
offsetResetStrategy);
+ this.subscriptions = new SubscriptionState(new LogContext(),
offsetResetStrategy, 100, 100);
Review comment:
If we pass the same value for `retryBackoffMs` and `retryBackoffMaxMs`,
a static backoff of 100 ms will be applied. I was thinking that we'd better
make the MockConsumer use the static backoff since some of the written tests
are assuming that. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
