jeqo commented on a change in pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#discussion_r468590167



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractMergedSortedCacheStoreIterator.java
##########
@@ -136,14 +151,26 @@ public K peekNextKey() {
         }
 
         final int comparison = compare(nextCacheKey, nextStoreKey);
-        if (comparison > 0) {
-            return deserializeStoreKey(nextStoreKey);
-        } else if (comparison < 0) {
-            return deserializeCacheKey(nextCacheKey);
+        if (!reverse) {

Review comment:
       Done on the new PR.

##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractReadOnlyDecorator.java
##########
@@ -177,17 +197,36 @@ public V fetch(final K key,
             return wrapped().fetch(from, to, timeFrom, timeTo);
         }
 
+        @Override
+        public KeyValueIterator<Windowed<K>, V> backwardFetch(final K from,
+                                                      final K to,

Review comment:
       ack.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to