[GitHub] [kafka] mumrah edited a comment on pull request #7222: KAFKA-8806 Reduce calls to validateOffsetsIfNeeded

[GitBox]

mumrah edited a comment on pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#issuecomment-672203738


   Here are some results from the new JMH added (note that the units are 
milliseconds)
   
   ```
   KAFKA-8806:
   
   Benchmark                                                   (partitionCount) 
 (topicCount)  Mode  Cnt   Score   Error  Units
   SubscriptionStateBenchmark.testFetchablePartitions                        50 
         5000  avgt   15  13.758 ± 0.477  ms/op
   SubscriptionStateBenchmark.testHasAllFetchPositions                       50 
         5000  avgt   15   9.131 ± 0.056  ms/op
   SubscriptionStateBenchmark.testPartitionsNeedingValidation                50 
         5000  avgt   15  11.869 ± 0.403  ms/op
   JMH benchmarks done
   
   
   Trunk:
   
   Benchmark                                                   (partitionCount) 
 (topicCount)  Mode  Cnt   Score   Error  Units
   SubscriptionStateBenchmark.testFetchablePartitions                        50 
         5000  avgt   15  19.249 ± 0.117  ms/op
   SubscriptionStateBenchmark.testHasAllFetchPositions                       50 
         5000  avgt   15  17.025 ± 1.421  ms/op
   SubscriptionStateBenchmark.testPartitionsNeedingValidation                50 
         5000  avgt   15  13.291 ± 0.646  ms/op
   JMH benchmarks done
   ```
   
   So for very high partition counts, there seems to be a decent improvement 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org