[GitHub] [kafka] jeqo commented on a change in pull request #8976: KIP-617: Allow Kafka Streams State Stores to be iterated backwards

[GitBox]

jeqo commented on a change in pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#discussion_r468594243



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
##########
@@ -310,12 +421,11 @@ public synchronized void close() {
         );
         if (!suppressed.isEmpty()) {
             throwSuppressed("Caught an exception while closing caching window 
store for store " + name(),
-                            suppressed);
+                suppressed);
         }
     }
 
 
-
     private class CacheIteratorWrapper implements 
PeekingKeyValueIterator<Bytes, LRUCacheEntry> {

Review comment:
       True, I have completed the validation on `#getNextSegmentIterator`, and 
also add these to Session store. I haven't seem test cases affected by this 
tho, will add new one to make sure we are covering this path.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org