cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468841825



##########
File path: 
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java
##########
@@ -69,4 +69,11 @@
      * Returns the correlation id from the request header.
      */
     int correlationId();
+
+    /**
+     * Returns the initial principal name for a forwarded request.
+     */
+    default String initialPrincipalName() {

Review comment:
       Yes, can you add a comment saying this should be used for logging, but 
not for authorization?

##########
File path: 
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java
##########
@@ -69,4 +69,11 @@
      * Returns the correlation id from the request header.
      */
     int correlationId();
+
+    /**
+     * Returns the initial principal name for a forwarded request.
+     */
+    default String initialPrincipalName() {

Review comment:
       Yes, can you add a comment here saying this should be used for logging, 
but not for authorization?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to