lbradstreet commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r468661509



##########
File path: README.md
##########
@@ -199,6 +199,27 @@ You can run spotbugs using:
 The spotbugs warnings will be found in `reports/spotbugs/main.html` and 
`reports/spotbugs/test.html` files in the subproject build
 directories.  Use -PxmlSpotBugsReport=true to generate an XML report instead 
of an HTML one.
 
+### JMH microbenchmarks ###

Review comment:
       I'll provide some text for this soon.

##########
File path: README.md
##########
@@ -199,6 +199,27 @@ You can run spotbugs using:
 The spotbugs warnings will be found in `reports/spotbugs/main.html` and 
`reports/spotbugs/test.html` files in the subproject build
 directories.  Use -PxmlSpotBugsReport=true to generate an XML report instead 
of an HTML one.
 
+### JMH microbenchmarks ###

Review comment:
       While we're at it we can also mention `-prof gc` and how you should look 
for the norm allocation rate (since we care about garbage generated per 
operation rather than per second).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to