alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2484982643
I've finished another round of polishing following review suggestions,
thanks @dsmiley , @cpoerschke and anyone else involved!
1) I modified the class loading, bringing the
[
https://issues.apache.org/jira/browse/SOLR-17567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17567:
--
Labels: cli pull-request-available streams (was: cli streams)
> Improve Stream CLI implementat
epugh opened a new pull request, #2872:
URL: https://github.com/apache/solr/pull/2872
https://issues.apache.org/jira/browse/SOLR-17567
This is to improve StreamTool based on some assessments by @malliaridis!
- [ ] Use of raw strings in Option#getOptionValue()
- [ ] Ov
alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2485082701
hi @malliaridis, first of all nice to meet you!
When rebasing on upstream I ended up with the new dependency approach, given
it's not released I had to dig a bit in the Pull Re
ds-manzinger opened a new pull request, #2874:
URL: https://github.com/apache/solr/pull/2874
https://issues.apache.org/jira/browse/SOLR-17306
Same as https://github.com/apache/solr/pull/2873 -> but now against main
branch
# Description
If Leader has Replicati
malliaridis opened a new pull request, #2878:
URL: https://github.com/apache/solr/pull/2878
https://issues.apache.org/jira/browse/SOLR-17567
# Description
See https://github.com/apache/solr/pull/2872#issuecomment-2486167699 for
context.
# Solution
Reverts the chan
ds-manzinger commented on PR #2873:
URL: https://github.com/apache/solr/pull/2873#issuecomment-2486091063
@epugh First, we tried using BATS for testing (as you already mentioned in
the JIRA Ticket), but it was easier to create the unit test attached to the
Pull Request.
We built this
gerlowskija commented on code in PR #2861:
URL: https://github.com/apache/solr/pull/2861#discussion_r1848626386
##
solr/CHANGES.txt:
##
@@ -237,6 +237,9 @@ led to the suppression of exceptions. (Andrey Bozhko)
* SOLR-17545: Upgrade to Gradle 8.10 (Houston Putman)
+* SOLR-17
risdenk commented on PR #2876:
URL: https://github.com/apache/solr/pull/2876#issuecomment-2486366448
This should link to https://issues.apache.org/jira/browse/SOLR-17069 and
potentially https://github.com/apache/solr/pull/1509
--
This is an automated message from the Apache Git Service.
T
AndreyBozhko opened a new pull request, #2879:
URL: https://github.com/apache/solr/pull/2879
https://issues.apache.org/jira/browse/SOLR-X
# Description
Avoid NPE when SolrCore is closing.
If the snapshotMgr failed to initialize (e.g., because it didn't hav
David Smiley created SOLR-17570:
---
Summary: cursorMark should assume minExactCount=0
Key: SOLR-17570
URL: https://issues.apache.org/jira/browse/SOLR-17570
Project: Solr
Issue Type: Improvement
malliaridis commented on PR #2878:
URL: https://github.com/apache/solr/pull/2878#issuecomment-2486720176
If you want you can add the changes to your PR, so that we can close this
one and reduce the merges into main. :)
--
This is an automated message from the Apache Git Service.
To respon
epugh commented on PR #2878:
URL: https://github.com/apache/solr/pull/2878#issuecomment-2486705064
Do you want me to copy these changes into the Stream tool branch I have, or
just keep them parralel?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
malliaridis commented on PR #2877:
URL: https://github.com/apache/solr/pull/2877#issuecomment-2486723318
@epugh this one can be merged into https://github.com/apache/solr/pull/2872
as well. I think it's better to include them all together in one merge. :)
--
This is an automated message f
dsmiley commented on code in PR #2741:
URL: https://github.com/apache/solr/pull/2741#discussion_r1849091157
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -180,23 +184,35 @@ private boolean fetchFileFromNodeAndPersist(String
fromNode) {
By
malliaridis commented on PR #2867:
URL: https://github.com/apache/solr/pull/2867#issuecomment-2486696648
Waiting for https://github.com/apache/solr/pull/2877 to rerun the checks and
merge afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2486562994
hi @malliaridis, my pleasure to know you!
Thanks for the detailed explanation!
I just added you to the branch, you should be able to write!
If you are willing to help with
[
https://issues.apache.org/jira/browse/SOLR-17570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17570:
Description:
Claim: Someone using cursorMark (deep paging) probably doesn't care about
numFound a
malliaridis commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2486349589
It's nice meeting new people working on this project :D
I have no push permission to push the fixes I've created. There are two
issues in the referencing, one the libs.langchain4j
iamsanjay commented on PR #2741:
URL: https://github.com/apache/solr/pull/2741#issuecomment-2486360871
I plan to merge this PR by the end of the week if there are no further
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
epugh commented on PR #2872:
URL: https://github.com/apache/solr/pull/2872#issuecomment-2485509588
@malliaridis I've marked off the items I took care of. The remaining ones I
need more detail to more forward on.
Regardless, it's nice to get a bit more polish!
--
This is an autom
epugh commented on PR #2872:
URL: https://github.com/apache/solr/pull/2872#issuecomment-2486136854
> Wow, did not have SolrOnHdfsSnapshotsTool under my radar. Did you find it
throught the forbidden-api rules?
I did!!!
--
This is an automated message from the Apache Git Service.
To
bruno-roustant merged PR #2786:
URL: https://github.com/apache/solr/pull/2786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
epugh commented on PR #2873:
URL: https://github.com/apache/solr/pull/2873#issuecomment-2486155043
> Should we also submit a Pull Request against the _main_ branch?
Please do open aginst _main_... Generally we commit to _main_ and then
backport to branch_9x. This should go out in 9.8.
epugh commented on PR #2873:
URL: https://github.com/apache/solr/pull/2873#issuecomment-2486163564
BTW, it would be interesting if you could write a short few paragraphs type
story of how you do your lifecycle with leader/folllower/replicas, your ASG
etc. In
https://github.com/apache/sol
malliaridis commented on PR #2872:
URL: https://github.com/apache/solr/pull/2872#issuecomment-2486167699
About the remaining TODOs:
_Multiple type suppressions that can be avoided_
Suppressions like `@SuppressWarnings({"rawtypes"})` for classes like `List`
can usually be fixed
[
https://issues.apache.org/jira/browse/SOLR-14966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899572#comment-17899572
]
David Smiley commented on SOLR-14966:
-
Noted, but this seems more of a minor optimiza
malliaridis commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2486640193
@alessandrobenedetti If you need further assistance with the rest of the
issues, just let me know. :)
--
This is an automated message from the Apache Git Service.
To respond to the mes
[
https://issues.apache.org/jira/browse/SOLR-17501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis updated SOLR-17501:
Fix Version/s: main (10.0)
Resolution: Resolved
Status: Resolved
dsmiley commented on code in PR #2741:
URL: https://github.com/apache/solr/pull/2741#discussion_r1849072274
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -484,14 +504,24 @@ public List list(String path,
Predicate predicate) {
public void delete
malliaridis merged PR #2744:
URL: https://github.com/apache/solr/pull/2744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-17501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899573#comment-17899573
]
ASF subversion and git services commented on SOLR-17501:
Commit e
malliaridis commented on code in PR #2872:
URL: https://github.com/apache/solr/pull/2872#discussion_r1848617744
##
gradle/validation/forbidden-apis/commons-cli.commons-cli.all.txt:
##
@@ -0,0 +1,5 @@
+@defaultMessage Use a org.apache.commons.cli.Option instead of a String value
[
https://issues.apache.org/jira/browse/SOLR-17219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859867#comment-17859867
]
Guillaume Jactat edited comment on SOLR-17219 at 11/19/24 10:04 PM:
---
dsmiley commented on PR #2879:
URL: https://github.com/apache/solr/pull/2879#issuecomment-2487554064
Thanks. Ideally add a JIRA & CHANGES.txt entry but I'm personally fine with
simply merging this trivial change as-is. So if nobody says anything or you
don't bother, that's what I'll do by
[
https://issues.apache.org/jira/browse/SOLR-17535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17535.
-
Fix Version/s: 9.8
Resolution: Fixed
Deprecated with replacements in 9.8. Removals of thi
jdyer1 merged PR #2828:
URL: https://github.com/apache/solr/pull/2828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2873:
URL: https://github.com/apache/solr/pull/2873#issuecomment-2485945577
Could https://github.com/apache/solr/pull/1875 be augmented to test your
scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/SOLR-17516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899512#comment-17899512
]
ASF subversion and git services commented on SOLR-17516:
Commit 7
epugh commented on PR #2873:
URL: https://github.com/apache/solr/pull/2873#issuecomment-2485943863
I am hoping someone with more confidence in this area weighs in, but if you
don't get a review, please do poke me!!!
--
This is an automated message from the Apache Git Service.
To respond t
[
https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899530#comment-17899530
]
ASF subversion and git services commented on SOLR-17504:
Commit 5
risdenk commented on code in PR #2876:
URL: https://github.com/apache/solr/pull/2876#discussion_r1848801684
##
gradle/libs.versions.toml:
##
@@ -295,7 +296,7 @@ bouncycastle-bcprov = { module =
"org.bouncycastle:bcprov-jdk18on", version.ref
carrot2-core = { module = "org.carro
epugh commented on PR #2872:
URL: https://github.com/apache/solr/pull/2872#issuecomment-2485913079
I've also polished up the docs a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17306:
--
Labels: pull-request-available (was: )
> Solr Repeater or Slave loses data after restart when
[
https://issues.apache.org/jira/browse/SOLR-16781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-16781:
--
Labels: pull-request-available (was: )
> Remove directives from Solr
> --
alessandrobenedetti commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1847847749
##
solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java:
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
[
https://issues.apache.org/jira/browse/SOLR-17516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Dyer reassigned SOLR-17516:
-
Fix Version/s: main (10.0)
Assignee: James Dyer
> LBHttpSolrClient: support HttpJdkSolr
malliaridis opened a new pull request, #2877:
URL: https://github.com/apache/solr/pull/2877
https://issues.apache.org/jira/browse/SOLR-17567
# Description
In https://github.com/apache/solr/pull/2479 an issue was introduced together
with the stream tests that cause the bats test
48 matches
Mail list logo
