alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2484982643
I've finished another round of polishing following review suggestions, thanks @dsmiley , @cpoerschke and anyone else involved! 1) I modified the class loading, bringing the SolrResourceLoader back (it was there in an initial iteration). If no additional feedback comes, I'll consider the SolrEmbeddingModel getInstance, done 2) What I've done in the 'solr/server/etc/security.policy' is recommended/ the correct way to enable what we want here? i.e. the call to external vectorisation services through a third party API? (LangChain4j) If these two points get approval, I'll be happy to align to https://github.com/apache/solr/pull/2706, introduce the right entry in CHANGES and merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
