[
https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899530#comment-17899530
]
ASF subversion and git services commented on SOLR-17504:
--------------------------------------------------------
Commit 5cc733b9fc60d4887df576aef340aa027ed2fc3e in solr's branch
refs/heads/main from Bruno Roustant
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=5cc733b9fc6 ]
SOLR-17504: CoreContainer calls UpdateHandler.commit. (#2786)
> CoreContainer calls UpdateHandler.commit
> ----------------------------------------
>
> Key: SOLR-17504
> URL: https://issues.apache.org/jira/browse/SOLR-17504
> Project: Solr
> Issue Type: Improvement
> Reporter: Bruno Roustant
> Assignee: Bruno Roustant
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> ... and DirectUpdateHandler2.closeWriter supports commit metadata.
> This proposal is about unifying calls to UpdateHandler.commit.
> CoreContainer.reload may call directly IndexWriter.commit if the core to
> reload is readonly (property of the Collection). This is an issue because it
> bypasses some logic in UpdateHandler.commit. In addition, the current code
> commits without taking the commit lock.
> DirectUpdateHandler2.closeWriter may commit if the update log is not empty
> (not committed yet). But it does not call DirectUpdateHandler2.commit(), it
> copies commit() code instead for some reasons (comments in the code mention
> test failures). The proposal is to add the same call to
> DirectUpdateHandler2.shouldCommit() as in the commit() method, otherwise
> commit metadata are lost. In addition shouldCommit() can be extended
> correctly, for example in the solr-sandbox encryption module which needs to
> intercept calls to shouldCommit().
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
