epugh opened a new pull request, #2872: URL: https://github.com/apache/solr/pull/2872
https://issues.apache.org/jira/browse/SOLR-17567 This is to improve StreamTool based on some assessments by @malliaridis! - [ ] Use of raw strings in Option#getOptionValue() - [ ] Overlapping options (-f and -e) - [ ] Multiple type suppressions that can be avoided - [ ] A bug that causes specific bats tests to fail. **done in seperate PR by @malliaridis** ! - [ ] StreamTool.LocalCatStream overrides CatStream btu does not properly set commaDelimitedFilepaths (this may be a bug) - [ ] Obsolete LetStream#getLetParams() was introduced - [ ] Function StreamTool.constructStream seems obsolete and occurrences can be replaced with implementation - [ ] Implementation of StreamTool.readExpression does not take leading spaces infront of comment lines into account - [ ] Implementation of StreamTool.readExpression does not support */ at the end of line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
