malliaridis commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2486349589
It's nice meeting new people working on this project :D
I have no push permission to push the fixes I've created. There are two
issues in the referencing, one the libs.langchain4j and the other one was
`libs.apache.solr.testframework`.
The first one is actually a tricky one and I will have to provide a note in
the documentation in case this happens again. When you have in
`libs.versions.toml` `langchain4j` and `langchain4j-cohere` (for example), then
you have to reference the first dependency as `libs.langchain4j.asProvider()`,
otherwise it is just a group of dependencies, not the dependency itself. An
alternative solution in this case is to simply add another keyword and extend
`langchain4j` in `libs.version.toml`, like I did. Usually for "core" libraries
that have simple names like in this case, you can use `core` or the module name
itself (`langchain4j-langchain4j`).
The second dependency `libs.apache.solr.testframework` could not be
resolved, either because you mean `libs.apache.lucene.testframework` or
`project(':solr:test-framework')`. I assumed the second one, but if wrong,
please update it.
If you update the permissions of this PR, I can push these changes together
with a cleanup of the newly added license files (there is another issue there)
and and update locks / checksums.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
