malliaridis opened a new pull request, #2877:
URL: https://github.com/apache/solr/pull/2877

   https://issues.apache.org/jira/browse/SOLR-17567
   
   # Description
   
   In https://github.com/apache/solr/pull/2479 an issue was introduced together 
with the stream tests that cause the bats tests to fail.
   
   # Solution
   
   This PR applies a fix that is used in `test_basic_auth.bats` for enabling 
authentication. Bats tests are not starting with a clean state sometimes, and 
this is one situation that is affected by that.
   
   # Tests
   
   A test for missing credentials was added. CLI output could be improved but 
is not task of this fix / PR.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [X] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [X] I have developed this patch against the `main` branch.
   - [X] I have run `./gradlew check`.
   - [X] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to