malliaridis commented on PR #2872:
URL: https://github.com/apache/solr/pull/2872#issuecomment-2486167699
About the remaining TODOs:
_Multiple type suppressions that can be avoided_
Suppressions like `@SuppressWarnings({"rawtypes"})` for classes like `List`
can usually be fixed by simply using `List<?>` or using the known generic type
if any present.
_StreamTool.LocalCatStream overrides CatStream btu does not properly set
commaDelimitedFilepaths (this may be a bug)_
In `CatStream` `commaDelimitedFilepaths` is a class property that is also
used in `CatStream#toExpression`, which is called by other classes. By passing
passing the property as parameter in `validateAndSetFilepathsInSandbox` and
overriding the method does not update the class property, resulting to
potential inconsistent behavior / values in other classes.
Instead, it is possible to simply remove the property from the parameters of
`validateAndSetFilepathsInSandbox` (like it was before), and make the property
`commaDelimitedFilepaths` visible (protected modifier). That way, overriding
`validateAndSetFilepathsInSandbox` will be possible without changing the method
signature.
If the description is a bit irritating, I can create a separate PR for that.
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
