malliaridis commented on code in PR #2872: URL: https://github.com/apache/solr/pull/2872#discussion_r1848617744
########## gradle/validation/forbidden-apis/commons-cli.commons-cli.all.txt: ########## @@ -0,0 +1,5 @@ +@defaultMessage Use a org.apache.commons.cli.Option instead of a String value +org.apache.commons.cli.CommandLine#hasOption(java.lang.String) +org.apache.commons.cli.CommandLine#getOptionValue(java.lang.String) +org.apache.commons.cli.CommandLine#getOptionValue(java.lang.String, java.lang.String) +org.apache.commons.cli.CommandLine#getParsedOptionValue(java.lang.String, java.lang.Object) Review Comment: I would extend the following as well (from `CommandLine`): ``` org.apache.commons.cli.CommandLine#hasOption(char) org.apache.commons.cli.CommandLine#getOptionValue(char) org.apache.commons.cli.CommandLine#getOptionValue(char, java.lang.String) org.apache.commons.cli.CommandLine#getOptionValue(char, Supplier<String>) org.apache.commons.cli.CommandLine#getOptionValues(char) org.apache.commons.cli.CommandLine#getOptionValues(java.lang.String) org.apache.commons.cli.CommandLine#getParsedOptionValue(char) org.apache.commons.cli.CommandLine#getParsedOptionValue(char, Supplier<T>) org.apache.commons.cli.CommandLine#getParsedOptionValue(char, java.lang.Object) org.apache.commons.cli.CommandLine#getParsedOptionValue(java.lang.String) org.apache.commons.cli.CommandLine#getParsedOptionValue(String, Supplier<T>) ``` I haven't written any rules before, so I am not sure if the above have the correct format (especially `Supplier<T>` is likely not correct). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
