[
https://issues.apache.org/jira/browse/SOLR-17629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915933#comment-17915933
]
ASF subversion and git services commented on SOLR-17629:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-17629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17629:
--
Labels: pull-request-available (was: )
> SQL didn't always close internal resources if it enco
[
https://issues.apache.org/jira/browse/SOLR-17629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915929#comment-17915929
]
ASF subversion and git services commented on SOLR-17629:
Commit e
dsmiley merged PR #3045:
URL: https://github.com/apache/solr/pull/3045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924605334
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ClusterStateProviderTest.java:
##
@@ -204,8 +204,8 @@ public void
testClusterStateProviderDownedInitialLiveNodes(
[
https://issues.apache.org/jira/browse/SOLR-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915876#comment-17915876
]
ASF subversion and git services commented on SOLR-17065:
Commit a
anshumg merged PR #3052:
URL: https://github.com/apache/solr/pull/3052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
anshumg opened a new pull request, #3052:
URL: https://github.com/apache/solr/pull/3052
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
anshumg merged PR #3051:
URL: https://github.com/apache/solr/pull/3051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915873#comment-17915873
]
ASF subversion and git services commented on SOLR-17065:
Commit 7
anshumg opened a new pull request, #3051:
URL: https://github.com/apache/solr/pull/3051
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924556359
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -530,14 +530,14 @@ public JettySolrRunner stopJettySolrRunner(int index)
throws Ex
mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924555335
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -51,6 +56,7 @@ public abstract class BaseHttpClusterStateProvider implem
mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924552833
##
solr/solrj/src/java/org/apache/solr/common/util/URLUtil.java:
##
@@ -98,4 +102,59 @@ private static String removeTrailingSlashIfPresent(String
url) {
return ur
github-actions[bot] commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2605986155
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2605960508
I would implement the methods here, copying bits of code from #3050 if
needed so that you don't call NamedList.asShallowMap. Take from that whatever
you want. I'm not sure NamedList.asShal
dsmiley commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1924452036
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -189,26 +187,32 @@ private boolean fetchFileFromNodeAndPersist(String
fromNode) {
var
dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924427707
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -530,14 +530,14 @@ public JettySolrRunner stopJettySolrRunner(int index)
throws Exc
dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924412143
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -51,6 +56,7 @@ public abstract class BaseHttpClusterStateProvider impleme
[
https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915843#comment-17915843
]
Jan Høydahl commented on SOLR-17457:
[~richm123] It is indeed backported to the 9.7 r
HoustonPutman commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924410045
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -51,6 +56,7 @@ public abstract class BaseHttpClusterStateProvider i
janhoy commented on PR #749:
URL: https://github.com/apache/solr-operator/pull/749#issuecomment-2605809069
> Bizzare that this didn't happen before. I also ran into this when running
the smoke tester. Let's merge this after the release. Unfortunately we can't
commit to the `release-0.9` bra
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2605722808
@dsmiley Considering your improvements on NamedList..asShallowMap, could I
just delegate the method keySet, values and entrySet to the shallowMap e.g. :
public Collection values() {
solrbot commented on PR #2992:
URL: https://github.com/apache/solr/pull/2992#issuecomment-2605676906
### ⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably
do not want to merge this PR as-is.
♻ Renovate will retry this branch,
mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924301197
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -51,6 +56,7 @@ public abstract class BaseHttpClusterStateProvider implem
mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924267502
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -530,14 +530,14 @@ public JettySolrRunner stopJettySolrRunner(int index)
throws Ex
epugh commented on code in PR #3047:
URL: https://github.com/apache/solr/pull/3047#discussion_r1924229223
##
solr/api/src/java/org/apache/solr/client/api/endpoint/ClusterFileStoreApis.java:
##
@@ -70,4 +97,23 @@ SolrJerseyResponse deleteFile(
"Indicates whethe
dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924189617
##
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##
@@ -530,14 +530,14 @@ public JettySolrRunner stopJettySolrRunner(int index)
throws Exc
HoustonPutman commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924191070
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -51,6 +56,7 @@ public abstract class BaseHttpClusterStateProvider i
dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924183653
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -51,6 +56,7 @@ public abstract class BaseHttpClusterStateProvider impleme
dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924183653
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -51,6 +56,7 @@ public abstract class BaseHttpClusterStateProvider impleme
dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2605415831
> I am curious if there is a way to implement values() and entrySet(0
without an unchecked cast, e.g. (T) nvPairs.get(i)
Almost nobody could answer a cast question like that without li
HoustonPutman commented on PR #749:
URL: https://github.com/apache/solr-operator/pull/749#issuecomment-2605354219
Bizzare that this didn't happen before. I also ran into this when running
the smoke tester. Let's merge this after the release. Unfortunately we can't
commit to the `release-0.9
dsmiley commented on PR #2930:
URL: https://github.com/apache/solr/pull/2930#issuecomment-2605292284
If Jackson can't handle it then I think it's better to drop the POJO so we
can have a better HTTP API.
I'll look for more PATCH opportunities but it's not clear to me what problem
there w
dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924087626
##
solr/solrj/src/java/org/apache/solr/common/util/Utils.java:
##
@@ -748,61 +745,6 @@ public static String applyUrlScheme(final String url,
final String urlScheme) {
dsmiley commented on PR #3050:
URL: https://github.com/apache/solr/pull/3050#issuecomment-2605226024
@renatoh -- this is some WIP I did a couple months ago. Looking at this may
prove useful in #3048
--
This is an automated message from the Apache Git Service.
To respond to the message,
dsmiley commented on PR #2764:
URL: https://github.com/apache/solr/pull/2764#issuecomment-2605253716
Just a reminder: The commit message here should highlight 2 things.
SolrClientCache AND the schema designer using Jetty HttpClient (HTTP/2). The
title of this PR points to just one.
--
[
https://issues.apache.org/jira/browse/SOLR-17630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915758#comment-17915758
]
David Smiley commented on SOLR-17630:
-
The linked dev list thread highlights that the
[
https://issues.apache.org/jira/browse/SOLR-17552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17552:
--
Labels: pull-request-available (was: )
> NamedList.asShallowMap improvements
> ---
[
https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914858#comment-17914858
]
Rich M edited comment on SOLR-17457 at 1/21/25 3:43 PM:
Was this
[
https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915743#comment-17915743
]
Rich M commented on SOLR-17457:
---
Previous comment from [~malliaridis] says this bug was bac
mlbiscoc commented on PR #2935:
URL: https://github.com/apache/solr/pull/2935#issuecomment-2605025917
> You know what... See URLUtil. Shouldn't _that_ be where these methods go?
The existing method can be deprecated and call the one at the better location.
Also has a test where your tests o
[
https://issues.apache.org/jira/browse/SOLR-17581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Salagnac resolved SOLR-17581.
Fix Version/s: 9.9
Assignee: Pierre Salagnac
Resolution: Fixed
> Less Zooke
[
https://issues.apache.org/jira/browse/SOLR-17630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17630:
--
Labels: pull-request-available (was: )
> Add CloudSolrClient instance for a Solr node
> --
dsmiley opened a new pull request, #3049:
URL: https://github.com/apache/solr/pull/3049
and ZkController.getSolrClient for a canonical node managed CloudSolrClient.
Deprecate SolrCloudManager.request
https://issues.apache.org/jira/browse/SOLR-17630
This PR re-routes usages of S
[
https://issues.apache.org/jira/browse/SOLR-17419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914972#comment-17914972
]
Jason Gerlowski commented on SOLR-17419:
bq. I found out about this cool optimiza
janhoy commented on PR #749:
URL: https://github.com/apache/solr-operator/pull/749#issuecomment-2604637062
Checked out the PR branch and re-ran the smoke tester. It now gets past the
previous error!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
gerlowskija commented on PR #749:
URL: https://github.com/apache/solr-operator/pull/749#issuecomment-2604619373
The smoke-tests pass for me without this PR, but on inspection it seems like
a pretty clear bug. Not sure why my smoke-test run doesn't trigger this
codepath, seemingly.
--
Th
gerlowskija opened a new pull request, #749:
URL: https://github.com/apache/solr-operator/pull/749
A variable 'artifact' was being referenced outside of the for-in loop that
created it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
[
https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914959#comment-17914959
]
Jan Høydahl commented on SOLR-17457:
The issue was tagged with v9.7.1, and v9.8. Neit
50 matches
Mail list logo
