dsmiley commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1924427707
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -530,14 +530,14 @@ public JettySolrRunner stopJettySolrRunner(int index)
throws Exception {
}
/**
- * Add a previously stopped node back to the cluster
+ * Add a previously stopped node back to the cluster and reuse its port
*
* @param jetty a {@link JettySolrRunner} previously returned by {@link
#stopJettySolrRunner(int)}
* @return the started node
* @throws Exception on error
*/
public JettySolrRunner startJettySolrRunner(JettySolrRunner jetty) throws
Exception {
- jetty.start(false);
+ jetty.start();
Review Comment:
When faced with curiosities like this, it's useful to do a bit of code/JIRA
archeology. `git blame` (via IntelliJ's margin, BTW) shows the current setting
(to pick a random port) was *deliberate* and had its own JIRA --
https://issues.apache.org/jira/browse/SOLR-9474 and I found a related one:
https://issues.apache.org/jira/browse/SOLR-9469 . I read the conversation
there. Changing it is worthy of its own JIRA & CHANGES.txt entry, following a
deeper attempt to understand the causes behind why it hasn't been reusing a
port thus far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
