dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2605960508

   I would implement the methods here, copying bits of code from #3050 if 
needed so that you don't call NamedList.asShallowMap.  Take from that whatever 
you want.  I'm not sure NamedList.asShallowMap was a wise idea since it can't 
implement the Map contract if the keys repeat.  It might have pre-dated 
SimpleOrderedMap.  Assuming you finish the PR here, I'm inclined to maybe make 
NamedList.asShallowMap do an instanceof check for SimpleOrderedMap and if so 
return "this" but otherwise throw an exception.  Or remove it.  Ideally we only 
use NamedList that isn't SimpleOrderedMap for the rare cases where it's 
appropriate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to