HoustonPutman commented on code in PR #2935: URL: https://github.com/apache/solr/pull/2935#discussion_r1924191070
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ########## @@ -51,6 +56,7 @@ public abstract class BaseHttpClusterStateProvider implements ClusterStateProvid private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); private String urlScheme; + private List<String> configuredNodes; Review Comment: Yeah, if the idea is to have 1 method that handles both, then I would instead have a `liveNodeURLs` list in addition to `liveNodes`, so that the `updateLiveNodes ` method takes in the urls. But the method can probably split to share logic, but handle both strings and urls as inputs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
