mlbiscoc commented on code in PR #2935: URL: https://github.com/apache/solr/pull/2935#discussion_r1924301197
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ########## @@ -51,6 +56,7 @@ public abstract class BaseHttpClusterStateProvider implements ClusterStateProvid private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); private String urlScheme; + private List<String> configuredNodes; Review Comment: I basically tried to keep `configuredNodes` the same format as `liveNodes` as they are used the same with `updateLiveNodes`. I don't like the idea of another `liveNodeURLs` list attribute and think just changing liveNodes to be `List<URL>` would make sense but the caller now get a different list URLs and not nodeNames. I guess I'll just go the route of updateLiveNodes functions handling both `NodeName` strings and `Base URL` inputs unless you feel strongly about having an additional `liveNodeURLs` list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
