[ 
https://issues.apache.org/jira/browse/SOLR-17630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915758#comment-17915758
 ] 

David Smiley commented on SOLR-17630:
-------------------------------------

The linked dev list thread highlights that there are too many ways to execute 
an intra-node request within Solr.  This PR implements one of my 
recommendations, which is to add a CloudSolrClient getter to SolrCloudManager.  
I also added a convenient getter for this to ZkController.  I further added 
recommendations that SolrClientCache is really for streaming expressions; not 
for other/general needs.

> Add CloudSolrClient instance for a Solr node
> --------------------------------------------
>
>                 Key: SOLR-17630
>                 URL: https://issues.apache.org/jira/browse/SOLR-17630
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: David Smiley
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There ought to be a general CloudSolrClient instance for the Solr node, 
> without each potential user of such needing to create one.  The closest 
> substitute at the moment is 
> {{cc.getSolrClientCache().getCloudSolrClient(cc.getZkController().getZkServerAddress())}}
>  which is too verbose, not as discoverable, and it's debatable if 
> SolrClientCache should be it's home.
> A scalability/simplicity advantage of a shared one instead of newly 
> constructed one is that the existing ZkClientClusterStateProvider (same node 
> ZkStateReader instance) can be used, thus improving scalability and 
> simplifying interpretation of logs (as all logs from ZkStateReader on a node 
> can be assumed to then be from the same instance).  SolrClientCache creates 
> new ones.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to