mlbiscoc commented on PR #2935: URL: https://github.com/apache/solr/pull/2935#issuecomment-2605025917
> You know what... See URLUtil. Shouldn't _that_ be where these methods go? The existing method can be deprecated and call the one at the better location. Also has a test where your tests of this method can be added to. (big code base; so many util classes) > > This PR is pretty close to merging now. I ended up moving all those functions into `URLUril` which resulted in a much larger code change. Not sure if you meant for me to use the `Deprecated` annotation but instead just moved it and refactored the callers. Also didn't add in [SOLR-17607](https://issues.apache.org/jira/browse/SOLR-17607) because it broke a few more tests that needed more changes so just held the changes locally and will probably just make it in another PR and link it to that JIRA unless you prefer me to do it here in one go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
