iamsanjay commented on PR #2741:
URL: https://github.com/apache/solr/pull/2741#issuecomment-2463764009
@dsmiley I think it doesn't even matter If we pass only zkAddress, or the
combination of both zkHost and zkChroot.
```
void testZkClientClusterStateProviderCtor() throws IOExcep
dsmiley merged PR #2834:
URL: https://github.com/apache/solr/pull/2834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-17535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896552#comment-17896552
]
ASF subversion and git services commented on SOLR-17535:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896545#comment-17896545
]
Noble Paul commented on SOLR-14680:
---
+1
> Provide simple interfaces to our concrete So
NikolaiJDev commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1833045939
##
solr/webapp/web/solrUi/src/app/modules/common/utils/DateConverter.ts:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
alessandrobenedetti commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1832545720
##
solr/solr-ref-guide/modules/query-guide/pages/embedding-text.adoc:
##
@@ -0,0 +1,280 @@
+= Embedding Text
+// Licensed to the Apache Software Foundation (AS
[
https://issues.apache.org/jira/browse/SOLR-17549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896453#comment-17896453
]
David Smiley commented on SOLR-17549:
-
To learn more, I tracked down this getParsed m
dsmiley commented on code in PR #2852:
URL: https://github.com/apache/solr/pull/2852#discussion_r1833191483
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -66,32 +64,23 @@ public static Collection toContentStreams(
* Create the full URL for
aparnasuresh85 opened a new pull request, #2853:
URL: https://github.com/apache/solr/pull/2853
# Description
Address a test failure in `ClusterStateProviderTest.testGetClusterStatus`
when `ClusterStateProvider` (CSP) chosen is `Http2ClusterStateProvider`. More
importantly, while `Clu
dsmiley commented on PR #2849:
URL: https://github.com/apache/solr/pull/2849#issuecomment-2462384200
> are you suggesting that it just be a default? And so any data, on it's way
in is compressed, and on it's way back out is uncompressed? Interesting idea!
No, but it's confusing becaus
cpoerschke commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1832779589
##
solr/modules/llm/src/test/org/apache/solr/llm/embedding/DummyEmbeddingModel.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/SOLR-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896279#comment-17896279
]
Eric Pugh commented on SOLR-7962:
-
Hey! I jsut got my first (in years) working connection
alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2462858580
Thanks @cpoerschke, I incorporated all your suggestions!
Thanks @dsmiley for helping, in the meantime I branched here to tentatively
use the FileStore:
https://github.com/Seas
NikolaiJDev commented on PR #2818:
URL: https://github.com/apache/solr/pull/2818#issuecomment-2462844135
> _References to assets seems problematic_
>
> I believe that references of the type `../../../solrUi/src/assets/*` are
likely to break during deployment, as the project is being b
alessandrobenedetti commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1833100801
##
solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
gerlowskija commented on PR #2788:
URL: https://github.com/apache/solr/pull/2788#issuecomment-2462819695
> I added one new unit test [...] using a generated SolrJ API [...] but the
invocation of the client API (new
ClusterPropertiesApi.GetClusterProperty("ext.clusterPropThatDoesNotExist").p
alessandrobenedetti commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1833098671
##
solr/modules/llm/src/test/org/apache/solr/llm/embedding/DummyEmbeddingModel.java:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
gerlowskija commented on PR #2788:
URL: https://github.com/apache/solr/pull/2788#issuecomment-2462829051
The discussion here has gotten a bit long, but to summarize my
understanding: "Problem 1" and "Problem 2" are both resolved, the first by
virtue of being punted to SOLR-17549 and the sec
Jason Gerlowski created SOLR-17549:
--
Summary: Reconsider error-handling in generated-v2 SolrResponses
Key: SOLR-17549
URL: https://issues.apache.org/jira/browse/SOLR-17549
Project: Solr
Issu
NikolaiJDev commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1833045939
##
solr/webapp/web/solrUi/src/app/modules/common/utils/DateConverter.ts:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
NikolaiJDev commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1833041219
##
solr/webapp/web/solrUi/src/app/modules/common/shared.module.ts:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
gerlowskija opened a new pull request, #2852:
URL: https://github.com/apache/solr/pull/2852
https://issues.apache.org/jira/browse/SOLR-17256
# Description
Previous PRs removed all use of getBasePath/setBasePath, but didn't remove
the methods themselves to facilitate easier
NikolaiJDev commented on PR #2818:
URL: https://github.com/apache/solr/pull/2818#issuecomment-2462759400
> First of all I want to thank you for the time and effort you have put
together into this PR and migration. It is nice to have options to choose from
and to compare with one another for
alessandrobenedetti commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1832521769
##
solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc:
##
@@ -242,9 +242,9 @@ client.add(Arrays.asList(d1, d2));
== Query Time
-Apache
HoustonPutman commented on PR #2849:
URL: https://github.com/apache/solr/pull/2849#issuecomment-2462698457
The idea is that with this we can eventually use the Curator recipes, which
will require that our interactions with the CuratorFramework and SolrZkClient
behave similarly. So yes, we c
[
https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896280#comment-17896280
]
Jan Høydahl commented on SOLR-4587:
---
Thanks for the update. You may want to fire a mail
cpoerschke commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1832505259
##
solr/modules/llm/src/java/org/apache/solr/llm/search/TextEmbedderQParserPlugin.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
malliaridis commented on code in PR #389:
URL: https://github.com/apache/solr/pull/389#discussion_r1832971729
##
solr/bin/solr:
##
@@ -1973,7 +1973,7 @@ fi
LOG4J_CONFIG=()
Review Comment:
If the log4j options should always be loaded as default, we should consider
adding
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1832885037
##
solr/webapp/web/solrUi/src/app/modules/common/utils/DateConverter.ts:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896365#comment-17896365
]
Jason Gerlowski commented on SOLR-17256:
Alright - I've just uploaded what should
dsmiley commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2462415496
I'm willing to help out slinging some code here in aims to prevent
duplication of similar mechanisms within Solr.
--
This is an automated message from the Apache Git Service.
To respond to
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1832899607
##
solr/webapp/web/solrUi/src/app/modules/common/shared.module.ts:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
cpoerschke commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1832897176
##
solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cpoerschke commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1832897176
##
solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2461998625
> I went through and mostly commented on the code. Having said that, I don't
know that I grok the high level vision, since that's hard to convey with just a
PR. I would like to l
cpoerschke commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1832784911
##
solr/modules/llm/src/java/org/apache/solr/llm/embedding/SolrEmbeddingModel.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896330#comment-17896330
]
David Smiley commented on SOLR-4587:
FWIW I think this will be a valuable/appreciated
dsmiley commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2462407322
The role of the FileStore is to handle distributed node/cluster
synchronization of the underlying bytes; that's it. Is that relevant/useful
for the model store you need? If it's not, then
gerlowskija merged PR #2827:
URL: https://github.com/apache/solr/pull/2827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
dsmiley commented on code in PR #2741:
URL: https://github.com/apache/solr/pull/2741#discussion_r1832773907
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -223,15 +219,12 @@ private boolean fetchFileFromNodeAndPersist(String
fromNode) {
fi
NikolaiJDev commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1832654687
##
solr/webapp/web/solrUi/src/app/modules/common/shared.module.ts:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
NikolaiJDev commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1832651367
##
solr/webapp/web/solrUi/src/app/modules/common/utils/DateConverter.ts:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
NikolaiJDev commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1832632574
##
solr/webapp/web/solrUi/src/app/modules/dashboard/models/systeminfo/ILuceneInformation.ts:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
[
https://issues.apache.org/jira/browse/SOLR-17533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-17533:
Assignee: Christos Malliaridis
> Rearrange and cleanup solr.cmd
> --
>
[
https://issues.apache.org/jira/browse/SOLR-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896276#comment-17896276
]
Eric Pugh commented on SOLR-7962:
-
I also tried bin/solr start -e techproducts -Dsolr.modu
[
https://issues.apache.org/jira/browse/SOLR-16999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896275#comment-17896275
]
Jan Høydahl commented on SOLR-16999:
I made them static since they can be static. No
[
https://issues.apache.org/jira/browse/SOLR-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896273#comment-17896273
]
Eric Pugh commented on SOLR-7962:
-
Hi all, I wanted to see if I could get this ticket clos
[
https://issues.apache.org/jira/browse/SOLR-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-13422.
--
Assignee: Eric Pugh (was: Erik Hatcher)
Resolution: Cannot Reproduce
I gave this a try and can't
alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2461943259
> When you look at the model store, it would be great to hear where it comes
up short and we could look at improving it. What would make it an "easy"
decision to adopt!??
epugh commented on PR #2761:
URL: https://github.com/apache/solr/pull/2761#issuecomment-2461934671
@janhoy would you mind weighing in ont this PR since it changes a default
behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alessandrobenedetti commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2461910357
As I was progressing on the route of the FileStore, a thought came to my
mind:
With the current implementation the embedding model store guarantees a
singleton life for each m
[
https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896258#comment-17896258
]
Andrzej Bialecki commented on SOLR-14680:
-
+1 (no surprise given my objections ab
epugh commented on PR #2849:
URL: https://github.com/apache/solr/pull/2849#issuecomment-2461874627
> Could we call compress() universally and then our compressor chooses to
only compress based on our criteria (state.json)? Just an idea off the top of
my head; I don't know where compress() i
53 matches
Mail list logo
