NikolaiJDev commented on PR #2818:
URL: https://github.com/apache/solr/pull/2818#issuecomment-2462844135

   > _References to assets seems problematic_
   > 
   > I believe that references of the type `../../../solrUi/src/assets/*` are 
likely to break during deployment, as the project is being built and moved to 
different directories. If I am not mistaken, the src folder does also not exist 
as such once the project is built. I believe the correct reference would be 
just `/assets/*`. This may happend unintentionally while moving things around. 
Pointing that out in case we decide to follow this approach.
   
   I won't be so worry about that, this is just for source while webpack that 
runs under the hood of the ng build, packs all that requires to assets of the 
apllication here is an example:
   ```
   #environment {
     background-image: url("./media/box-DCQ6CIJF.png");
   ```
   I took this line from the compiled and minimized css file that appeared 
after compilation. 
   We only need to worry where and how to place those images at this moment 
that simplify our development process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to