NikolaiJDev commented on code in PR #2818: URL: https://github.com/apache/solr/pull/2818#discussion_r1833041219
########## solr/webapp/web/solrUi/src/app/modules/common/shared.module.ts: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +import {NgModule} from '@angular/core'; +import {SizeUnitConverterPipe} from "./pipes/sizeconverter/size-unit-converter-pipe.pipe"; +import {TimeAgoPipe} from "./pipes/timeconverter/time-ago.pipe"; +import {CommonModule, NgClass, NgFor, NgIf} from "@angular/common"; +import {IResourceParams} from "@ngx-resource/core"; +import {environment} from "../../../environments/environment"; + + +@NgModule({ + declarations: [SizeUnitConverterPipe, TimeAgoPipe], + imports: [CommonModule, NgClass, NgFor, NgIf], + exports: [SizeUnitConverterPipe, TimeAgoPipe, NgClass, NgFor, NgIf], +}) +export class SharedModule { Review Comment: @malliaridis, well If we begin our implementation and only at the later stage add the structure to integrate third party extension, it might require significant amount of work at the latest stage of the development. It's simple for example, if we want to integrate multi-laguage support into our UI, it would be easier to add it at this stage of the application development rather at the latest stage. Regarding this Shared module, is more about code grouping within the application structure. At this point of the implementation, we have only one component is provided for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
