NikolaiJDev commented on code in PR #2818: URL: https://github.com/apache/solr/pull/2818#discussion_r1833045939
########## solr/webapp/web/solrUi/src/app/modules/common/utils/DateConverter.ts: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +export class DateConverter { + private static pattern: string = '/.* (?<date>\d{4}-\d{2}-\d{2}) .*/'; Review Comment: Well, if we're going to discuss the current value then, my solution is for working with that part, it cuts DateTime value out of string value. Why I'm not using default pipe just because the string that I'm getting is non DateTime only, it also holds the data that has nothing to do with that. In other cases, I would use default pipe transformation rather creating my own solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
