[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896365#comment-17896365
]
Jason Gerlowski commented on SOLR-17256:
----------------------------------------
Alright - I've just uploaded what should probably be the last PR for this
ticket.
https://github.com/apache/solr/pull/2852 removes SolrRequest.setBasePath,
SolrRequest.getBasePath, and RequestWriter.getPath from "main", and adds a
corresponding CHANGES.txt entry about the removal. Since a previous PR handled
removing all use of these methods, the removal ended up being trivial.
I thought we'd need a 9x PR as well to add a deprecation entry for CHANGES.txt,
but it looks like that's already in place, so no need.
Excited to close this out!
> Remove SolrRequest.getBasePath setBasePath
> ------------------------------------------
>
> Key: SOLR-17256
> URL: https://issues.apache.org/jira/browse/SOLR-17256
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: David Smiley
> Assignee: Jason Gerlowski
> Priority: Minor
> Labels: newdev, pull-request-available
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> SolrRequest has a getBasePath & setBasePath. The naming is poor; it's the
> URL base to the Solr node like "http://localhost:8983/solr";. It's only
> recognized by HttpSolrClient; LBSolrClient (used by CloudSolrClient) ignores
> it and will in fact mutate the passed in request to its liking, which is
> rather ugly because it means a request cannot be used concurrently if the
> user wants to. But moreover I think there's a conceptual discordance of
> placing this concept on SolrRequest given that some clients want to route
> requests to nodes *they* choose. I propose removing this from SolrRequest
> and instead adding a method specific to HttpSolrClient. Almost all existing
> usages of setBasePath immediately execute the request on an HttpSolrClient,
> so should be easy to change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
