[ https://issues.apache.org/jira/browse/SOLR-16999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896275#comment-17896275 ]
Jan Høydahl commented on SOLR-16999: ------------------------------------ I made them static since they can be static. No reason to force instance creation for stuff that is static in nature. I guess when I created the assert tool I thought of it as a toolbox utility that could be used both by the (then undocumented) assert CLI command and elsewhere, perhaps tests etc. If we don't need some of them, I have no feelings attached to keeping them :) > AssertTool has lots of static methods > ------------------------------------- > > Key: SOLR-16999 > URL: https://issues.apache.org/jira/browse/SOLR-16999 > Project: Solr > Issue Type: Sub-task > Components: cli > Affects Versions: main (10.0) > Reporter: Eric Pugh > Priority: Major > Labels: newdev > > Unclear why we have static methods on the AssertTool when we aren't using > them in the code base. > If you need the static assert methods, please speak up! -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org