alessandrobenedetti commented on PR #2809: URL: https://github.com/apache/solr/pull/2809#issuecomment-2461943259
> When you look at the model store, it would be great to hear where it comes up short and we could look at improving it. What would make it an "easy" decision to adopt!?? My partial feedback after 3-4 hours working on that: 1) it's difficult to find the FileStore, there are multiple with very similar names, it's not easy to identify which one to use 2) JavaDocs explaining the store way of functioning are missing ( or very difficult to find, I couldn't) 3) there are plenty of elaborated comments in the code that make code readability even more difficult (comments with observations, suggestions, exclamation marks etc) 4) the get method, to get a file from the store is void and appears unnecessarily complicated to interact with 5) it's very hard to find code examples that show how to upload and get files from it, also exhaustive tests were missing or hard to find, I couldn't find much 6) there are APIs to interact with it, but they seem oriented to an external usage rather than to use the store from within Solr? 7) Reference Guide talks about packages and modules but doesn't elaborate much on the FileStore This is a genuine not provocative feedback from someone with a decent experience with Solr and Solr codebase, I assume that a new developer would struggle even more in using it? @epugh hope this is helpful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
