NikolaiJDev commented on PR #2818: URL: https://github.com/apache/solr/pull/2818#issuecomment-2462759400
> First of all I want to thank you for the time and effort you have put together into this PR and migration. It is nice to have options to choose from and to compare with one another for decisions of this scale. No problem, this is just an experience for me and my friends. > I have a few questions in regards to the changes included that would be great if you can answer them: > > * What was the reason again you had to rename / move the initial webapp module? > * Have you looked into the file size of a deployment? This would be an interesting value to compare with other framework if you have it available. > * The current state of the PR seems to not integrate the Angular project into the current "deployment", resulting in CORS issues when running with `npm start`. Do you have any instructions on how to run it so that we can see the UI in action? Let's start from the first question: 1. I've planned to integrate two completely different solution that is going to work in parallel and place switch to new implementation that person can simply change it to old one. 2. At this moment including all of the assets the total solution is cost 267 kb, in the later versions it might grow unto 2 - 3 mb may be a little bit more, because we are producing a bundle that holds everything. 3. That's correct, I didn't invest enough time to merge to two different approaches to work under same server, usually for that is responsible app server in our case, it must be done via web.xml + might be require additional filter or something changes in the java app itself to consume and work with two approaches. > A short feedback about improving the quality of your PR: If it would be possible to keep the current webapp untouched, the PR would be much smaller and easier to review. The lines of code would also better represent the actual work and part that should be reviewed. Seeing 55k lines of code "scares" many reviewers, even if it is just generated or moved stuff. Okay, I'll try to revert most of the changes related to the current solution back that it won't affect PR. > I would also like to have a documentation that provide resources for further reading or basic ideas behind things like project structure (of the frontend of course). I think this would give our current community an easier start for both reviewing and working with the code. Well, I'm not sure what do you mean under the documentation with this. If you're speaking about the documentation such as README file then I will add one how to start local environment, until we'll have complete integration with backend solution, it won't help. I hope I correctly understood you. > Starting and testing the current UI seems also not to be working in this PR, which would be necessary for other reviewers to form an opinion. If you're speaking about unit/integration test, first of all I'm planning to move all the current functionality that exists at this moment toward to the new implementation that it went smoothly, and we can simply continue add features and refactor the current solution. If you're speaking about the way how to start and poke review it. Then I do everything from `package.json` until we integrated it with current backend solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
