iamsanjay commented on PR #2682:
URL: https://github.com/apache/solr/pull/2682#issuecomment-2423622130
`-XX:-UseBiasedLocking` removed in JDK 21. And, due to which Benchmarking is
failing. Will be removing it.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/SOLR-17502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891108#comment-17891108
]
Sanjay Dutt commented on SOLR-17502:
I have not tested it, but I believe sending "-ht
[
https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891110#comment-17891110
]
Sanjay Dutt commented on SOLR-17497:
FAILED:
org.apache.solr.cloud.api.collections.
[
https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891109#comment-17891109
]
Sanjay Dutt commented on SOLR-17497:
More test cases failing with same exception, and
gus-asf commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2423564458
That's an interesting observation, and it is worth noting that the strategy
here is somewhat different and not necessarily duplicative of SOLR-17158. I did
try to additionally add a short-ci
[
https://issues.apache.org/jira/browse/SOLR-17506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891103#comment-17891103
]
David Smiley commented on SOLR-17506:
-
I'm not sure I agree or disagree here but dete
[
https://issues.apache.org/jira/browse/SOLR-17505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-17505:
Assignee: Eric Pugh
> Revamp "Launch Solr in SolrCloud Mode" in tutorial 0 to remove -c
>
epugh opened a new pull request, #2781:
URL: https://github.com/apache/solr/pull/2781
https://issues.apache.org/jira/browse/SOLR-17467
# Description
Finishing migration towards --user-managed as a flag.
# Solution
Missed a boolean flip!
# Tests
epugh opened a new pull request, #2780:
URL: https://github.com/apache/solr/pull/2780
https://issues.apache.org/jira/browse/SOLR-17467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/SOLR-17505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17505:
--
Labels: pull-request-available (was: )
> Revamp "Launch Solr in SolrCloud Mode" in tutorial 0
Eric Pugh created SOLR-17507:
Summary: Introduce in Ref Guide that it's okay to use embedded ZK
Key: SOLR-17507
URL: https://issues.apache.org/jira/browse/SOLR-17507
Project: Solr
Issue Type: Sub
[
https://issues.apache.org/jira/browse/SOLR-17506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-17506:
-
Description:
Change places where we say "blah blah SolrCloud cluster" to just saying "blah
blah Solr clu
Eric Pugh created SOLR-17506:
Summary: Move from "SolrCloud cluster" language in docs to "Solr
cluster" language?
Key: SOLR-17506
URL: https://issues.apache.org/jira/browse/SOLR-17506
Project: Solr
epugh merged PR #2730:
URL: https://github.com/apache/solr/pull/2730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
Eric Pugh created SOLR-17505:
Summary: Revamp "Launch Solr in SolrCloud Mode" in tutorial 0 to
remove -c
Key: SOLR-17505
URL: https://issues.apache.org/jira/browse/SOLR-17505
Project: Solr
Issue
epugh commented on PR #2778:
URL: https://github.com/apache/solr/pull/2778#issuecomment-2423425973
Okay, so now the tests all passed @janhoy.. I kind of hacked in something
to work for PostTool, I actually thought it would be needed on more other
tools...
--
This is an automated messag
[
https://issues.apache.org/jira/browse/SOLR-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891095#comment-17891095
]
ASF subversion and git services commented on SOLR-17468:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17468.
--
Fix Version/s: 9.8
Resolution: Fixed
Was able to backport this to 9x.
> Revamp Ref Guide to fe
epugh commented on PR #2730:
URL: https://github.com/apache/solr/pull/2730#issuecomment-2423422143
Maybe should be in CHANGES.txt? However we don't normally track changes to
ref guide, and this isn't a new Feature in the ref guide...
--
This is an automated message from the Apache Git Se
[
https://issues.apache.org/jira/browse/SOLR-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891092#comment-17891092
]
ASF subversion and git services commented on SOLR-17468:
Commit b
epugh commented on code in PR #2778:
URL: https://github.com/apache/solr/pull/2778#discussion_r1807114387
##
solr/core/src/java/org/apache/solr/cli/AssertTool.java:
##
@@ -531,7 +530,7 @@ private static boolean isSolrRunningOn(String url) throws
Exception {
}
private st
epugh commented on code in PR #2778:
URL: https://github.com/apache/solr/pull/2778#discussion_r1807115198
##
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##
@@ -315,8 +315,7 @@ public void runImpl(CommandLine cli) throws Exception {
throw new IllegalArgumentExc
dsmiley closed pull request #2493: SOLR-17320: Added support for timeAllowed
time out in HttpShardHandler
URL: https://github.com/apache/solr/pull/2493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891053#comment-17891053
]
David Smiley commented on SOLR-17158:
-
Question: if all shards time out and if shard
[
https://issues.apache.org/jira/browse/SOLR-17320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17320.
-
Resolution: Duplicate
> HttpShardHandler should obey `timeAllowed` parameter in query
> -
dsmiley commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2422993777
A warning: A colleague cherry-picked this PR to our environment and we
found that if all distributed requests time out, and if shards.tolerant=true,
that there are NullPointerExceptions. T
bruno-roustant commented on PR #113:
URL: https://github.com/apache/solr-sandbox/pull/113#issuecomment-2422961251
For the SolrIndexSplitter.doSplit, it is already handled in
EncryptionUpdateHandler which extends DirectUpdateHandler2.split(). This method
creates the SolrIndexSplitter and giv
[
https://issues.apache.org/jira/browse/SOLR-17502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891045#comment-17891045
]
David Smiley commented on SOLR-17502:
-
FWIW I reproduced the problem. The behavior I
dsmiley commented on code in PR #112:
URL: https://github.com/apache/solr-sandbox/pull/112#discussion_r1806808743
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionTransactionLog.java:
##
@@ -140,28 +139,33 @@ private static void writeBEInt(OutputStream outputStre
dsmiley commented on PR #113:
URL: https://github.com/apache/solr-sandbox/pull/113#issuecomment-2422926050
:embarrassed: totally an accident; sorry! I saw it was closed (didn't
notice it was me!), so I deleted my comment to shift it to #109
I suppose IndexWriter.commit() is risky
bruno-roustant commented on PR #113:
URL: https://github.com/apache/solr-sandbox/pull/113#issuecomment-2422873354
@dsmiley why did you close this PR?
It seems you wrote some comments, but I don't see them anymore.
--
This is an automated message from the Apache Git Service.
To respond t
[ https://issues.apache.org/jira/browse/SOLR-17502 ]
David Smiley deleted comment on SOLR-17502:
-
was (Author: dsmiley):
Is this actually config/overlay specific – somewhat obscure that many of us are
not familiar with? Like simply do a query
[
https://issues.apache.org/jira/browse/SOLR-17502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891040#comment-17891040
]
David Smiley commented on SOLR-17502:
-
Also, Solr does top level (SolrDispatchFilter)
[
https://issues.apache.org/jira/browse/SOLR-17502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891033#comment-17891033
]
David Smiley commented on SOLR-17502:
-
Is this actually config/overlay specific – som
bruno-roustant commented on code in PR #112:
URL: https://github.com/apache/solr-sandbox/pull/112#discussion_r1806794392
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionTransactionLog.java:
##
@@ -140,28 +139,33 @@ private static void writeBEInt(OutputStream out
dsmiley commented on code in PR #112:
URL: https://github.com/apache/solr-sandbox/pull/112#discussion_r1806773936
##
encryption/src/main/java/org/apache/solr/encryption/EncryptionTransactionLog.java:
##
@@ -140,28 +139,33 @@ private static void writeBEInt(OutputStream outputStre
dsmiley commented on issue #109:
URL: https://github.com/apache/solr-sandbox/issues/109#issuecomment-2422740637
I suppose IndexWriter.commit() is risky for index encryption... we must
always guarantee there is commit metadata? This seems fragile; hard to
guarantee, and with bad consequences
dsmiley commented on PR #113:
URL: https://github.com/apache/solr-sandbox/pull/113#issuecomment-2422735985
I suppose IndexWriter.commit() is risky for index encryption... we must
always guarantee there is commit metadata? It seems this is fragile right now.
I did find-usages and I see two
dsmiley closed pull request #113: Transfer encryption metadata in the commit
when DirectUpdateHandler2.closeWriter is called.
URL: https://github.com/apache/solr-sandbox/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
janhoy closed pull request #2775: feat: Added Elestio as one-click deploy option
URL: https://github.com/apache/solr/pull/2775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Bruno Roustant created SOLR-17504:
-
Summary: DirectUpdateHandler2.closeWriter supports commit metadata
Key: SOLR-17504
URL: https://issues.apache.org/jira/browse/SOLR-17504
Project: Solr
Issu
[
https://issues.apache.org/jira/browse/SOLR-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck updated SOLR-17503:
Summary: Umbrella: Move to Jakarta J2EE packages (was: Move to Jakarta
J2EE packages)
> Umbrella: Move to
[
https://issues.apache.org/jira/browse/SOLR-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17503:
---
Issue Type: Improvement (was: Bug)
> Umbrella: Move to Jakarta J2EE packages
> -
[
https://issues.apache.org/jira/browse/SOLR-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890974#comment-17890974
]
Gus Heck commented on SOLR-17503:
-
{quote}"Jetty 12.x supports multiple servlet versions
[
https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890970#comment-17890970
]
David Smiley commented on SOLR-16503:
-
One issue but multiple PRs and thus commits.
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890967#comment-17890967
]
David Smiley commented on SOLR-15730:
-
Shrug; neutral. I would suggest not investing
malliaridis commented on PR #2778:
URL: https://github.com/apache/solr/pull/2778#issuecomment-2422560595
> The whole Solr Base Path and /solr suffix is a mess, and it is different
in main than in branch_9x. So this will keep cropping up for as long as we
backport stuff from 10 to 9 :(
[
https://issues.apache.org/jira/browse/SOLR-17502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890963#comment-17890963
]
Sebastian Hofmann commented on SOLR-17502:
--
It seems like this is the case for a
[
https://issues.apache.org/jira/browse/SOLR-17502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Hofmann updated SOLR-17502:
-
Summary: request forwarding does not work with http/2 (was: overlay
request forwarding d
[
https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890961#comment-17890961
]
Jan Høydahl commented on SOLR-16503:
[~sanjaydutt] , [~dsmiley] Is this done and can
[
https://issues.apache.org/jira/browse/SOLR-16895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16895:
---
Fix Version/s: main (10.0)
> Ensure Major Changes in Solr 10 Updated for CLI Changes
> --
epugh commented on PR #2758:
URL: https://github.com/apache/solr/pull/2758#issuecomment-2422506868
Can I get a LGTM and then I'll add CHANGES.txt and merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890958#comment-17890958
]
Jan Høydahl commented on SOLR-15730:
Picking up this as we approach 10.0.
We still n
[
https://issues.apache.org/jira/browse/SOLR-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck updated SOLR-17503:
Fix Version/s: 10.x
> Move to Jakarta J2EE packages
> -
>
> Key
[
https://issues.apache.org/jira/browse/SOLR-17494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890956#comment-17890956
]
ASF subversion and git services commented on SOLR-17494:
Commit 6
epugh merged PR #2766:
URL: https://github.com/apache/solr/pull/2766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
malliaridis commented on PR #2744:
URL: https://github.com/apache/solr/pull/2744#issuecomment-2422403472
This PR is related and should be blocked by #2778 for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
malliaridis commented on PR #2744:
URL: https://github.com/apache/solr/pull/2744#issuecomment-2422402462
> Is this able to backwards ported to 9x? Seems good stuff!
I think I could create a separate PR for backporting if we want these
changes in 9x as well. I think a cherry-pick won't do
[
https://issues.apache.org/jira/browse/SOLR-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890945#comment-17890945
]
Jan Høydahl commented on SOLR-17503:
Note the comment on SOLR-17069 "Jetty 12.x suppo
[
https://issues.apache.org/jira/browse/SOLR-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890943#comment-17890943
]
Jan Høydahl commented on SOLR-17503:
Thanks for bringin this up. A good time to start
[
https://issues.apache.org/jira/browse/SOLR-17503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890935#comment-17890935
]
Gus Heck commented on SOLR-17503:
-
Also related: [https://github.com/apache/solr/pull/276
epugh commented on code in PR #2766:
URL: https://github.com/apache/solr/pull/2766#discussion_r1806392282
##
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##
@@ -77,6 +77,11 @@ users may pass `partialResults=false`.
This feature has been improved
Gus Heck created SOLR-17503:
---
Summary: Move to Jakarta J2EE packages
Key: SOLR-17503
URL: https://issues.apache.org/jira/browse/SOLR-17503
Project: Solr
Issue Type: Bug
Security Level: Public
janhoy commented on PR #2776:
URL: https://github.com/apache/solr/pull/2776#issuecomment-2422261003
Tests fail here due to other issues on branch_9x, see #2778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
bruno-roustant commented on issue #109:
URL: https://github.com/apache/solr-sandbox/issues/109#issuecomment-2422249962
I created a [PR](https://github.com/apache/solr-sandbox/pull/113) to show
how to fix, with a test. But the real fix requires a change in the Solr project
upstream. I'm goin
bruno-roustant commented on code in PR #113:
URL: https://github.com/apache/solr-sandbox/pull/113#discussion_r1806335514
##
encryption/src/main/java/org/apache/solr/update/DirectUpdateHandler2.java:
##
@@ -0,0 +1,1116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
janhoy commented on code in PR #2778:
URL: https://github.com/apache/solr/pull/2778#discussion_r1806335724
##
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##
@@ -315,8 +315,7 @@ public void runImpl(CommandLine cli) throws Exception {
throw new IllegalArgumentEx
bruno-roustant commented on code in PR #113:
URL: https://github.com/apache/solr-sandbox/pull/113#discussion_r1806335514
##
encryption/src/main/java/org/apache/solr/update/DirectUpdateHandler2.java:
##
@@ -0,0 +1,1116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
bruno-roustant opened a new pull request, #113:
URL: https://github.com/apache/solr-sandbox/pull/113
Actually this requires to change DirectUpdateHandler2.closeWriter in the
Solr project.
This PR shows the small required change (see comment in the
DirectUpdateHandler2 copy), and verifies
janhoy commented on PR #2712:
URL: https://github.com/apache/solr/pull/2712#issuecomment-240749
Note that until now, the only supported syntax has been `bin/solr status`
for user-facing, and `bin/solr status --solr-url --max-wait-secs `
for scripts. So that's the only we need to worry
janhoy commented on PR #2712:
URL: https://github.com/apache/solr/pull/2712#issuecomment-2422212816
Did another pass at cleaning up some convoluted code, and remove some
duplicate printout. Here I have copied the command response from some local
tests. Will probably commit soon if you think
epugh commented on code in PR #2778:
URL: https://github.com/apache/solr/pull/2778#discussion_r1806318932
##
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##
@@ -315,8 +315,7 @@ public void runImpl(CommandLine cli) throws Exception {
throw new IllegalArgumentExc
epugh commented on PR #2778:
URL: https://github.com/apache/solr/pull/2778#issuecomment-2422205861
@janhoy thanks for taking a stab at this... I definitly have been playing
"whack a mole" of adding and removing /solr/'s in various places. I will go
through this today I appreciate yo
janhoy commented on code in PR #2778:
URL: https://github.com/apache/solr/pull/2778#discussion_r1806175920
##
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##
@@ -315,8 +315,7 @@ public void runImpl(CommandLine cli) throws Exception {
throw new IllegalArgumentEx
bruno-roustant opened a new pull request, #112:
URL: https://github.com/apache/solr-sandbox/pull/112
A transaction log can be accessed by multiple threads concurrently. Reading
the encryption header must be thread safe.
The fix is to use FileChannel.read(ByteBuffer, long) to read at a spe
janhoy commented on code in PR #2778:
URL: https://github.com/apache/solr/pull/2778#discussion_r1806099337
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -792,11 +792,10 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
Str
janhoy commented on code in PR #2778:
URL: https://github.com/apache/solr/pull/2778#discussion_r1806091901
##
solr/core/src/java/org/apache/solr/cli/AssertTool.java:
##
@@ -531,7 +530,7 @@ private static boolean isSolrRunningOn(String url) throws
Exception {
}
private s
janhoy opened a new pull request, #2778:
URL: https://github.com/apache/solr/pull/2778
Draft PR to get a green state in branch_9x
Tests used to pass on branch_9x a few days ago. Some of the many `SolrCLI`
changes touched the urlNormalization stuff so that you needed to add `/solr` at
78 matches
Mail list logo
