malliaridis commented on PR #2778: URL: https://github.com/apache/solr/pull/2778#issuecomment-2422560595
> The whole Solr Base Path and /solr suffix is a mess, and it is different in main than in branch_9x. So this will keep cropping up for as long as we backport stuff from 10 to 9 :( I would love to have less classes touching the URL and base path. This was also one of the goals of the merge in https://github.com/apache/solr/pull/2756. Unifying the options that accept a URL should reduce the possible input variations, allowing us to simplify the logic internally. About the remaining failing test `PostToolTest#testBasicRun`: currently passes a URL with `--solr-url` that includes `/solr`, but this is probably wrong. A `/solr` path in the URL is only allowed in `--solr-update-url`, which was deprecated and replaced in https://github.com/apache/solr/pull/2756. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
